Re: [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 955 bytes --]

On 11/13/25 07:27, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> These could affect the script.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>>  scripts/run-qemu.sh | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> Makes sense.
> 
>> diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh
>> index 14c58729dfceb3a0d2566fcfe076d6c10433419f..ba32467956a509b1744ade461f2fe5f20ae7a5b9 100755
>> --- a/scripts/run-qemu.sh
>> +++ b/scripts/run-qemu.sh
>> @@ -9,12 +9,15 @@ if [ -n ${ARCH+test} ]; then
>>  	ARCH=$(uname -m)
>>  fi
>>  
>> +unset kernel
>> +
> 
> Would be clearer if this was attached to the for loop that actually sets
> kernel, I think.  Then as I reader I don't need to keep it in my head
> for as long.  (I can make this change and commit if you agree.)

Feel free to fix up on commit.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]