patches and low-level development discussion
 help / color / mirror / code / Atom feed
blob c63d7e5a4aa73429578704401c58bbafc79e7c3f 10394 bytes (raw)
name: tools/cgroup-setup/src/cgroup.rs 	 # note: path name is non-authoritative(*)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
 
// SPDX-FileCopyrightText: 2026 Demi Marie Obenour <demiobenour@gmail.com>
// SPDX-License-Identifier: EUPL-1.2+

use std::ffi::OsStr;
use std::fs::File;
use std::io::{Read as _, Seek as _, Write as _};
use std::os::unix::prelude::*;

use std::path::{Component, Path, PathBuf};

use rustix::fs::{AtFlags, CWD, Dir, FlockOperation};
use rustix::path;
use rustix::{
    fs::{Mode, OFlags, ResolveFlags},
    io::Errno,
};

pub enum OpenFlags {
    Read,
    Write,
    Directory,
}

#[derive(Debug)]
pub(crate) struct Cgroup {
    fd: Vec<OwnedFd>,
}

impl AsFd for Cgroup {
    fn as_fd(&self) -> BorrowedFd<'_> {
        self.fd.last().unwrap().as_fd()
    }
}

fn assert_single_component(component: &Path) {
    match component.as_os_str().as_bytes() {
        b"" | b"." | b".." => panic!("bad component"),
        c if c.contains(&b'\0') => panic!("NUL in component"),
        c if c.contains(&b'/') => panic!("/ in component"),
        _ => {}
    }
}

// Wrapper around openat2() with better defaults.
pub fn openat2_simple(
    fd: impl AsFd,
    path: impl path::Arg,
    flags: OpenFlags,
) -> Result<OwnedFd, Errno> {
    rustix::fs::openat2(
        fd.as_fd(),
        path,
        OFlags::CLOEXEC
            | match flags {
                OpenFlags::Read => OFlags::RDONLY | OFlags::NOCTTY,
                OpenFlags::Write => OFlags::WRONLY | OFlags::NOCTTY,
                OpenFlags::Directory => OFlags::RDONLY | OFlags::DIRECTORY,
            },
        Mode::empty(),
        ResolveFlags::NO_SYMLINKS | ResolveFlags::NO_MAGICLINKS | ResolveFlags::NO_XDEV,
    )
}

pub const DEFAULT_LEAF: &str = "$inner.service";

pub fn check_path(path: &Path) -> Result<(), String> {
    let bytes = path.as_os_str().as_bytes();
    // Path::components() skips ., so use string manipulation instead.
    for component in bytes[path.is_absolute() as usize..].split(|&b| b == b'/') {
        if matches!(component, b"" | b"." | b"..") {
            return Err(format!("cgroup path {path:?} isn't canonical"));
        }
    }
    Ok(())
}

// Remove all subdirectories of the given directory recursively,
// but not the directory itself.  The directory file descriptor
// is closed.
//
// This isn't the most efficient possible algorithm, but
// simplicity is more important than performance in this
// case.  Also, it keeps open more file descriptors than
// strictly necessary, but Spectrum runs with a very high
// limit for the number of open file descriptors, and it
// uses shallow control group hierarchies.
//
// This uses a recursive algorith, but so does std::fs::remove_dir_all().
// Trying to be more robust than the standard library is not worthwhile.
// In particular, the standard library function must be safe on systems
// where untrusted users (or even network endpoints!) can create deeply
// nested directory trees, whereas in Spectrum cgroups are only writeable
// by root.
fn remove_recursively(mut dirfd: Dir, remaining_depth: usize) -> Result<(), Errno> {
    if remaining_depth < 1 {
        panic!("control groups too deeply nested");
    }
    while let Some(element) = dirfd.next() {
        let parent_fd = dirfd.fd().unwrap();
        let element = element.expect("Iterating through a cgroup directory failed?");
        let path = element.file_name();
        if element.file_type() != rustix::fs::FileType::Directory || path == c"." || path == c".." {
            continue;
        }
        let fd = openat2_simple(parent_fd, path, OpenFlags::Directory)?;
        remove_recursively(Dir::new(fd).unwrap(), remaining_depth - 1)?;
        match rustix::fs::unlinkat(parent_fd, path, AtFlags::REMOVEDIR) {
            Err(Errno::NOTEMPTY | Errno::BUSY | Errno::NOENT) | Ok(()) => {}
            bad => return bad,
        }
    }
    Ok(())
}

// If the path is absolute, make it relative.
// Otherwise, read the current cgroup from /proc/thread-self/cgroup
// and prepend it to the path.
fn prepend_current_cgroup_if_needed(path: &Path) -> PathBuf {
    if let Ok(suffix) = path.strip_prefix("/") {
        suffix.to_owned()
    } else {
        // /proc/thread-self is the same as /proc/self, except for the current
        // thread instead of the initial thread.  In this case, the two are
        // identical, but using /proc/thread-self is better practice as it is
        // correct in more cases.  Reading /proc/thread-self/cgroup should
        // never fail unless the system is seriously broken.
        let current_cgroup = std::fs::read("/proc/thread-self/cgroup")
            .expect("cannot read /proc/thread-self/cgroup");
        // Using this on a system without cgroups v2 mounted is user error
        // and not supported.
        let current_cgroup = current_cgroup
            .strip_prefix(b"0::/")
            .and_then(|e| e.strip_suffix(b"\n"))
            .expect("you don't have cgroups v2 mounted");
        let mut current_cgroup = PathBuf::from(OsStr::from_bytes(current_cgroup));
        // Strip the implied $inner.service suffix.
        // This is used to satisfy the "no internal processes" rule.
        if current_cgroup.ends_with(Path::new(DEFAULT_LEAF)) {
            assert!(current_cgroup.pop());
        }
        current_cgroup.push(path);
        current_cgroup
    }
}

pub(crate) fn write_value(fd: &dyn AsFd, name: &Path, value: &[u8]) -> Result<(), String> {
    let fd = openat2_simple(fd, name, OpenFlags::Write)
        .map_err(|e| format!("Cannot open {name:?}: {e}"))?;
    File::from(fd).write_all(value).map_err(|e| {
        format!(
            "Cannot write {:?} to {name:?}: {e}",
            OsStr::from_bytes(value)
        )
    })
}

impl Cgroup {
    pub fn new(path: &Path) -> Result<Self, String> {
        let cgroup_root = rustix::fs::openat2(
            CWD,
            Path::new("/sys/fs/cgroup"),
            OFlags::CLOEXEC | OFlags::DIRECTORY | OFlags::RDONLY,
            Mode::empty(),
            ResolveFlags::NO_SYMLINKS | ResolveFlags::NO_MAGICLINKS,
        )
        .map_err(|e| format!("Cannot open /sys/fs/cgroup: {e}"))?;
        let mut cgroup = Self {
            fd: vec![(cgroup_root)],
        };

        let path = prepend_current_cgroup_if_needed(path);
        for component in path.components() {
            let Component::Normal(component) = component else {
                unreachable!()
            };
            let sub_fd = openat2_simple(&cgroup, component, OpenFlags::Directory)
                .map_err(|e| format!("Cannot open sub-cgroup {component:?}: {e}"))?;
            // Take a shared lock on the cgroup.
            rustix::fs::flock(&sub_fd, FlockOperation::LockShared)
                .map_err(|e| format!("Cannot lock sub-cgroup {component:?}: {e}"))?;
            cgroup.fd.push(sub_fd);
        }
        Ok(cgroup)
    }

    pub fn wait_for_empty(fd: &dyn AsFd) -> std::io::Result<()> {
        let wait_file = openat2_simple(fd, c"cgroup.events", OpenFlags::Read)?;
        let mut wait_fd = File::from(wait_file);
        let mut v = vec![];
        loop {
            v.clear();
            wait_fd
                .seek(std::io::SeekFrom::Start(0))
                .expect("Seek on control group file should succeed");
            wait_fd
                .read_to_end(&mut v)
                .expect("reading from control group should work");
            // Check that the cgroup isn't already empty.  If it was,
            // the kernel would not send an event and poll() would wait
            // forever.
            if v.split(|&c| c == b'\n').any(|line| line == b"populated 0") {
                break;
            }
            let mut fds = libc::pollfd {
                fd: wait_fd.as_raw_fd(),
                events: libc::POLLPRI | libc::POLLERR,
                revents: 0,
            };
            // SAFETY: FFI call, valid arguments, fds contains 1 element
            if unsafe { libc::poll(&raw mut fds, 1, -1) } != 1 {
                panic!("poll failed");
            }
        }
        drop(wait_fd);
        Ok(())
    }

    pub fn purge_child(&mut self, path: &Path) -> Result<(), String> {
        assert_single_component(path);
        // See if we can just delete the child directly.
        match rustix::fs::unlinkat(&self, Path::new(path), AtFlags::REMOVEDIR) {
            // If the cgroup was successfully deleted, or if it
            // has already been deleted, we are done.
            Ok(()) | Err(Errno::NOENT) => return Ok(()),
            // If this cgroup is in use, keep going.
            Err(Errno::BUSY) => {}
            Err(e) => return Err(format!("Cannot purge {path:?}: {e}")),
        }

        let sub_fd = match openat2_simple(&self, path, OpenFlags::Directory) {
            Ok(sub_fd) => sub_fd,
            Err(Errno::NOENT) => return Ok(()),
            Err(e) => {
                return Err(format!("Cannot open sub-cgroup {path:?}: {e}",));
            }
        };

        // Take an exclusive lock on the cgroup that is about to be
        // removed.  This avoids concurrent executions of this program
        // operating on deleted sub-cgroups.
        rustix::fs::flock(&sub_fd, FlockOperation::LockExclusive)
            .map_err(|e| format!("Cannot lock sub-cgroup: {e}"))?;

        // Kill all processes in the child cgroup.
        write_value(&sub_fd, Path::new("cgroup.kill"), b"1")?;

        // Wait for the child cgroup to become empty.
        Self::wait_for_empty(&sub_fd)
            .map_err(|e| format!("Cannot wait for cgroup to become empty: {e}"))
            .inspect_err(|_| {
                self.fd.pop().unwrap();
            })?;

        // Remove the child cgroup and its contents recursively.
        remove_recursively(Dir::new(sub_fd).unwrap(), 1000)
            .map_err(|e| format!("Cannot remove: {e}"))?;

        // Delete the cgroup.  If it's been re-created in the meantime
        // and is currently in use, this is not an error.  Another
        // process deleting the cgroup is also not an error.  Both of
        // these can happen because of the time period between
        // remove_child_directories() closing the file descriptor
        // (releasing its lock) and the above call to flock().
        match rustix::fs::unlinkat(&self, path, AtFlags::REMOVEDIR) {
            Ok(()) | Err(Errno::BUSY) | Err(Errno::NOENT) => Ok(()),
            Err(e) => Err(format!("Cannot delete: {e}")),
        }
    }
}

debug log:

solving c63d7e5a4aa73429578704401c58bbafc79e7c3f ...
found c63d7e5a4aa73429578704401c58bbafc79e7c3f in https://inbox.spectrum-os.org/spectrum-devel/20260805-cgroups-v6-2-086c0f00f55f@gmail.com/

applying [1/1] https://inbox.spectrum-os.org/spectrum-devel/20260805-cgroups-v6-2-086c0f00f55f@gmail.com/
diff --git a/tools/cgroup-setup/src/cgroup.rs b/tools/cgroup-setup/src/cgroup.rs
new file mode 100644
index 0000000000000000000000000000000000000000..c63d7e5a4aa73429578704401c58bbafc79e7c3f

Checking patch tools/cgroup-setup/src/cgroup.rs...
Applied patch tools/cgroup-setup/src/cgroup.rs cleanly.

index at:
100644 c63d7e5a4aa73429578704401c58bbafc79e7c3f	tools/cgroup-setup/src/cgroup.rs

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).