From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B8A8C21D98; Thu, 13 Nov 2025 22:33:13 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id E0C4421D8B; Thu, 13 Nov 2025 22:33:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by atuin.qyliss.net (Postfix) with ESMTPS id B98B921D88 for ; Thu, 13 Nov 2025 22:33:10 +0000 (UTC) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-787f586532bso14457287b3.1 for ; Thu, 13 Nov 2025 14:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763073189; x=1763677989; darn=spectrum-os.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IjaFlTyVnfAn+yfTOgA3NJJK9FVYYjBiMFftPVWfpuQ=; b=lS201zb5HaGQzpYXp1eLYmC88qyz7FSIp30M8b8Qfrcx+vgfYZA92OMd0CFdajvjD0 cKSA3yy6giroFkP/6kk+zQcPS2BYBW0ZBXDWlghgYm3GQUtRryE7aOn+GSXKsOOEa8js 0MVGzyvCAhmNTMyPIWjcq8eEbDvsZ0ILhhYOO2gw3HFNld9aE+4LPEItpj/r7KN/1IAd vNet7L9uWx9k8GwNmZRAoVLOG38stHyJId3hZfEamVzwq8UkS8TwJUNf0x6OTQn604A9 XMUIziv+hcBwiik2jVDMHvhDynyHdyBXZc6gXHR6uZR7WxZSQ1J8CUkhND+62N4r1RTn Of9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763073189; x=1763677989; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IjaFlTyVnfAn+yfTOgA3NJJK9FVYYjBiMFftPVWfpuQ=; b=g/777jxDj+XVr9kI4nYOo2tkgb07+KAcY8X6HX6zaQ8x2bS9DzRXEkUWVck1GhovEX AQ1KjNjk99h9RCWz9/Sc3MlqKVhGUVdvyh3ckyGWEdbIq1HPZub1EqFj20nukOwZVUmz qOJyyVotS7MCWsJ8GZwcC312YQ1ReZ62Eplaeb4/4xu7JRYGu8fgMfA0Ft9ObtMmjav5 l+b2vv8jk++3xVVKJFn0geCs7nyBP4KAfKDtGrpcs7VZDd1rxkvaodzdS+b2qKKTYmYP nmf4toVSq6zfpE9nzsrQ7wSO8T0UkxMHs0Ip4UlEE0k9EIrSu8hcJz2JM5HC/PwdbFIT ZAjg== X-Gm-Message-State: AOJu0YycbbSlT2geXCxfQaYCu33tYEPksrn2lHDnfXmPNKA7KfXtfC6X ZOPYh1E3pSua+gfwI0vbGpoxk9bTeYSQwtalFVk2Xim69H17+cOkX3PQ X-Gm-Gg: ASbGncuElum24QLQZF09aEp7FPMOV4ovMTWvfXxOpnfr7GpwvLphqUKgNQColQ51pYD Kdl+bWxw3+ocxNbKpAxcRITM1DHQAI3GwuLdj6aZ2QXq2MMTfy2ldhPXivG10kz5YSygBuJQY0F u/q8hdon1dzUP8v9YVwVcZEpp6s5F+l6k8yb0qR0S/b/O7v29WphGnxp0k9OQ3LoiiS5sBrzLSx H+ZYIpKdNZAWgtisMz/2B6vsLJC4ZawB57zW8hqWipYerN/q5Vr77JZW0V2I3F7dxZyl2JpvELC yZVZtxat2buQS81wpmxsDLqi+IWvv3m35jk/WBlQLzFxW00xVrsR+Vj5q0o0ilXIDymkJRIS1oV o242avf52Bv/Zns4St5LYM7kdyAjKBzpt74Ww/28lFnRpcgx+eoDuZvm7YwFAe8veICRBNe+e3Z 9VwUojxYHisMWy16nlrX+uSSaotwpJalJykLPi8N+/TI/iW1NN+qipupdmZpoxDgqXE0WaS5BTP dQRUfceSWrnAKNV X-Google-Smtp-Source: AGHT+IGvxGtGVR0/GRPQoDdwEL5z1pYOf/vhkbeTUa2RLuOJeUoO+I8VRPv30yJwMb/FNs6cjAaTqA== X-Received: by 2002:a05:690c:6f8e:b0:788:1b67:d741 with SMTP id 00721157ae682-78929e150cbmr12052127b3.3.1763073188807; Thu, 13 Nov 2025 14:33:08 -0800 (PST) Received: from [10.138.34.110] (h96-60-249-169.cncrtn.broadband.dynamic.tds.net. [96.60.249.169]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7882214c4c1sm10362427b3.43.2025.11.13.14.33.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 14:33:07 -0800 (PST) Message-ID: Date: Thu, 13 Nov 2025 17:33:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Build verity images in rootfs Nix derivation To: Alyssa Ross References: <20251111-refactor-verity-v3-0-575726639f9e@gmail.com> <20251111-refactor-verity-v3-1-575726639f9e@gmail.com> <87346ii29m.fsf@alyssa.is> Content-Language: en-US From: Demi Marie Obenour Autocrypt: addr=demiobenour@gmail.com; keydata= xsFNBFp+A0oBEADffj6anl9/BHhUSxGTICeVl2tob7hPDdhHNgPR4C8xlYt5q49yB+l2nipd aq+4Gk6FZfqC825TKl7eRpUjMriwle4r3R0ydSIGcy4M6eb0IcxmuPYfbWpr/si88QKgyGSV Z7GeNW1UnzTdhYHuFlk8dBSmB1fzhEYEk0RcJqg4AKoq6/3/UorR+FaSuVwT7rqzGrTlscnT DlPWgRzrQ3jssesI7sZLm82E3pJSgaUoCdCOlL7MMPCJwI8JpPlBedRpe9tfVyfu3euTPLPx wcV3L/cfWPGSL4PofBtB8NUU6QwYiQ9Hzx4xOyn67zW73/G0Q2vPPRst8LBDqlxLjbtx/WLR 6h3nBc3eyuZ+q62HS1pJ5EvUT1vjyJ1ySrqtUXWQ4XlZyoEFUfpJxJoN0A9HCxmHGVckzTRl 5FMWo8TCniHynNXsBtDQbabt7aNEOaAJdE7to0AH3T/Bvwzcp0ZJtBk0EM6YeMLtotUut7h2 Bkg1b//r6bTBswMBXVJ5H44Qf0+eKeUg7whSC9qpYOzzrm7+0r9F5u3qF8ZTx55TJc2g656C 9a1P1MYVysLvkLvS4H+crmxA/i08Tc1h+x9RRvqba4lSzZ6/Tmt60DPM5Sc4R0nSm9BBff0N m0bSNRS8InXdO1Aq3362QKX2NOwcL5YaStwODNyZUqF7izjK4QARAQABzTxEZW1pIE1hcmll IE9iZW5vdXIgKGxvdmVyIG9mIGNvZGluZykgPGRlbWlvYmVub3VyQGdtYWlsLmNvbT7CwXgE EwECACIFAlp+A0oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELKItV//nCLBhr8Q AK/xrb4wyi71xII2hkFBpT59ObLN+32FQT7R3lbZRjVFjc6yMUjOb1H/hJVxx+yo5gsSj5LS 9AwggioUSrcUKldfA/PKKai2mzTlUDxTcF3vKx6iMXKA6AqwAw4B57ZEJoMM6egm57TV19kz PMc879NV2nc6+elaKl+/kbVeD3qvBuEwsTe2Do3HAAdrfUG/j9erwIk6gha/Hp9yZlCnPTX+ VK+xifQqt8RtMqS5R/S8z0msJMI/ajNU03kFjOpqrYziv6OZLJ5cuKb3bZU5aoaRQRDzkFIR 6aqtFLTohTo20QywXwRa39uFaOT/0YMpNyel0kdOszFOykTEGI2u+kja35g9TkH90kkBTG+a EWttIht0Hy6YFmwjcAxisSakBuHnHuMSOiyRQLu43ej2+mDWgItLZ48Mu0C3IG1seeQDjEYP tqvyZ6bGkf2Vj+L6wLoLLIhRZxQOedqArIk/Sb2SzQYuxN44IDRt+3ZcDqsPppoKcxSyd1Ny 2tpvjYJXlfKmOYLhTWs8nwlAlSHX/c/jz/ywwf7eSvGknToo1Y0VpRtoxMaKW1nvH0OeCSVJ itfRP7YbiRVc2aNqWPCSgtqHAuVraBRbAFLKh9d2rKFB3BmynTUpc1BQLJP8+D5oNyb8Ts4x Xd3iV/uD8JLGJfYZIR7oGWFLP4uZ3tkneDfYzsFNBFp+A0oBEAC9ynZI9LU+uJkMeEJeJyQ/ 8VFkCJQPQZEsIGzOTlPnwvVna0AS86n2Z+rK7R/usYs5iJCZ55/JISWd8xD57ue0eB47bcJv VqGlObI2DEG8TwaW0O0duRhDgzMEL4t1KdRAepIESBEA/iPpI4gfUbVEIEQuqdqQyO4GAe+M kD0Hy5JH/0qgFmbaSegNTdQg5iqYjRZ3ttiswalql1/iSyv1WYeC1OAs+2BLOAT2NEggSiVO txEfgewsQtCWi8H1SoirakIfo45Hz0tk/Ad9ZWh2PvOGt97Ka85o4TLJxgJJqGEnqcFUZnJJ riwoaRIS8N2C8/nEM53jb1sH0gYddMU3QxY7dYNLIUrRKQeNkF30dK7V6JRH7pleRlf+wQcN fRAIUrNlatj9TxwivQrKnC9aIFFHEy/0mAgtrQShcMRmMgVlRoOA5B8RTulRLCmkafvwuhs6 dCxN0GNAORIVVFxjx9Vn7OqYPgwiofZ6SbEl0hgPyWBQvE85klFLZLoj7p+joDY1XNQztmfA rnJ9x+YV4igjWImINAZSlmEcYtd+xy3Li/8oeYDAqrsnrOjb+WvGhCykJk4urBog2LNtcyCj kTs7F+WeXGUo0NDhbd3Z6AyFfqeF7uJ3D5hlpX2nI9no/ugPrrTVoVZAgrrnNz0iZG2DVx46 x913pVKHl5mlYQARAQABwsFfBBgBAgAJBQJafgNKAhsMAAoJELKItV//nCLBwNIP/AiIHE8b oIqReFQyaMzxq6lE4YZCZNj65B/nkDOvodSiwfwjjVVE2V3iEzxMHbgyTCGA67+Bo/d5aQGj gn0TPtsGzelyQHipaUzEyrsceUGWYoKXYyVWKEfyh0cDfnd9diAm3VeNqchtcMpoehETH8fr RHnJdBcjf112PzQSdKC6kqU0Q196c4Vp5HDOQfNiDnTf7gZSj0BraHOByy9LEDCLhQiCmr+2 E0rW4tBtDAn2HkT9uf32ZGqJCn1O+2uVfFhGu6vPE5qkqrbSE8TG+03H8ecU2q50zgHWPdHM OBvy3EhzfAh2VmOSTcRK+tSUe/u3wdLRDPwv/DTzGI36Kgky9MsDC5gpIwNbOJP2G/q1wT1o Gkw4IXfWv2ufWiXqJ+k7HEi2N1sree7Dy9KBCqb+ca1vFhYPDJfhP75I/VnzHVssZ/rYZ9+5 1yDoUABoNdJNSGUYl+Yh9Pw9pE3Kt4EFzUlFZWbE4xKL/NPno+z4J9aWemLLszcYz/u3XnbO vUSQHSrmfOzX3cV4yfmjM5lewgSstoxGyTx2M8enslgdXhPthZlDnTnOT+C+OTsh8+m5tos8 HQjaPM01MKBiAqdPgksm1wu2DrrwUi6ChRVTUBcj6+/9IJ81H2P2gJk3Ls3AVIxIffLoY34E +MYSfkEjBz0E8CLOcAw7JIwAaeBT In-Reply-To: <87346ii29m.fsf@alyssa.is> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4uYNTR7OnvFRq4my0Tjwh0YR" Message-ID-Hash: Z2WR4Q2CQOB6M5CR6XU2G6YJLDD7XJLA X-Message-ID-Hash: Z2WR4Q2CQOB6M5CR6XU2G6YJLDD7XJLA X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4uYNTR7OnvFRq4my0Tjwh0YR Content-Type: multipart/mixed; boundary="------------JVkhrOmBS0CpSktGtXU3MfEG"; protected-headers="v1" From: Demi Marie Obenour To: Alyssa Ross Cc: Spectrum OS Development Message-ID: Subject: Re: [PATCH v3 1/2] Build verity images in rootfs Nix derivation References: <20251111-refactor-verity-v3-0-575726639f9e@gmail.com> <20251111-refactor-verity-v3-1-575726639f9e@gmail.com> <87346ii29m.fsf@alyssa.is> In-Reply-To: <87346ii29m.fsf@alyssa.is> Autocrypt-Gossip: addr=hi@alyssa.is; keydata= xsFNBFpSgoYBEAC4xkCYidG2JlRWulUkTWcx0pHFDf3oSbb6Q872Kb3iDChWgluNVz43hva1 3xfDo9foV0GoyfGl/ycSCkXX5hlQr7ir/5FN38E7H/yY6tH8+l68iDgIOcb1qY0OYaxyg+Lz WesfFQedrmwNTbF4L1BtWzrTR5PflDdhDo5VWSguHGJFSclchcr/6UmMb/gOUN+2ElBC2TE2 EKY099phZ6DJZ2aZCsclwKIdCpZzXlEmXPAeaH5om6xo90JYv5+sFji40R0Plqec3WC+jTxy lGca6IbPdOminuUF+GvsR86eVsgh/0XNK7/zus7gyc4PuMUA1rCoeHcWOBDPgmelgCQyJGXd /bXeKuUsGoge58uc7/YNvOh1vfpD3AaEMqAyXfmmUwBnIicml74+2eOpH3Oljfs01g+DhkOB MtpVSZSgaIDvP0WG6cbAxImoUasnmNxEDNskfVmI8bsajPW9bt4z5hiP5Q9G3vE0D5HcIFdM adOz81PpOwNiUXcjtYV1PWZQ56jbSTOf8EBvsB71WwB+XgVWcPzIlY8hAykiHIO87oV3o71U JTAn1Foj7mjSADnY0deleOmar/K5jrK3wvKKM1XlB7PXcGBdkorJC+cbxVsw0ADzMw0c7bVc wEE7OFvHjQiIK1lO+lb1cvGBBY3IZxjsjZdA/VsFHFdAeYlzNQARAQABzRpBbHlzc2EgUm9z cyA8aGlAYWx5c3NhLmlzPsLBlwQTAQgAQQIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAIZ ARYhBHVzVtd5u7iIdz5BXnNszfnvUb2XBQJpALHXBQkPJNZRAAoJEHNszfnvUb2X2jEP/AqQ aafKiC7ormevgoCH4QinAKJoXAqiwOIdRK55HOvyhGWjnlzqoK4JTUFVRMR4Vat/APlkjOUk LPXKk+DCn4loFyl7BCLvsk4Xwy7WmXyfSPqjdik8/cjTv/Q4AHTYTpnx7GMC5eTS7ULmUvcf mD/JRr7NM2273Z7dkL3gOeZdnXYOQaGAIIox91qCtmnQhn+V7s3uxvcRl8I2/Qnn3S2veV03 LXSugAXSTdKRa7LBrcSm9TtC/D3qY9kStHiaiB/eAJsOQ0l5yRfax5INorE2DQgBKjbiBcnQ mTX7Rl9LW+U0ibHmKOFG8Zs+zKlmItek49cmqoGOv66RAY6dGUOHoEQgP0EUDJ8xGwActToC lOGZrzcXfrfx0CYlgqYE1VEWgSmtbTW1DBXiZIPKUMLJGhgaIHSKEjYujHd+vGytAMGKQsVQ OwgOMHYWyzAIB/Y6hZGNK8y5fxr468zX876mDdXhYo4dKA7UEOeQOlAIGobTXDRFEC7B/UAj qYbP+qmnyUohCy/Pf04cF0ucpWW2Z00sBL83lauhyQHiLze5OznvOeEkEeXQ6DsJOY0dmrsi 0NJZ1QoyYewXOPmPBNc7IesY1MjrpAnHgeAt1rgEPwTkt4NrRASsPe5JowJcc7CpIdR8eOrG hrw+bEMyoyjk7fN6Hs6MK+hVihMNhUwMzjgEZyd/yxIKKwYBBAGXVQEFAQEHQCVxoiHOlsEo NDKGCbxg4nL3E1CV0MRQCU1hPowd77h3AwEIB8LBfAQYAQoAJgIbDBYhBHVzVtd5u7iIdz5B XnNszfnvUb2XBQJpALHQBQkCT9j5AAoJEHNszfnvUb2XhSMP/0gStw42LjpjVLh+0HKWafs3 T9NJxtefYRbyu4wkkO0dss2pkl9gekZnvgktD0SzIe8AiMszs1rUWMG8zPXVWdMi7tSNm/IR WPa0XZDIoDwJY4T342nCvHeDsfoJnGg8o0nreI2djwO8sc9aeSevm60MQ9AouFBpS6Qw7f/Z LalXH4aWCCtvAO1o95lQXEoH4Lg4qnS6GxYMYi1u3IzrYdUu0By/Ccc5+AOOICgbJnpOoYQI bVDbdjMkj18JxxmpN5amOkPdiDndpzWkWm+oNhGUITYp6EuP1esRb35MgOmFGouvt5UdKpEl Egs2y5h9oR+kiiu9DhrC0UFL2CQ/HdiukCAxADKX3RE9m+mprSbvw7CsYmXUTH6WzPpvxpGx wQq7m2O7uy85u0HyVYkiWQiAfwCbEr1vrFU7gscBW+FcrLIODauovA9eZgA4d+cHRXfzsdKW u/QuVHsABh78LLIq008GcqJChSe4KHrJ5PUjkLnyp/Sshrmuyoy+DwqYky0KK4NtkaWa2o0B TFp+Kk2VCxWA8i/azPvTMzXOWNwqogISp5SwljiEx0hkyf0HvSb3gHfuGbZ+eGfWB+qy2pTD x/YriV5EfqkP+4+1cqXjasrQxyZUW0ULRke0j92Cgt+J722PIcOAb8vdSGF4AXczO+KMtNn9 wGxvGU7TX5ou --------------JVkhrOmBS0CpSktGtXU3MfEG Content-Type: multipart/mixed; boundary="------------ou90efZ0d6uibjlV6L0662g5" --------------ou90efZ0d6uibjlV6L0662g5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/13/25 06:46, Alyssa Ross wrote: > Demi Marie Obenour writes: >=20 >> Avoid redundant rebuilds of the rootfs verity superblock and roothash.= >> Remove duplicate code. Clean up Makefile to avoid temporary files. >> >> Signed-off-by: Demi Marie Obenour >> --- >> host/initramfs/Makefile | 26 +++++--------------------- >> host/initramfs/shell.nix | 4 +++- >> host/rootfs/Makefile | 45 +++++++++++++++++++++------------------= ------ >> host/rootfs/default.nix | 2 +- >> host/rootfs/shell.nix | 2 +- >> release/live/Makefile | 26 +++++--------------------- >> release/live/default.nix | 4 +++- >> 7 files changed, 39 insertions(+), 70 deletions(-) >=20 > Looking good! Thank you! >> diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile >> index cb13fbb35f065b67d291d4a35591d6f12720060c..102870ecba4456303414e2= 531ea592473ddfc1cf 100644 >> --- a/host/initramfs/Makefile >> +++ b/host/initramfs/Makefile >> @@ -35,26 +35,10 @@ build/mountpoints: >> cd build/mountpoints && mkdir -p $(MOUNTPOINTS) >> find build/mountpoints -mindepth 1 -exec touch -d @0 {} ';' >> =20 >> -# veritysetup format produces two files, but Make only (portably) >> -# supports one output per rule, so we combine the two outputs then >> -# define two more rules to separate them again. >> -build/rootfs.verity: $(ROOT_FS) >> - mkdir -p build >> - $(VERITYSETUP) format $(ROOT_FS) build/rootfs.verity.superblock.tmp = \ >> - | awk -F ':[[:blank:]]*' '$$1 =3D=3D "Root hash" {print $$2; exi= t}' \ >> - > build/rootfs.verity.roothash.tmp >> - cat build/rootfs.verity.roothash.tmp build/rootfs.verity.superblock.= tmp \ >> - > $@ >> - rm build/rootfs.verity.roothash.tmp build/rootfs.verity.superblock.t= mp >> -build/rootfs.verity.roothash: build/rootfs.verity >> - head -n 1 build/rootfs.verity > $@ >> -build/rootfs.verity.superblock: build/rootfs.verity >> - tail -n +2 build/rootfs.verity > $@ >> - >> -build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.s= h ../../scripts/sfdisk-field.awk build/rootfs.verity.superblock build/roo= tfs.verity.roothash $(ROOT_FS) >> +build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.s= h ../../scripts/sfdisk-field.awk $(ROOT_FS_VERITY) $(ROOT_FS_VERITY_ROOTH= ASH) $(ROOT_FS) >> ../../scripts/make-gpt.sh $@.tmp \ >> - build/rootfs.verity.superblock:verity:$$(../../scripts/format-uu= id.sh "$$(dd if=3Dbuild/rootfs.verity.roothash bs=3D32 skip=3D1 count=3D1= status=3Dnone)") \ >> - $(ROOT_FS):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 b= uild/rootfs.verity.roothash)") >> + "$$ROOT_FS_VERITY:verity:$$(../../scripts/format-uuid.sh "$$(dd "if=3D= $$ROOT_FS_VERITY_ROOTHASH" bs=3D32 skip=3D1 count=3D1 status=3Dnone)")" \= >=20 > Indentation got messed up here. >=20 > Given rootfs has a well-defined output structure, maybe we could just > write $(ROOT_FS)/rootfs.verity.roothash, so we don't need to define lot= s > of different environment variables in each component that uses the > verity data. >=20 > I think we should consistently use Make variable expansion rather than > shell variable expansion when we're using the variable in a Make > dependency line too, to avoid the possibility of them being different. Make expansion followed by shell expansion and just Make expansion aren't= even consistent with each other. >> diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile >> index f107ca44fcf1ad85af5788d87f6c772910d40072..d7764d9b796f1773b4bebd= 0d50eec52b9be29e42 100644 >> --- a/host/rootfs/Makefile >> +++ b/host/rootfs/Makefile >> @@ -6,7 +6,7 @@ >> include ../../lib/common.mk >> include file-list.mk >> =20 >> -dest =3D build/rootfs.erofs >> +dest =3D build >> =20 >> DIRS =3D \ >> dev \ >> @@ -46,15 +46,27 @@ FIFOS =3D etc/s6-linux-init/run-image/service/s6-s= vscan-log/fifo >> =20 >> BUILD_FILES =3D build/etc/s6-rc >> =20 >> -$(dest): ../../scripts/make-erofs.sh $(PACKAGES_FILE) $(FILES) $(BUIL= D_FILES) build/empty build/fifo file-list.mk >> - set -euo pipefail; \ >> +# This rule produces three files but Make only (portably) >> +# supports one output per rule. Instead of resorting to temporary >> +# files, a timestamp file is created as the last step. The actual >> +# outputs are produced as side-effects. >> +$(dest)/timestamp: ../../scripts/make-erofs.sh $(PACKAGES_FILE) $(FIL= ES) $(BUILD_FILES) build/empty build/fifo file-list.mk $(dest) >=20 > Semes a bit odd to install the timestamp in $(dest). >=20 >> { \ >> cat $(PACKAGES_FILE) ;\ >> for file in $(FILES) $(LINKS); do printf '%s\n%s\n' $$file "$${f= ile#image/}"; done ;\ >> for file in $(BUILD_FILES); do printf '%s\n%s\n' $$file $${file#= build/}; done ;\ >> printf 'build/empty\n%s\n' $(DIRS) ;\ >> printf 'build/fifo\n%s\n' $(FIFOS) ;\ >> - } | ../../scripts/make-erofs.sh $@ >> + } | ../../scripts/make-erofs.sh $(dest)/rootfs >> + $(VERITYSETUP) format \ >> + --root-hash-file $(dest)/rootfs.verity.roothash \ >> + -- $(dest)/rootfs $(dest)/rootfs.verity.superblock >> + # Add trailing newline >> + echo >> $(dest)/rootfs.verity.roothash >> + touch -- $(dest)/timestamp >=20 > I prefer smaller independent Make rules where possible. Can't the > verity data stay in a separate rule from make-erofs.sh? >=20 > Either way, change deserves a copyright header IMO. :) >=20 >> + >> +$(dest): >> + mkdir -p $(dest) >=20 > Would rather this was inlined into every target in $(dest), because > directories can be a bit confusing to me as Make targets. "Does the > target just create the directory, or does it create the directory and > everything in it?" sort of thing. Will fix. >> build/fifo: >> mkdir -p build >> @@ -83,25 +95,10 @@ clean: >> rm -rf build >> .PHONY: clean >> =20 >> -# veritysetup format produces two files, but Make only (portably) >> -# supports one output per rule, so we combine the two outputs then >> -# define two more rules to separate them again. >> -build/rootfs.verity: $(dest) >> - $(VERITYSETUP) format $(dest) build/rootfs.verity.superblock.tmp \ >> - | awk -F ':[[:blank:]]*' '$$1 =3D=3D "Root hash" {print $$2; exi= t}' \ >> - > build/rootfs.verity.roothash.tmp >> - cat build/rootfs.verity.roothash.tmp build/rootfs.verity.superblock.= tmp \ >> - > $@ >> - rm build/rootfs.verity.roothash.tmp build/rootfs.verity.superblock.t= mp >> -build/rootfs.verity.roothash: build/rootfs.verity >> - head -n 1 build/rootfs.verity > $@ >> -build/rootfs.verity.superblock: build/rootfs.verity >> - tail -n +2 build/rootfs.verity > $@ >> - >> -build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.s= h ../../scripts/sfdisk-field.awk build/rootfs.verity.superblock build/roo= tfs.verity.roothash $(dest) >> +build/live.img: ../../scripts/format-uuid.sh ../../scripts/make-gpt.s= h ../../scripts/sfdisk-field.awk $(dest)/timestamp >> ../../scripts/make-gpt.sh $@.tmp \ >> - build/rootfs.verity.superblock:verity:$$(../../scripts/format-uu= id.sh "$$(dd if=3Dbuild/rootfs.verity.roothash bs=3D32 skip=3D1 count=3D1= status=3Dnone)") \ >> - $(dest):root:$$(../../scripts/format-uuid.sh "$$(head -c 32 buil= d/rootfs.verity.roothash)") >> + $(dest)/rootfs.verity.superblock:verity:$$(../../scripts/format-= uuid.sh "$$(dd if=3D$(dest)/rootfs.verity.roothash bs=3D32 skip=3D1 count= =3D1 status=3Dnone)") \ >> + $(dest)/rootfs:root:$$(../../scripts/format-uuid.sh "$$(head -c = 32 $(dest)/rootfs.verity.roothash)") >> mv $@.tmp $@ >> =20 >> debug: >> @@ -111,7 +108,7 @@ debug: >> $(VMLINUX) >> .PHONY: debug >> =20 >> -run: build/live.img $(EXT_FS) build/rootfs.verity.roothash >> +run: build/live.img >=20 > What happened to $(EXT_FS)? Since commit 12b64009d9cde56b5629a832086d2c2311908ebe ("host/initramfs/extfs.nix: remove") it has been unused. I deleted it while changing other stuff in this line. --=20 Sincerely, Demi Marie Obenour (she/her/hers) --------------ou90efZ0d6uibjlV6L0662g5 Content-Type: application/pgp-keys; name="OpenPGP_0xB288B55FFF9C22C1.asc" Content-Disposition: attachment; filename="OpenPGP_0xB288B55FFF9C22C1.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsFNBFp+A0oBEADffj6anl9/BHhUSxGTICeVl2tob7hPDdhHNgPR4C8xlYt5q49y B+l2nipdaq+4Gk6FZfqC825TKl7eRpUjMriwle4r3R0ydSIGcy4M6eb0IcxmuPYf bWpr/si88QKgyGSVZ7GeNW1UnzTdhYHuFlk8dBSmB1fzhEYEk0RcJqg4AKoq6/3/ UorR+FaSuVwT7rqzGrTlscnTDlPWgRzrQ3jssesI7sZLm82E3pJSgaUoCdCOlL7M MPCJwI8JpPlBedRpe9tfVyfu3euTPLPxwcV3L/cfWPGSL4PofBtB8NUU6QwYiQ9H zx4xOyn67zW73/G0Q2vPPRst8LBDqlxLjbtx/WLR6h3nBc3eyuZ+q62HS1pJ5EvU T1vjyJ1ySrqtUXWQ4XlZyoEFUfpJxJoN0A9HCxmHGVckzTRl5FMWo8TCniHynNXs BtDQbabt7aNEOaAJdE7to0AH3T/Bvwzcp0ZJtBk0EM6YeMLtotUut7h2Bkg1b//r 6bTBswMBXVJ5H44Qf0+eKeUg7whSC9qpYOzzrm7+0r9F5u3qF8ZTx55TJc2g656C 9a1P1MYVysLvkLvS4H+crmxA/i08Tc1h+x9RRvqba4lSzZ6/Tmt60DPM5Sc4R0nS m9BBff0Nm0bSNRS8InXdO1Aq3362QKX2NOwcL5YaStwODNyZUqF7izjK4QARAQAB zTxEZW1pIE9iZW5vdXIgKElUTCBFbWFpbCBLZXkpIDxhdGhlbmFAaW52aXNpYmxl dGhpbmdzbGFiLmNvbT7CwY4EEwEIADgWIQR2h02fEza6IlkHHHGyiLVf/5wiwQUC X6YJvQIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRCyiLVf/5wiwWRhD/0Y R+YYC5Kduv/2LBgQJIygMsFiRHbR4+tWXuTFqgrxxFSlMktZ6gQrQCWe38WnOXkB oY6n/5lSJdfnuGd2UagZ/9dkaGMUkqt+5WshLFly4BnP7pSsWReKgMP7etRTwn3S zk1OwFx2lzY1EnnconPLfPBc6rWG2moA6l0WX+3WNR1B1ndqpl2hPSjT2jUCBWDV rGOUSX7r5f1WgtBeNYnEXPBCUUM51pFGESmfHIXQrqFDA7nBNiIVFDJTmQzuEqIy Jl67pKNgooij5mKzRhFKHfjLRAH4mmWZlB9UjDStAfFBAoDFHwd1HL5VQCNQdqEc /9lZDApqWuCPadZN+pGouqLysesIYsNxUhJ7dtWOWHl0vs7/3qkWmWun/2uOJMQh ra2u8nA9g91FbOobWqjrDd6x3ZJoGQf4zLqjmn/P514gb697788e573WN/MpQ5XI Fl7aM2d6/GJiq6LC9T2gSUW4rbPBiqOCeiUx7Kd/sVm41p9TOA7fEG4bYddCfDsN xaQJH6VRK3NOuBUGeL+iQEVF5Xs6Yp+U+jwvv2M5Lel3EqAYo5xXTx4ls0xaxDCu fudcAh8CMMqx3fguSb7Mi31WlnZpk0fDuWQVNKyDP7lYpwc4nCCGNKCj622ZSocH AcQmX28L8pJdLYacv9pU3jPy4fHcQYvmTavTqowGnM08RGVtaSBNYXJpZSBPYmVu b3VyIChsb3ZlciBvZiBjb2RpbmcpIDxkZW1pb2Jlbm91ckBnbWFpbC5jb20+wsF4 BBMBAgAiBQJafgNKAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRCyiLVf /5wiwYa/EACv8a2+MMou9cSCNoZBQaU+fTmyzft9hUE+0d5W2UY1RY3OsjFIzm9R /4SVccfsqOYLEo+S0vQMIIIqFEq3FCpXXwPzyimotps05VA8U3Bd7yseojFygOgK sAMOAee2RCaDDOnoJue01dfZMzzHPO/TVdp3OvnpWipfv5G1Xg96rwbhMLE3tg6N xwAHa31Bv4/Xq8CJOoIWvx6fcmZQpz01/lSvsYn0KrfEbTKkuUf0vM9JrCTCP2oz VNN5BYzqaq2M4r+jmSyeXLim922VOWqGkUEQ85BSEemqrRS06IU6NtEMsF8EWt/b hWjk/9GDKTcnpdJHTrMxTspExBiNrvpI2t+YPU5B/dJJAUxvmhFrbSIbdB8umBZs I3AMYrEmpAbh5x7jEjoskUC7uN3o9vpg1oCLS2ePDLtAtyBtbHnkA4xGD7ar8mem xpH9lY/i+sC6CyyIUWcUDnnagKyJP0m9ks0GLsTeOCA0bft2XA6rD6aaCnMUsndT ctrab42CV5XypjmC4U1rPJ8JQJUh1/3P48/8sMH+3krxpJ06KNWNFaUbaMTGiltZ 7x9DngklSYrX0T+2G4kVXNmjaljwkoLahwLla2gUWwBSyofXdqyhQdwZsp01KXNQ UCyT/Pg+aDcm/E7OMV3d4lf7g/CSxiX2GSEe6BlhSz+Lmd7ZJ3g32M1ARGVtaSBN YXJpZSBPYmVub3VyIChJVEwgRW1haWwgS2V5KSA8ZGVtaUBpbnZpc2libGV0aGlu Z3NsYWIuY29tPsLBjgQTAQgAOBYhBHaHTZ8TNroiWQcccbKItV//nCLBBQJgOEV+ AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJELKItV//nCLBKwoP/1WSnFdv SAD0g7fD0WlF+oi7ISFT7oqJnchFLOwVHK4Jg0e4hGn1ekWsF3Ha5tFLh4V/7UUu obYJpTfBAA2CckspYBqLtKGjFxcaqjjpO1I2W/jeNELVtSYuCOZICjdNGw2Hl9yH KRZiBkqc9u8lQcHDZKq4LIpVJj6ZQV/nxttDX90ax2No1nLLQXFbr5wb465LAPpU lXwunYDij7xJGye+VUASQh9datye6orZYuJvNo8Tr3mAQxxkfR46LzWgxFCPEAZJ 5P56Nc0IMHdJZj0Uc9+1jxERhOGppp5jlLgYGK7faGB/jTV6LaRQ4Ad+xiqokDWp mUOZsmA+bMbtPfYjDZBz5mlyHcIRKIFpE1l3Y8F7PhJuzzMUKkJi90CYakCV4x/a Zs4pzk5E96c2VQx01RIEJ7fzHF7lwFdtfTS4YsLtAbQFsKayqwkGcVv2B1AHeqdo TMX+cgDvjd1ZganGlWA8Sv9RkNSMchn1hMuTwERTyFTr2dKPnQdA1F480+jUap41 ClXgn227WkCIMrNhQGNyJsnwyzi5wS8rBVRQ3BOTMyvGM07j3axUOYaejEpg7wKi wTPZGLGH1sz5GljD/916v5+v2xLbOo5606j9dWf5/tAhbPuqrQgWv41wuKDi+dDD EKkODF7DHes8No+QcHTDyETMn1RYm7t0RKR4zsFNBFp+A0oBEAC9ynZI9LU+uJkM eEJeJyQ/8VFkCJQPQZEsIGzOTlPnwvVna0AS86n2Z+rK7R/usYs5iJCZ55/JISWd 8xD57ue0eB47bcJvVqGlObI2DEG8TwaW0O0duRhDgzMEL4t1KdRAepIESBEA/iPp I4gfUbVEIEQuqdqQyO4GAe+MkD0Hy5JH/0qgFmbaSegNTdQg5iqYjRZ3ttiswalq l1/iSyv1WYeC1OAs+2BLOAT2NEggSiVOtxEfgewsQtCWi8H1SoirakIfo45Hz0tk /Ad9ZWh2PvOGt97Ka85o4TLJxgJJqGEnqcFUZnJJriwoaRIS8N2C8/nEM53jb1sH 0gYddMU3QxY7dYNLIUrRKQeNkF30dK7V6JRH7pleRlf+wQcNfRAIUrNlatj9Txwi vQrKnC9aIFFHEy/0mAgtrQShcMRmMgVlRoOA5B8RTulRLCmkafvwuhs6dCxN0GNA ORIVVFxjx9Vn7OqYPgwiofZ6SbEl0hgPyWBQvE85klFLZLoj7p+joDY1XNQztmfA rnJ9x+YV4igjWImINAZSlmEcYtd+xy3Li/8oeYDAqrsnrOjb+WvGhCykJk4urBog 2LNtcyCjkTs7F+WeXGUo0NDhbd3Z6AyFfqeF7uJ3D5hlpX2nI9no/ugPrrTVoVZA grrnNz0iZG2DVx46x913pVKHl5mlYQARAQABwsFfBBgBAgAJBQJafgNKAhsMAAoJ ELKItV//nCLBwNIP/AiIHE8boIqReFQyaMzxq6lE4YZCZNj65B/nkDOvodSiwfwj jVVE2V3iEzxMHbgyTCGA67+Bo/d5aQGjgn0TPtsGzelyQHipaUzEyrsceUGWYoKX YyVWKEfyh0cDfnd9diAm3VeNqchtcMpoehETH8frRHnJdBcjf112PzQSdKC6kqU0 Q196c4Vp5HDOQfNiDnTf7gZSj0BraHOByy9LEDCLhQiCmr+2E0rW4tBtDAn2HkT9 uf32ZGqJCn1O+2uVfFhGu6vPE5qkqrbSE8TG+03H8ecU2q50zgHWPdHMOBvy3Ehz fAh2VmOSTcRK+tSUe/u3wdLRDPwv/DTzGI36Kgky9MsDC5gpIwNbOJP2G/q1wT1o Gkw4IXfWv2ufWiXqJ+k7HEi2N1sree7Dy9KBCqb+ca1vFhYPDJfhP75I/VnzHVss Z/rYZ9+51yDoUABoNdJNSGUYl+Yh9Pw9pE3Kt4EFzUlFZWbE4xKL/NPno+z4J9aW emLLszcYz/u3XnbOvUSQHSrmfOzX3cV4yfmjM5lewgSstoxGyTx2M8enslgdXhPt hZlDnTnOT+C+OTsh8+m5tos8HQjaPM01MKBiAqdPgksm1wu2DrrwUi6ChRVTUBcj 6+/9IJ81H2P2gJk3Ls3AVIxIffLoY34E+MYSfkEjBz0E8CLOcAw7JIwAaeBTzsFN BGbyLVgBEACqClxh50hmBepTSVlan6EBq3OAoxhrAhWZYEwN78k+ENhK68KhqC5R IsHzlL7QHW1gmfVBQZ63GnWiraM6wOJqFTL4ZWvRslga9u28FJ5XyK860mZLgYhK 9BzoUk4s+dat9jVUbq6LpQ1Ot5I9vrdzo2p1jtQ8h9WCIiFxSYy8s8pZ3hHh5T64 GIj1m/kY7lG3VIdUgoNiREGf/iOMjUFjwwE9ZoJ26j9p7p1U+TkKeF6wgswEB1T3 J8KCAtvmRtqJDq558IU5jhg5fgN+xHB8cgvUWulgK9FIF9oFxcuxtaf/juhHWKMO RtL0bHfNdXoBdpUDZE+mLBUAxF6KSsRrvx6AQyJs7VjgXJDtQVWvH0PUmTrEswgb 49nNU+dLLZQAZagxqnZ9Dp5l6GqaGZCHERJcLmdY/EmMzSf5YazJ6c0vO8rdW27M kn73qcWAplQn5mOXaqbfzWkAUPyUXppuRHfrjxTDz3GyJJVOeMmMrTxH4uCaGpOX Z8tN6829J1roGw4oKDRUQsaBAeEDqizXMPRc+6U9vI5FXzbAsb+8lKW65G7JWHym YPOGUt2hK4DdTA1PmVo0DxH00eWWeKxqvmGyX+Dhcg+5e191rPsMRGsDlH6KihI6 +3JIuc0y6ngdjcp6aalbuvPIGFrCRx3tnRtNc7He6cBWQoH9RPwluwARAQABwsOs BBgBCgAgFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmbyLVgCGwICQAkQsoi1X/+c IsHBdCAEGQEKAB0WIQSilC2pUlbVp66j3+yzNoc6synyUwUCZvItWAAKCRCzNoc6 synyU85gD/0T1QDtPhovkGwoqv4jUbEMMvpeYQf+oWgm/TjWPeLwdjl7AtY0G9Ml ZoyGniYkoHi37Gnn/ShLT3B5vtyI58ap2+SSa8SnGftdAKRLiWFWCiAEklm9FRk8 N3hwxhmSFF1KR/AIDS4g+HIsZn7YEMubBSgLlZZ9zHl4O4vwuXlREBEW97iL/FSt VownU2V39t7PtFvGZNk+DJH7eLO3jmNRYB0PL4JOyyda3NH/J92iwrFmjFWWmmWb /Xz8l9DIs+Z59pRCVTTwbBEZhcUc7rVMCcIYL+q1WxBG2e6lMn15OQJ5WfiE6E0I sGirAEDnXWx92JNGx5l+mMpdpsWhBZ5iGTtttZesibNkQfd48/eCgFi4cxJUC4PT UQwfD9AMgzwSTGJrkI5XGy+XqxwOjL8UA0iIrtTpMh49zw46uV6kwFQCgkf32jZM OLwLTNSzclbnA7GRd8tKwezQ/XqeK3dal2n+cOr+o+Eka7yGmGWNUqFbIe8cjj9T JeF3mgOCmZOwMI+wIcQYRSf+e5VTMO6TNWH5BI3vqeHSt7HkYuPlHT0pGum88d4a pWqhulH4rUhEMtirX1hYx8Q4HlUOQqLtxzmwOYWkhl1C+yPObAvUDNiHCLf9w28n uihgEkzHt9J4VKYulyJM9fe3ENcyU6rpXD7iANQqcr87ogKXFxknZ97uEACvSucc RbnnAgRqZ7GDzgoBerJ2zrmhLkeREZ08iz1zze1JgyW3HEwdr2UbyAuqvSADCSUU GN0vtQHsPzWl8onRc7lOPqPDF8OO+UfN9NAfA4wl3QyChD1GXl9rwKQOkbvdlYFV UFx9u86LNi4ssTmU8p9NtHIGpz1SYMVYNoYy9NU7EVqypGMguDCL7gJt6GUmA0sw p+YCroXiwL2BJ7RwRqTpgQuFL1gShkA17D5jK4mDPEetq1d8kz9rQYvAR/sTKBsR ImC3xSfn8zpWoNTTB6lnwyP5Ng1bu6esS7+SpYprFTe7ZqGZF6xhvBPf1Ldi9UAm U2xPN1/eeWxEa2kusidmFKPmN8lcT4miiAvwGxEnY7Oww9CgZlUB+LP4dl5VPjEt sFeAhrgxLdpVTjPRRwTd9VQF3/XYl83j5wySIQKIPXgT3sG3ngAhDhC8I8GpM36r 8WJJ3x2yVzyJUbBPO0GBhWE2xPNIfhxVoU4cGGhpFqz7dPKSTRDGq++MrFgKKGpI ZwT3CPTSSKc7ySndEXWkOYArDIdtyxdE1p5/c3aoz4utzUU7NDHQ+vVIwlnZSMiZ jek2IJP3SZ+COOIHCVxpUaZ4lnzWT4eDqABhMLpIzw6NmGfg+kLBJhouqz81WITr EtJuZYM5blWncBOJCoWMnBEcTEo/viU3GgcVRw=3D=3D =3Dx94R -----END PGP PUBLIC KEY BLOCK----- --------------ou90efZ0d6uibjlV6L0662g5-- --------------JVkhrOmBS0CpSktGtXU3MfEG-- --------------4uYNTR7OnvFRq4my0Tjwh0YR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEopQtqVJW1aeuo9/sszaHOrMp8lMFAmkWXKIACgkQszaHOrMp 8lMQVRAAlUkTlpHcHeFiYSoIUrrPDsUatyqv4MV+PgipW+XXUfxPf8gDs/6d9KeR oE9+3ewzYfgPAm2f/6CSW+mhNv05TuAdgfw4LxlItO1dwSW1wWe6VtpqSG//SoH5 p9YLKAtyteE0hMws8ypCBpx4Vkhz3IN7W1mww8i1ssXpSC441WSSjBfJUn2Xtt1j izwQP6+8/qe1tzA88BfM7af7YamjrtCUh60VdzV6hk49lCgv62LL2G2WQ9pgt2jW WAv8OJtXg+gFgn95O+I5PAoeKVQ+IGvleE/NUfRwOtVyXpiBM4wf3XvvzEmLigpr 3wNc5mmuVpscZf6NdWnJ4AyOk3XPXQTVXg0TmaZipAWf6aNp6AgZr8xgG4s1at50 kvanW+WdzwMM7C5Xkysn7hpQoCAb9IH8MI/vF0N5IhSsdQyxa/QBJysHboMTKI2K iI0YmZyHGlilgsBD0QWaLfItel4Mp8qmwwhOdXSAliZoBkuJcfduSnfPl9Q3RDVl TCAYg7p5isszCgTItGAAt+PP2ML0CHlozicsZ2n/uDCF4tgjkySuWsyResMXVRDW 6F6caADk6QQJecP5yKL1qHujInor0b1nKMPiJNrpn1hRby16zRcdjWAsm5woFocI 9up7CGf/CdWCTvB6encB9xCmJ1VwfmQSQ64WEc2a3Kqe1OtWVIA= =5AgL -----END PGP SIGNATURE----- --------------4uYNTR7OnvFRq4my0Tjwh0YR--