From: sternenseemann <sternenseemann@systemli.org>
To: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs] spectrumPackages: update execline backtick uses
Date: Sun, 8 Aug 2021 19:49:20 +0200 [thread overview]
Message-ID: <d10c1ca7-4b86-c277-1bcb-14c4399894d4@systemli.org> (raw)
In-Reply-To: <20210808170439.1372425-1-hi@alyssa.is>
On 8/8/21 7:04 PM, Alyssa Ross wrote:
> execline 2.8.0.0 changed how backtick's options work:
>
> * -i (exit with the program's error code on failure) and -n (chomp off
> a trailing newline from the captured output) are now the defaults.
> * -E has been introduced, which does importas automatically.
>
> -E is fantastic, because we followed every single use of backtick with
> importas.
>
> Even we didn't have -n before, it's okay that chomping will now be
> enabled from the default, because in all those cases, there won't be a
> trailing newline anyway.
> ---
> .../linux/spectrum/testhost/default.nix | 14 ++++----------
> pkgs/os-specific/linux/spectrum/vm/app/default.nix | 3 +--
> pkgs/os-specific/linux/spectrum/vm/net/default.nix | 6 ++----
> 3 files changed, 7 insertions(+), 16 deletions(-)
>
> base-commit: d2e147bedf251976ed99b94b6c905d6761f7a892
> --
> 2.32.0
Looks good and quite straightforward. All substitutions seem correct.
Reviewed-by: sterni <sternenseemann@systemli.org>
next prev parent reply other threads:[~2021-08-08 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 17:04 [PATCH nixpkgs] spectrumPackages: update execline backtick uses Alyssa Ross
2021-08-08 17:49 ` sternenseemann [this message]
2021-08-12 9:23 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d10c1ca7-4b86-c277-1bcb-14c4399894d4@systemli.org \
--to=sternenseemann@systemli.org \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).