Re: [PATCH 3/4] scripts/run-qemu.sh: Preserve ,, in QEMU arguments

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1033 bytes --]

On 11/13/25 07:28, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> QEMU allows commas in option values to be escaped by doubling them.
>> Therefore, doubled commas should be preserved by scripts/run-qemu.sh.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>>  scripts/run-qemu.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This makes all the tests fail:
> 
> qemu-system-aarch64: -machine ,virtualization=on,accel=tcg: Invalid parameter ''
> 
>> diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh
>> index ab324d8fda0810516cb2180d1372bbeb546f52bc..14c58729dfceb3a0d2566fcfe076d6c10433419f 100755
>> --- a/scripts/run-qemu.sh
>> +++ b/scripts/run-qemu.sh
>> @@ -64,7 +64,7 @@ while [ "$i" -lt "$#" ]; do
>>  				;;
>>  			esac
>>  
>> -			arg="$arg${arg:+,}$opt"
>> +			arg="$arg,$opt"
>>  		done
>>  		unset IFS
>>  
>>
>> -- 
>> 2.51.2

This was just wrong.  I'll drop it.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]