From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: [PATCH 2/4] tools/mount-flatpak: Create utility function to open a subdirectory
Date: Mon, 22 Dec 2025 13:31:49 -0500 [thread overview]
Message-ID: <e900f7be-d4b8-4c8c-a7c7-b92218fe7c77@gmail.com> (raw)
In-Reply-To: <87ikdyegg2.fsf@alyssa.is>
[-- Attachment #1.1.1: Type: text/plain, Size: 576 bytes --]
On 12/22/25 09:31, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
>
>> This rejects non-directories where a directory is expected.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>> tools/mount-flatpak/src/main.rs | 22 +++++++++++-----------
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> Why do we care? It'll fail either way, right?
Better to fail sooner, especially in the case of a possible attack.
It might not help, but it can't hurt either.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-12-25 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 16:22 [PATCH 0/4] Improve mount-flatpak Demi Marie Obenour
2025-12-05 16:22 ` [PATCH 1/4] tools: Use with_resolver_flags instead of mutation Demi Marie Obenour
2026-01-07 13:07 ` Alyssa Ross
2025-12-05 16:22 ` [PATCH 2/4] tools/mount-flatpak: Create utility function to open a subdirectory Demi Marie Obenour
2025-12-22 14:31 ` Alyssa Ross
2025-12-22 18:31 ` Demi Marie Obenour [this message]
2025-12-05 16:22 ` [PATCH 3/4] tools/mount-flatpak: Move more code to mount_commit() Demi Marie Obenour
2025-12-05 16:22 ` [PATCH 4/4] tools/mount-flatpak: Reasonableness checks on application IDs and paths Demi Marie Obenour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e900f7be-d4b8-4c8c-a7c7-b92218fe7c77@gmail.com \
--to=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).