From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BC9449B78; Sat, 23 May 2026 12:52:59 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 769569C69; Sat, 23 May 2026 12:52:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,FROM_SUSPICIOUS_NTLD,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,T_PDS_OTHER_BAD_TLD autolearn=no autolearn_force=no version=4.0.1 Received: from mail-108-mta166.mxroute.com (mail-108-mta166.mxroute.com [136.175.108.166]) by atuin.qyliss.net (Postfix) with ESMTPS id 3BF029B71 for ; Sat, 23 May 2026 12:52:55 +0000 (UTC) Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta166.mxroute.com (ZoneMTA) with ESMTPSA id 19e54e53fa200067f7.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 23 May 2026 12:52:50 +0000 X-Zone-Loop: 4e4d6eaa689f1e45de21f4482d94935ca34d6fe0851a X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gagarin.work; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j7weUVpOxTXzMUk026tEbD9dS7WsMJE89N5wwVy9EsA=; b=bv/GsuQESDLOA3z+XM3ugP3zOq A4o+IXYi6aBEboz058O20v4DJOwN+6CVXOZ5Xq5tGgMlCoaZ4CB1ibOrLrraMY4wzKgDFrs9/8Ksb rHn+CsYr2hYMWIa7vDrDcS5rXGdTKz9ibx4nKni0aqCxMsgvZ2SDFgdUuv+ESRI7GCKIuu7mWM7lv xVjWiMvwQgfFcJRbjc6ykWPyejoaH+PzLC+4c5EZIQUaO7PkLjWRLst2ShuxhsIjL4fvBnCDt9J3l XCPM/qWgNpylJ134eGQwEHpRCZBANOLRl3M2UU+iy5bhRMQJCa2usH0wbJ9iYu/LA9n64MO3lZatK 1FIGysWg==; Message-ID: Date: Sat, 23 May 2026 14:52:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] release/checks/whitespace: skip binary files To: Alyssa Ross References: <20260520222237.257773-1-valentin@gagarin.work> <878q9ar0ky.fsf@alyssa.is> Content-Language: en-US From: Valentin Gagarin In-Reply-To: <878q9ar0ky.fsf@alyssa.is> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Id: valentin@gagarin.work Message-ID-Hash: BEDTQZVHVSZ452THPIPIBFTWSZ2XQPBX X-Message-ID-Hash: BEDTQZVHVSZ452THPIPIBFTWSZ2XQPBX X-MailFrom: valentin@gagarin.work X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The reasons I wrote it out is that it's more obvious what it does without looking up the documentation. As a project grows larger and so does the number of tools or options in use, the amount of rare things one needs to "just know" tends to become unmanageable, and the time to decompress a highly compressed representation goes up. This is, what I consider to be by now classic, advice, which I have assumed to be tacit knowledge: https://changelog.com/posts/use-long-flags-when-scripting Discussion: - https://news.ycombinator.com/item?id=5164354 (2013) - https://news.ycombinator.com/item?id=24518682 (2020) In this particular case, nothing would tell me off the cuff what `-I` is supposed to mean for `grep`. It seems reasonable to be explicit here and avoid the extra round of distraction for readers. This has even more impact on people with less experience (overall or just with the particular tools). No action required now, the change is merged and does its thing. But I suggest considering whether a note on the issue should be added to a document about coding conventions.