From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id D5E4F4F09A; Wed, 25 May 2022 08:08:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 794EA4F08C; Wed, 25 May 2022 08:08:15 +0000 (UTC) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by atuin.qyliss.net (Postfix) with ESMTPS id 7A9634F107 for ; Wed, 25 May 2022 08:08:11 +0000 (UTC) Received: by mail-ej1-x642.google.com with SMTP id i27so40042208ejd.9 for ; Wed, 25 May 2022 01:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4NHzUsMP5veES2m90RPFM+bR7xxhOfEuSM+T/VMjt/k=; b=Q3+DRLrL0Mx6qobx/LQgsRZP0uYAamZtySQUHFw3WTPN5Q7+cesaIxsW29f/Kpothi T/3ozMPz8Vd8vT5Yxqf5V9k9JIiQR/3Sh3gne79uVWtw+nFWOx6Vt1KNXPy/VzF+ZB4N 3RLOOBJof792gXU9OtPH5OQ6U1HvbW+T7Z47pzySMhs71z/iMAemz0Y1v+SXLKJjn/SM Y1EXctN8w2s/ZTOWg8SsFtenLftQgnnRXckim5V3BofPR1ySGrDX/SqcvPmgF0GP3hDa 9GwNBT0Elxze0bUjJwccVu22VUPTW1FWt3L4TdgBsVAgAuwxts8qBuL1zrDvxDqzvNWE 9UVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4NHzUsMP5veES2m90RPFM+bR7xxhOfEuSM+T/VMjt/k=; b=UTMiwx/n0K+DfLyX0rtKZMP8SWtntvf5wDdC+Al2DdGKB6vn2/9IGnEz7DgpBoBuao WvMliiE7oAxzD21F4om0iOz6iorK//TXhxjOkHWtQ/eOu8a21Ql+g4MDxjLvfxMiSIhB qp/QUjn8qo0asq7+58hdwteIuEXtxS8P5JHNyDPjOLR4128mPOwV3ktLqIg5oWu9Iygp IIolcQqCB4ElpoYen0t7HU7cY01/bCHZz20t1YGfOdkwcI2Ofwc9uBmrcG0BcLYRqzcr qSBkDPddbOaMxY/P+EXAHkPABJIA3zOZuY7zo0MJ1vuSfKElYlrZadZqWfoSQZMp55/O xGNg== X-Gm-Message-State: AOAM533Wr8mMrmzGcMyKNB0i4KIgaEAWOX3zjY7ViyI+ok607TiFOeob /4tNVylFbV7tWzpKPpuG4pXmj/WBSpzoX2W40pY= X-Google-Smtp-Source: ABdhPJzbhoyNYNwO1K8uP7TqaR3nM8upaJCxn4qRjZrW83Dey2PCv6xqFPvCqFN/ukp2TMrD6aB3qg== X-Received: by 2002:a17:906:58c5:b0:6fe:fa12:1da9 with SMTP id e5-20020a17090658c500b006fefa121da9mr9604742ejs.148.1653466089998; Wed, 25 May 2022 01:08:09 -0700 (PDT) Received: from [172.18.0.173] ([109.204.204.138]) by smtp.gmail.com with ESMTPSA id z16-20020a50e690000000b0042bc7635534sm532230edm.62.2022.05.25.01.08.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 01:08:08 -0700 (PDT) Message-ID: Date: Wed, 25 May 2022 11:08:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] Allow static building of dtc Content-Language: en-US To: Alyssa Ross References: <20220520095257.23038-1-tero.tervala@unikie.com> <20220520125611.2b6tak7dgtssx2lb@eve> From: Tero Tervala In-Reply-To: <20220520125611.2b6tak7dgtssx2lb@eve> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: URK42G4T7UKUY4N7AHOX3PNX47WMV2E5 X-Message-ID-Hash: URK42G4T7UKUY4N7AHOX3PNX47WMV2E5 X-MailFrom: tero.tervala@unikie.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, there is now PR on the nixpkgs side for this fix. On 20.5.2022 15.56, Alyssa Ross wrote: > On Fri, May 20, 2022 at 12:52:57PM +0300, Tero Tervala wrote: >> Signed-off-by: Tero Tervala >> --- >> ...01-Use-libfdt.a-if-building-staticly.patch | 54 +++++++++++++++++++ >> pkgs/development/compilers/dtc/default.nix | 4 ++ >> 2 files changed, 58 insertions(+) >> create mode 100644 pkgs/development/compilers/dtc/0001-Use-libfdt.a-if-building-staticly.patch > Thanks for the patch! Since pkgsStatic.dtc is broken in upstream > Nixpkgs, would you mind submitting it there? [1] It will get us wider > review than on the Spectrum list, and if it's accepted upstream (I > imagine this or a similar fix will be) it'll minimize how much Spectrum > Nixpkgs diverges, which is important for maintainability. Once it's > accepted upstream (or if it ends up being difficult to upstream), we can > cherry-pick it into Spectrum's nixpkgs, or update Spectrum's nixpkgs to > a version that includes the fix. > > When you open the Nixpkgs PR, please CC me. My GitHub username is > @alyssais. Nixpkgs is quite picky about commit message format, so make > sure to look at the examples in the documentation linked below. > > When I get a chance, I'll update the documentation to recommend > submitting fixes to upstream Nixpkgs first if applicable. > > [1]: https://nixos.org/manual/nixpkgs/unstable/#chap-submitting-changes