patches and low-level development discussion
 help / color / mirror / code / Atom feed
* Building image fails on btrfs due to mkfs.erofs xattr limitation
@ 2025-07-04  2:02 Demi Marie Obenour
  2025-07-05  8:52 ` Alyssa Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Demi Marie Obenour @ 2025-07-04  2:02 UTC (permalink / raw)
  To: Spectrum OS Development


[-- Attachment #1.1.1: Type: text/plain, Size: 327 bytes --]

Unless extended attributes are disabled (with -x-1), mkfs.erofs
fails when the source is a BTRFS filesystem.  This prevents the
Spectrum image from being built.  Using -x-1 seems to produce a
working installer, though I only smoke tested it (by trying the
example VMs).
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Building image fails on btrfs due to mkfs.erofs xattr limitation
  2025-07-04  2:02 Building image fails on btrfs due to mkfs.erofs xattr limitation Demi Marie Obenour
@ 2025-07-05  8:52 ` Alyssa Ross
  2025-07-05 15:11   ` Demi Marie Obenour
  0 siblings, 1 reply; 4+ messages in thread
From: Alyssa Ross @ 2025-07-05  8:52 UTC (permalink / raw)
  To: Demi Marie Obenour, Spectrum OS Development

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> Unless extended attributes are disabled (with -x-1), mkfs.erofs
> fails when the source is a BTRFS filesystem.  This prevents the
> Spectrum image from being built.  Using -x-1 seems to produce a
> working installer, though I only smoke tested it (by trying the
> example VMs).

That's odd — I frequently run mkfs.erofs on btrfs.  Could it be some
difference in our filesystem/mount options?  Could it just be that my
files don't have extended attributes and yours do (SELinux)?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Building image fails on btrfs due to mkfs.erofs xattr limitation
  2025-07-05  8:52 ` Alyssa Ross
@ 2025-07-05 15:11   ` Demi Marie Obenour
  2025-07-05 19:55     ` Alyssa Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Demi Marie Obenour @ 2025-07-05 15:11 UTC (permalink / raw)
  To: Alyssa Ross, Spectrum OS Development


[-- Attachment #1.1.1: Type: text/plain, Size: 964 bytes --]

On 7/5/25 04:52, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> Unless extended attributes are disabled (with -x-1), mkfs.erofs
>> fails when the source is a BTRFS filesystem.  This prevents the
>> Spectrum image from being built.  Using -x-1 seems to produce a
>> working installer, though I only smoke tested it (by trying the
>> example VMs).
> 
> That's odd — I frequently run mkfs.erofs on btrfs.  Could it be some
> difference in our filesystem/mount options?  Could it just be that my
> files don't have extended attributes and yours do (SELinux)?

Yeah, it might well be SELinux.  Spectrum should still build on
systems with SELinux enabled, though.  Does Spectrum use extended
attributes?  If not, would it make sense to disable them with -x-1?
In the future, SELinux on the host will require fixing this, but
for now it's better to fix the build error.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Building image fails on btrfs due to mkfs.erofs xattr limitation
  2025-07-05 15:11   ` Demi Marie Obenour
@ 2025-07-05 19:55     ` Alyssa Ross
  0 siblings, 0 replies; 4+ messages in thread
From: Alyssa Ross @ 2025-07-05 19:55 UTC (permalink / raw)
  To: Demi Marie Obenour, Spectrum OS Development

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 7/5/25 04:52, Alyssa Ross wrote:
>> Demi Marie Obenour <demiobenour@gmail.com> writes:
>> 
>>> Unless extended attributes are disabled (with -x-1), mkfs.erofs
>>> fails when the source is a BTRFS filesystem.  This prevents the
>>> Spectrum image from being built.  Using -x-1 seems to produce a
>>> working installer, though I only smoke tested it (by trying the
>>> example VMs).
>> 
>> That's odd — I frequently run mkfs.erofs on btrfs.  Could it be some
>> difference in our filesystem/mount options?  Could it just be that my
>> files don't have extended attributes and yours do (SELinux)?
>
> Yeah, it might well be SELinux.  Spectrum should still build on
> systems with SELinux enabled, though.  Does Spectrum use extended
> attributes?  If not, would it make sense to disable them with -x-1?
> In the future, SELinux on the host will require fixing this, but
> for now it's better to fix the build error.

Yes, of course.  I just wanted to understand why it might be happening
for you and not to me.  Disabling extended attributes in mkfs.erofs
sounds like the right thing to do.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-05 19:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04  2:02 Building image fails on btrfs due to mkfs.erofs xattr limitation Demi Marie Obenour
2025-07-05  8:52 ` Alyssa Ross
2025-07-05 15:11   ` Demi Marie Obenour
2025-07-05 19:55     ` Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).