From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E8DF7104DF; Sun, 22 Sep 2024 15:34:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 0AFAF104C8; Sun, 22 Sep 2024 15:34:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: *** X-Spam-Status: No, score=3.1 required=5.0 tests=DATE_IN_PAST_12_24,DMARC_NONE, FORGED_SPF_HELO,KHOP_HELO_FCRDNS,SPF_HELO_PASS,WEIRD_PORT autolearn=no autolearn_force=no version=4.0.1 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::1]) by atuin.qyliss.net (Postfix) with ESMTPS id B8940104C7 for ; Sun, 22 Sep 2024 15:34:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HKHCIaoeQiMnT7aMfHf/UtMehgaNKHPyxjXD8Q1NZNI/aGpSovqYIzBN5simsECfHvdD7NihcdS83KhmAyWyINwVp+3IN0QfOjV6fE5C5Cff/3/OnCfKx9ss0tN8H7TYBR1lluEx63stVIsqr1piNZLE7UcsBWMhzBDTUhMccTL8aLbQXCWH0xux0w5OCDwV1+bFFWrk+l6QtGLRYaU+4AbfKgU3laN20olI3WMvLUoiufqvruBdBA4v0MKjsQ3t1z/bZoB8yNnBqxef/Aptoe0/9AhaR4WhGUtzXZwEHN5k7B8M8gbcpbNxkbNozOezJ+kgi7dBF+79rRpXJC5TSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iuD7X2j+g/BnZZtXlULZWW/U3D+0b0MkmiFec7fgnVo=; b=JO8815b3sjlkrebX6nDU5AdcX5EPhmbXBFPnwKdQRCLp+lwUmK3aQIxm3C5UtHtAAR8SWNwM5vrKIf8EioweAIVZMizA284C1we8tbhh8MJYMtIMK5hFaubBdxYAq4ysAXVU9z0uW4IBIdx+0YbvfH1xRjEHIiahYUv4WEP7tdyxSuzEiK/FO+XgX8N7YtwDzhmwiKGPZpTlXve44q4X+IIju/OFLOY0RSxQte21uu96YBtTE56PDwfrSlwSGA7zk7j5XTrHC737RDp4zCNDww77VhSnSGCC7A9xDUjPZI9iT6dFy+oGhPypk//yflVs0fD7yrYHfXdb2MnT3iizWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iuD7X2j+g/BnZZtXlULZWW/U3D+0b0MkmiFec7fgnVo=; b=Dgz8r48mnuPAmZf9deqsbDPAJxqdytvphQAVKuaGYSZtIAmRcdf3/J/ZLXT67vyMDM8FB8d2/H3zSg6vF9rVfRZBYuog6U/SBGPCrY8u34pYXZFF7YnsVqCDb2zB24B8iRupgbanvVO/tJZHjN/y/GgsYl+qKHLqGabkpBWbnJy0Imw0y1OGkaVIQ/m+YgCOZWliny8yzf/6PLJitmV5hFW6czxJs/YX4sGW98Mb218ur9lWNjMOmsAT1t2J/2cxnUJK2PEVTQzl9ZPbeBfuNbtARTAZ1vKWTUN75inEOcMtqfeWRHRjRvLf/a2Fs/Yr34BK/VlhDnNR6v56yKmjlg== Received: from LO2P265CA0357.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::33) by CWLP265MB6420.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1e0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Sun, 22 Sep 2024 15:34:05 +0000 Received: from LO1PEPF000022FE.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d:cafe::13) by LO2P265CA0357.outlook.office365.com (2603:10a6:600:d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.30 via Frontend Transport; Sun, 22 Sep 2024 15:34:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LO1PEPF000022FE.mail.protection.outlook.com (10.167.240.22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Sun, 22 Sep 2024 15:34:04 +0000 Received: from MORPHEUS-LINUX.localdomain (lfbn-ann-1-100-60.w86-220.abo.wanadoo.fr [86.220.73.60]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 989F5ACA0048; Sun, 22 Sep 2024 15:34:03 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 37A521A5928; Sun, 22 Sep 2024 00:51:42 +0200 (CEST) Date: Sun, 22 Sep 2024 00:51:42 +0200 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: References: <20240906093430.1168464-1-shymega@shymega.org.uk> <87msklgh71.fsf@alyssa.is> <87v7z6ziyr.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ugwhm5tx5yqwookn" Content-Disposition: inline In-Reply-To: <87v7z6ziyr.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO1PEPF000022FE:EE_|CWLP265MB6420:EE_ X-MS-Office365-Filtering-Correlation-Id: b0df7045-88a8-45fe-9798-08dcdb1bfd70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aWZxYUJiWVh2WndHUGNUNWxNMUU2ZlZuOHBZSENUTXZGcFJQUVNidnc0aHRz?= =?utf-8?B?WXpxMmkzQkhtdG9oeTRZbUtnaFZpZkJCUnRHZFl4dElDUXlGZStPSW9Rb3pq?= =?utf-8?B?ZW50Q1AyRE5pZ2ZYak9NL2NER20vVHdCUEhEa21leGxrM0NWeFdYZ1Z5MWRR?= =?utf-8?B?WFlybXhHR2psOFEwdWZodm9tSGptenNqdjIrbldhbVVPZklsbldEUlRKajVP?= =?utf-8?B?VkFvbk8yQXN0UjJWUFZEdFNJOFkwYkxXTk5pZElEaDNhTzJseWNxSWZSSDBX?= =?utf-8?B?V1IvN1ZxNXVISEVmRTNScFNXeWVWcGhZMEhvZE8wTlQvZFNDd2MvejVvS1Js?= =?utf-8?B?dVJSVFZQWWRlVTh5a2crNjJUZ2JaSThBUHNvdnJ5VTVCWmVJUnlEUzl5dU5D?= =?utf-8?B?d0JqS0VMckxXZ3c5WjVnNGUrUjVnZEhaVmJ2Tnc2QmQvWU1aL0Rlb3RESzFy?= =?utf-8?B?VThINlEzMHZEb3Q3TnVKdEc4M0Nmaks3WXZMQTUzVUp4TEdvUlZYY2JtdWQw?= =?utf-8?B?L0F1c0VxUEFydU45VG02bjhYS1ZkV2JRczN6Q3N3RVV1ZmxwL0pFbFRpTGpj?= =?utf-8?B?c2NKWmQ3amdWTzNTcjgyQlJtMG9PbmRKWkE0ZGN1UzY0Mk44eFlWOHQ4UWJI?= =?utf-8?B?YTRTUmptbTB4d0E0czFDQU1IMTUvUGxvRXFrR1BhS3pDTG9XL04xZy81c002?= =?utf-8?B?TTdObXk1RFlxNGQwMlNzSXFiUjR5ODRLVEJUOTQxbXZwR2JuZXpPT3ZQNCsr?= =?utf-8?B?Y0YvQ1djUlZpMmJ6cGFqQ3M4TDNET0dhOVMxYjRKKzM3bDFsbndGLzVMeng1?= =?utf-8?B?NzhiQlVWelc3aXdzaHZqcE9PWERQb3JiOWFkMEZEWGxieHBVMFdzbWhFTGN4?= =?utf-8?B?S3pySlRoSlhySldheVkrc1FudzdqZUJjK1VyZjFmYXYxVVlIbnlFSGV1U09C?= =?utf-8?B?bWZFQUZRT1I5TzdZbU5KeDJuV3ZKZnd5TG96ZDNCKzBrdHlaV2FjS1NIR3Jp?= =?utf-8?B?YUV1V1JQMkVVUHdFbE1GTTJpSW15dmVHY1hNSW14Zy9oNGtTTS9UQkRQMWlR?= =?utf-8?B?dHpVVk5UU3VYdFFxcERlQmpZejIzZ1lKbnhDWVByYWdhTDdGNnZsak5sZ05h?= =?utf-8?B?aUJrdGhEMVkxVHJ0Qm5vMm4wNUd1TXE5MW01M2IwRE9CTDBxZGJhdU03c2ZK?= =?utf-8?B?cXpqVTgwdjg1UUZmTlVjZUExckJpcGVDK0tCTGltWUFlTENRVTlNQ2Ird1Jr?= =?utf-8?B?WVVwQ0hWYU00d1A5SGFHd2VTaFpEQjVhMVBGcHFZVUF6UW1MekhQQWVJU2RR?= =?utf-8?B?Nm9scmFrdXQ0SmxPcXBhYzF5TzhtemNHMDZaYkxxUlZmVDdMSFA5UHhHRWJh?= =?utf-8?B?bDk0d2R6L3dMTkJUUUUrR21hbk16OUFBQlJTQnNhQk5wazE2Ly9KRWVkM3RZ?= =?utf-8?B?TUhRT0E5ekgvdUpGbXIrRm9TTkpEYVFvbFhuNVl1WnNTdldsWWFjMmVUd0FY?= =?utf-8?B?Q2ZqOGtzL0ZWMndCWDYyZVdwSE5maVpqbmZwSm1MdGRndjhJK05yNDQ0MjBw?= =?utf-8?B?aFgrK0xXSCtrK0tNVVZtZC9HcEhVVmN5QWZJYmt0Wm9DbjlHbUdXKytBNStB?= =?utf-8?B?WFBPcVVhVGk0dGNEMjk3Q3ljSk9kZXRabFRXR3ZzTE4rMExQeFl5eUhFdUtK?= =?utf-8?B?ZkdyRUZJdHhXYmtYV0ZnRWp6aTlaY0UrSUpYQ0NxbFljTEU5T0lzcHVHbll6?= =?utf-8?B?eEExeC9oMXQ4SVQrOXpuY1BzVDNnWUpNNTRoQjdLVEN3Ukd2QWlWK0I4NHVE?= =?utf-8?B?WTVRQTNaN2lrZWE5a1NPN0g3Y21FQjRvOUlZbFlKMG1wbDRnSGhmcnRjZTg2?= =?utf-8?B?MzRoZU9mTWJ5SUZ0cXZSd0lZV1FVbzkwQStLVGcvSU5pSkdOOThDaHRhWGFi?= =?utf-8?Q?2NqOMZHDBZnbjGCDrHYJSvSK9BaAwwJO?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 15:34:04.1757 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0df7045-88a8-45fe-9798-08dcdb1bfd70 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LO1PEPF000022FE.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB6420 Message-ID-Hash: FC7TEVIR37FDNVHHMJ5VAVTOFVQNQBPS X-Message-ID-Hash: FC7TEVIR37FDNVHHMJ5VAVTOFVQNQBPS X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ugwhm5tx5yqwookn Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08.09.2024 09:46, Alyssa Ross wrote: >Dom Rodriguez writes: > >> On 06.09.2024 13:22, Alyssa Ross wrote: >>>Dom Rodriguez writes: >>> >>>> crosvm was producing warnings when using `--vhost-user-gpu` and >>>> `--vhost-user-fs`. >>>> >>>> In this commit, I have adjusted the `crosvm` invocations to look >>>> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this cas= e, >>>> `gpu` or `fs`. >>>> >>>> I have run unit tests, but would appreciate testing. >>> >>>How did you run them? release/checks/wayland is failing: >>> >>>vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [202= 4-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error pa= rsing option '--vhost-user' with value 'gpu': missing field `socket` >>>vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [sr= c/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with= value 'gpu': missing field `socket` >>> >>>Does it need to be (from memory) --vhost-user gpu,socket=3Dpath or somet= hing? >> >> I thought I had tested them, but as it turned out, the command I used >> was only for shellcheck. I've run unit tests again, and all seems to >> pass. I've queued up the v2 patch for review. > >Do you think we could change anything about the documentation to avoid >people making that mistake in future? It's hard to anticipate what will >confuse people in advance. From my newcomer pespective, I assumed the command on the documentation for testing ran all checks. I just blindly copied and pasted it. That was an error on my part, and I should have known better. I think this is more of a PEBKAC problem with me, rather than the documentation. >> Just a side note from my article about Flakes - we could use the >> `checks` output to run on the `pre-commit` Git hook. This could then >> check the commit message, run tests, etc. > >We could do that already, right? There's already a command you can run >to run all the checks. My concern would be that some of the checks are >slow (the ones that involve building images), so I think we might want a >release/checks/fast.nix or something so it's not too annoying =E2=80=94 I = find >slow pre-commit hooks to be a real drag if I want to keep rewording or >slightly modifying a commit. The flake eval cache would certainly help >with the other slow bit (Nix eval), though. I agree that the checks as a pre-commit hook would be slow. I would like to integrate a CI environment on the list for each patch. Perhaps we could use your suggestion of 'fast checks', and the CI could run all of the checks upon receiving a patch? I should have discussed this in the Flakes thread, so my suggestion is that we continue discussion there, and in Matrix/IRC if the need arises. Best wishes, -- Dom Rodriguez GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43 --ugwhm5tx5yqwookn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6w1F5tDcG6GitfwkctzxIx5UvUMFAmbvTf4ACgkQctzxIx5U vUOswxAAq0b4Wa5dqcEM9gS5b6tUn9D1WTIAr+ulPzi3PwYQ7NKO6RYcNkgA/wId Fom859LtFhL8vaWgiA/KLNo8JfJuUI1Ug+LQIUc4X01wJw3392Wd3i8e9ajs6+Hv MAc5MVwsXTSISvQ2D4jTJT9iUXtFFpCob3TPSMQ1MhDovaTlgLlxOMgdk4J6It4x FFmul9BLMlmPUiciUkld8I07Uk3FqbQe92geH+Viix+RqYar9454L7WWzqOJGcKD DWv4buC87YZ0Lir0Q4WWB1cGgetDDpStqqDmidu9GNkZz+UOhV0SKnryOrOh04+e xu0i8RafYDNJ52MSsA4DJB1SDrVjbW5su/LT2Os9Aw7yFh2++Zuu/b8vAOuZdtzH LGgZWKiNFG8J0bQWbN3xIaBY3Dj2E/mz+eL41pKQ8CPX6i6Shp9rULEk9nh72RD0 3uk5NTKKcg6rEHyYLSv31bUfJmD3f9qYZBbgxqk1uDnQsGK3l3ALju0hq7jmb0gY dzupzqwn4KJyczDdYiyPIoD0J+BOh6ApnercTWmAX5HkCdFdw4MmtEIGEXj3aWJH x6txcOYPO7VvuMmUabZCRVCE5RFYSBzQSvfkr9U7/BlxCo7GBGUx8CdaWNmxyd7H T2CCc3AHVJyIX00CgBktcSm+gadgAeTEtiqAmxVm+Ki11ZvKaN4= =uHP3 -----END PGP SIGNATURE----- --ugwhm5tx5yqwookn--