Re: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag

[Dom Rodriguez <shymega@shymega.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On 10.11.2024 20:55, Alyssa Ross wrote:
>Dom Rodriguez <shymega@shymega.org.uk> writes:
>
>> crosvm was producing warnings when using `--vhost-user-gpu` and
>> `--vhost-user-fs`, of which the former is fixable, but the latter
>> requires some more work. The latter will be patched later on.
>>
>> To mitigate the former, I have adjusted the `crosvm` invocations to look
>> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
>> in this case, `gpu`, and `$PATH` is the path to the Unix socket.
>>
>> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
>> ---
>>
>> The typo gremlins snuck into that last v3 patch, but hopefully v4 will
>> fix it.
>>
>>  img/app/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>Thanks!
>
>There's also still the --vhost-user-gpu in
>release/checks/wayland/default.nix.

Sharp eyes, as always! Patch submitted.


Best wishes,
--
Dom Rodriguez

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]