From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5C5131C548; Mon, 11 Nov 2024 08:30:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 6FC7D1C507; Mon, 11 Nov 2024 08:30:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: **** X-Spam-Status: No, score=4.2 required=5.0 tests=DATE_IN_PAST_06_12,DMARC_NONE, FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::1]) by atuin.qyliss.net (Postfix) with ESMTPS id 92BEB1C503 for ; Mon, 11 Nov 2024 08:30:07 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zD/kdP+uKD0rt/H9eGH6VKGHywhSwuequfyRMu0yZLuXz4Wkqhi3wxG7exuEfmE6P9P2YSTSWhOtGnSWjXg2OJrTZOFfJW5s3e4lrlS1UnmzYITNQczQCAUvsLVAp5OjN6dLBOcZUpR+9yYzuT8E8gTP+WPwwxiMk4c9OP2lx1CAEzqJkF5VV3V5YKlvCyAswzsxrdkmrswGVOlKvmoxtgeR03tPWq47aUaoVX8Dz4IXj0Ut0VYLsmVHZPRti0X+AdebxtP19INs6YBKhc7Kzg7zXQfN8/Dp9vg9vGY3YbwpdZ/vcvacCVKDwuYppQDQpp40anu/Leoj0wK//vm7yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FsKq0y4XVr2xPlGq+/h7T4Uw3bAaFU8s94EDDhIJsMM=; b=Qm7F3pgT++Ao2dqEPO/nt7QYz+ypMTlwpY86aax31myDQJEtXgLJ8FUiWWsFAwGGfoe2G+5GR+uy0vIkIzq8eaIyAZhbWiAYntTVpJD/yIz2aMj/fKikS9oZ/fxJZJcOiUCnoBOZVAgbHyUyohttzFVbsyJcMKqMafa31orl6ajmYdabXCk35WattvrcDUYGZkzLD6OLRDg/pw6Z1+cGekwFiXBhQjZHpZKfvyWq+WWoeWxNI5ktqX1lOnm77oVdzVhj3VowiF+lf2f1vBww+ARKxaexJBN9CBvSg5DsdAdAnxbUhpwBg48J3uRC8UaNy/OlqWs2LoVlAmSIqcA0LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FsKq0y4XVr2xPlGq+/h7T4Uw3bAaFU8s94EDDhIJsMM=; b=OMqmofTll4MIB0snbH5WVkKewlyHsx3arH6DnfNIAmYx1+6NnK76KdhLoSFi4vj+fbt95CZyNPSEVq6bCUhHj3YeHRZguIeIqqXjTK0H4EVKhUGOvCPL012Dr2XXY+/PYM5EEhy+jcAOhDcTHA3ZWtiyIxcJPxI1S006kF+y5bEh2WKvL8yCTtxFjGb4HtdWERimNp1CcMEpZG/iAqVXaBRZdDq7tCNkjJP5g/JNxB2hPHdQ3bUfl3KLb84xKkG9zXeu8ClWBUwNpBuZM5pnPiLbjzGE2UFG+NxyIIxHuy0eC2Ms9DogAAzTa0jwT9UL3a8q2K16yX4USryEoDYB1g== Received: from LO6P123CA0027.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::19) by LO0P265MB3084.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:182::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 08:30:03 +0000 Received: from LO1PEPF000022FE.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:313:cafe::f) by LO6P123CA0027.outlook.office365.com (2603:10a6:600:313::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29 via Frontend Transport; Mon, 11 Nov 2024 08:30:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LO1PEPF000022FE.mail.protection.outlook.com (10.167.240.22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 08:30:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id B11B1ACA0056; Mon, 11 Nov 2024 08:30:01 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 2E72F108057; Mon, 11 Nov 2024 01:35:47 +0000 (GMT) Date: Mon, 11 Nov 2024 01:35:47 +0000 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag Message-ID: References: <20241108181450.1424488-1-shymega@shymega.org.uk> <87pln27tjv.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="med2s3bzbvj2awqn" Content-Disposition: inline In-Reply-To: <87pln27tjv.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO1PEPF000022FE:EE_|LO0P265MB3084:EE_ X-MS-Office365-Filtering-Correlation-Id: ee46a8b2-c970-4af8-a898-08dd022b0962 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cHV6b1BTY2kzQlFmQUVEak9YQTJrKytCR09OVTZnbDQrTnJKcjlPK0VBdWdz?= =?utf-8?B?ampuMCt1ZGNKYVRYanhaK2RHc0VMclY5ODJFWUpscURtL2xWWUNPQ0dzbjFH?= =?utf-8?B?eFlFbm9BNHFnZ2VwS28rT2pXdThwazVnOTB4Q2VPbHRWWDF6eWZ1ektOVFRx?= =?utf-8?B?ak8xenhHSFBSMnptYk5NRmhkZXFLRHl3NHlvaGNSeEdtekNSTm9TTjlPQnUy?= =?utf-8?B?WmtrMTY3SFdUdnVnMlhPUE1MWnpjaDFVTzIrbTEzbGs1aVpyd3o4QzhPUmor?= =?utf-8?B?RlZ1K1NCUEZybnJCc2RqU3dsUkZZamQvU3FkYW5jOUx1UkE5d3c2RDROTUZB?= =?utf-8?B?T0xvcmxWUGk1QjF3S3l6ZlAyanV1MnVlRStYSWFDV0pkZkJ2aDdpZkZjeStj?= =?utf-8?B?Wjd1dWxBMHFQaE1mSTJYUjdxS2RTRlIzM085UWd5WGxvcVpHSGhNdEhaZnl4?= =?utf-8?B?RVdseGNDOXZlRUdpQmlrOUdnUkhXWUlZSTY3MTdWR2pSTDBHeE03VmVVZzl6?= =?utf-8?B?eURlNFB5czF4TUcyQk5RUnVIeGtMVXcyeGpYV1lRUjlHbGV6MG02K0xkb2hI?= =?utf-8?B?OEgyZ21SYjEySWNMNHFFWUtjSENDbVpoTDBoNGlVbG03TXpqeVlVSlNpcGx6?= =?utf-8?B?bVBreURKaG9hS2VpbE9qQ3ZJRWxpZTVFb29PUDlRNndNZDJvbTlLd09LYlZF?= =?utf-8?B?SDRXWXVqWGExTkF1V0FJaWxvNFFPTWVKcVJ6SWx0d1cvV1pCdEJuUUdQTmho?= =?utf-8?B?QkxpL1RvR0thaHNXMklLa1V4TzFvZHcvcW9CY0dwSDhPOGU2endTVXdvcHAw?= =?utf-8?B?SnlSQlhxdzdNcVowRXo2MGZKR1hmQTY5RndTaWZmaTlJd0ZENGkvQVlEVmhh?= =?utf-8?B?QnRYbUp4N0RzRUxPai9aUHRNYkNhM1k1RXJvT1I2U1JWNHJKd3BRS29reFlB?= =?utf-8?B?VUdOSi9TWTdxM2FoWkxBZ0hyYlE2RnlxczcwbU1jcUhWSmgrOWVEbk9OWDVa?= =?utf-8?B?QlBXOU50alBUMDlCeUgrNmEwT1ZzQXljYXdPNEVhU21lVGZienRYcFVROWlx?= =?utf-8?B?WktNei9GVEZzSUF4TTRCS1RwdUJpTzJ4clZRdTg0bWVSZmYrV2trZnBKUy9s?= =?utf-8?B?SkhVS3I3a1FrZ0lGOW1LTlZuVE5WS0hEN054V3M5OGdTNUhwNWVyRlNTNWt2?= =?utf-8?B?dytoQkh2Z2lUWklDOWNVZFIrYi9uYm4zaTIwb2JsSy9odUhSdDlIMlY5dDNE?= =?utf-8?B?bk5rb1BUU0g4NVBCMVhQY3UrcXhoL3hxSXRneU9RQWRoaThCYlZqT3JYaFUy?= =?utf-8?B?SFluZy84ektMblRZeHhnb2tCUEtHWWIxenBxd3Z0VkZzNHdacW52YS9tQWQ4?= =?utf-8?B?SGNEQ0RrazVJWTVQWWF2WWhRUTkrcFFwcHIxVGs3bzJ4LzQvcTh4Q0lPWjZo?= =?utf-8?B?Rng3eHVZZDY1d1hFOEQ0bDhlWTBVN0s1WGs3NUE1cXpUVUdvZVFoVVpBMkNw?= =?utf-8?B?ZmxtVlh0NUl1SkdNTm5hL3VhUnJkUWZJdVVtTlhtTXEyMkhxNXpPR0x2ZlpC?= =?utf-8?B?VGRIZE9saGxzenNmcnQycUM1VXhYTHUxdENwMWM4V0JyQmQrZEdFOGcvWSty?= =?utf-8?B?L054a0pWV0kxUmhlTXFBaCswWFd3N3lINC9XTEZzVEI5dUovU0g3eE1EcVZG?= =?utf-8?B?YmNGOER5ZHNINTY0MGNqNUlhTTRMc0JXdWJBdXZJcGtxWmNxTmNmMEV3TEZ4?= =?utf-8?B?Ryt2R2k1WkwzRWthUUNjalBLUkZBeW5CUjlMc0ZZOHFCZGJPUFJsalM4QXgx?= =?utf-8?B?NkFhZWJSNFRJY3VYakMyR09sUEJVVERHaVpGUGJaMVkzL0pPcGszd2p2MFBT?= =?utf-8?B?Rm9PTm5TVTc4VEVBRGxFNW90UHNlb0JUNE9TVWNGWGNBYWc9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 08:30:02.0632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee46a8b2-c970-4af8-a898-08dd022b0962 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LO1PEPF000022FE.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB3084 Message-ID-Hash: Q6EUAL5ZDSJAZUJQTYOYDIF2GEC6KFHH X-Message-ID-Hash: Q6EUAL5ZDSJAZUJQTYOYDIF2GEC6KFHH X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --med2s3bzbvj2awqn Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 10.11.2024 20:55, Alyssa Ross wrote: >Dom Rodriguez writes: > >> crosvm was producing warnings when using `--vhost-user-gpu` and >> `--vhost-user-fs`, of which the former is fixable, but the latter >> requires some more work. The latter will be patched later on. >> >> To mitigate the former, I have adjusted the `crosvm` invocations to look >> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, >> in this case, `gpu`, and `$PATH` is the path to the Unix socket. >> >> Signed-off-by: Dom Rodriguez >> --- >> >> The typo gremlins snuck into that last v3 patch, but hopefully v4 will >> fix it. >> >> img/app/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Thanks! > >There's also still the --vhost-user-gpu in >release/checks/wayland/default.nix. Sharp eyes, as always! Patch submitted. Best wishes, -- Dom Rodriguez --med2s3bzbvj2awqn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQS8QbGzuJNwWBsvCoTK0brmh9AFqwUCZzFfcwAKCRDK0brmh9AF qzPKAP4isLsmLOmhNfBNS0xIifHvCQKV52dFRS97eS2sMAz2OQD9HFkRVzwuel2q oddwJRm61/b4Ahwn5g42GK4bDXJYuAc= =tkLX -----END PGP SIGNATURE----- --med2s3bzbvj2awqn--