From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BC60BE3E1; Sat, 07 Sep 2024 08:02:15 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 602F9E433; Sat, 07 Sep 2024 08:02:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=5.0 tests=DATE_IN_PAST_06_12,DMARC_NONE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,WEIRD_PORT autolearn=no autolearn_force=no version=4.0.1 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::5]) by atuin.qyliss.net (Postfix) with ESMTPS id 0ACEBE3CA for ; Sat, 07 Sep 2024 08:02:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i9Fv9ChqZDkG1PznvQm8AjHTuLNuVJBNO3+YTXY5XJx9I5iDI6fq2AEf9J31D/2YbbFm4/PcCv5unPje3bmcygmQXex6FucCnFfKt+/gbk5oDK/XmPCA/w+JhaDFhXL2jia/zHSf4nVWyHqoLk8CKPyagVech7xRSluj7CL9CxczAKq6eSX6uQmP3kUbwmjsswk8aqUdsKkqhtevM7fex2bo4cng3ialTRKq6cP/FFwTLC9oYr54SNNEGTaJMQWfXSZYupvRR15pS6EuHc4XWxB4a8lYkoTrElE+D72mjkHfHwjNNl69ATV3imoP0L5tHK/jFuAAXJLF6dmpDXIQkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sdFeYAGs3cxqlPQ1Jl52dzlV11naTvjjDMRcHh7mUJM=; b=GmFJt0GhoMkrJiE+eo+QnHuPfnbtTG5mtHxR38L66FYhmScKKy6wVCgK8rq6sviWUCuIBGVUVybZEufDXREICw8G9g6K9DkQoE9UdchGxoNpHDFUrTFOjsSSKGFuX/h/rHZgnD53nHjp3BbWHslTWyo/pksMBQaz0jdZI92jY49xQbCOkYSvnXBOUtNv5xs1LQdGfoA4KulrJgpW9GKv/RwVEZQdi2G1htJSlknwLPVfPbPPpjShHouwhZ7LUREIzgxMkhoq7n+YHgTftpXlwdvcBDBr1pg96YvYaZXlAqIdPB+rWr9YmjG2ftiB3chH0mGb3E+b3IfLzKTXUsj9+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdFeYAGs3cxqlPQ1Jl52dzlV11naTvjjDMRcHh7mUJM=; b=l278e1QR86ZiE0GQsuci3t5wYcvKbEDBjQXkQVV2RvIgFaFiQfMU8cmMsvl4Os2/dNNVQHldtjfg70ULGZqGlSYeEd+PX16xjD1UYdjcjU/nVBJHNFd9Ww1gNAcKYCOVk0xVaK04HPK7sQwAnTL7IRiIj7/irVEdntHXRRRSU9KXUF0utRfHg1TcPxtkmso5YJSC0adQaSdOxFUQLGtyH9KCcMlwcBIDGYXvrN2jr/vu6v7IosAWB/VDN0UqilZjztHs9vlWFTPY1tF4785dvFzjNxbBURH7gP7e4zpTKzN5g4m1qeGXNGF7JuPYQ7j6otzJdlvOU6yKiQu/sTQJPA== Received: from CWLP265CA0298.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5d::22) by CWLP265MB3124.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:8f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.21; Sat, 7 Sep 2024 08:02:05 +0000 Received: from CW2PEPF000056BF.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5d:cafe::4) by CWLP265CA0298.outlook.office365.com (2603:10a6:401:5d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.20 via Frontend Transport; Sat, 7 Sep 2024 08:02:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056BF.mail.protection.outlook.com (10.167.240.21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Sat, 7 Sep 2024 08:02:04 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 3AEDBACA0046; Sat, 7 Sep 2024 08:02:04 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id DFBE031E990; Fri, 06 Sep 2024 23:41:48 +0100 (BST) Date: Fri, 6 Sep 2024 23:41:48 +0100 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: References: <20240906093430.1168464-1-shymega@shymega.org.uk> <87msklgh71.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n6canei6or27altl" Content-Disposition: inline In-Reply-To: <87msklgh71.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056BF:EE_|CWLP265MB3124:EE_ X-MS-Office365-Filtering-Correlation-Id: fdcfd4df-3c72-4d91-fd8a-08dccf135cb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|34020700016|1800799024|82310400026|376014|36200700002; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MVczWWtmUmFPYlo0WVZoZ0trdXBJV0YvRFNqRWxRc3RFQUtPc2JlSHVkdGM4?= =?utf-8?B?bmcrbEt6b2tRSDYrUE5aZDlaOWpBN05PSVBGMjVjTVI5Rkw2VUFyV3dmMlV6?= =?utf-8?B?YlVLNFUxOFppTzVGSmZSVEN3djFuL3I3dlYxRUZqVld5eWk2WFFKZTNFcUR1?= =?utf-8?B?eXEwVlc4bE8wbHdqYisxN1FTc0QxWjAraXkvY0kvTHVoL1RSWTBlOVdVSkdO?= =?utf-8?B?djl2V2ZiSDVHaXo3RHZIcGV2TVBZUGthcU1lQW9YUTFhdUJWYUZQQUc3VW83?= =?utf-8?B?WnlkVGpQOVBycHB3YWpsYWdhQ0lacER5Rlc0WUUvR3g1RjFIdXhBcSswRnBm?= =?utf-8?B?VlFNa2tVYlNKb0x0d2Z5OW9qZkhtbGZERGdaaS83NGl1MHZKdW5YQ3VHaHZT?= =?utf-8?B?ZVRYZHk0WDhlaHJ6d3YyZEZ1eE91MDBTQm9naGdnTmFpWnFaR0E1M2JtZkNX?= =?utf-8?B?THcydDRFVk4wQlphNkFJSUM1MTBNaXYxcVh1MlpaSDVZNTFjellmZ1ZXTTJC?= =?utf-8?B?bGFBdy9NZFBTMG5FRkhUeTcvemFVZWp1YzNzbHdIK0NqcmpoN01HUlBVRnRq?= =?utf-8?B?S3czVWRENWZDNkcvalYwZG9MTDFSenZPdWFKdlRLOVh3QlJ4OXVNeWFEVU41?= =?utf-8?B?dWZKUGUzWnYyb0VSUFhxcG5CMmNiQXRWRW5UMnBIa0c2MjQycTNaY1kxL3pa?= =?utf-8?B?Sjl6K1JnM280Wi94NFlOb2htaDhSa1Z6RVZRZkhFdkJubnJhOHBGWFVTeDBC?= =?utf-8?B?Q1FTUTJKYWVQRzhXZmJXUklMT2MxRS8rYk9DY24wUWNGOUVZcGhlWWVzU1JC?= =?utf-8?B?QVNyZnZrbkkzNHJ2TG9CYy9kTXlsRlBxRzFydGUxNS9LeW9Ub012K3RyUmxO?= =?utf-8?B?REl2Y29ZMlVEZ1VRb2x6bmtZM1dpNmpONGlYL1hJNGpvRVRuNldpTHVtNFlr?= =?utf-8?B?ejZZVVpDd3dpK3N6eEw5SFBKSGFlRlcyUVpxQVR1d3dEejJCMzcyNlFVbEF2?= =?utf-8?B?cFZtOS9zQjVMbktWQk53YXJUZzNzZzdpU3dLR29iZklucEVGME9OWllvOWgr?= =?utf-8?B?d2lualIyaVNMSEdxWERrTnphN1d5djNQQUVpK2o2UTZHVW1vemdCakdwQk1a?= =?utf-8?B?ZnlDakg3VnM3bHhZTGlTLzVSQ0xXakRVNVltSk02S0VNMGRkcnhXL0pRcmph?= =?utf-8?B?aDZyOUdIZDhHMnorZXlKMDRpMTc4Sm95SXNvWmNQZ0EwdmZIbWNOZk4xcmFQ?= =?utf-8?B?amxIOXBQbnMxRDZTeTB4ZitGS2FUZEJMcWM4R0h4dGwrZG5SVTBxUGdnZkxn?= =?utf-8?B?YUk4aERSL1M3VndDRytPSmdEODRrUEY2a1hRaHRQR3h3TXFaWjJjUm5VZUV2?= =?utf-8?B?aTRYRFNWQ0JYSmV5RzZHYWRjZFFVZzNNbnA4cHhBYmlZREZId0wvdlBsMkpE?= =?utf-8?B?dm1MRlUyV3pIVUZnTUl4NVFxQ2t2NDZPaHFSU0FzZ1AvVnczRmNTZjM2WFpk?= =?utf-8?B?WjJHc0MxN0tFRWZRQ1dIN2VuOHhnc3RxTWd2Qm9nVEJLdjIvc0ZNUkRTU0JL?= =?utf-8?B?bldEa1orUG1EaXloOHlGQnVMWE9NOHg2aWxXeUptaER6elhPaTlIOGhjQTJu?= =?utf-8?B?UFh5cUNhdjNuL0dtTjRtSnpCZWRCUVUyRU51bTczK3EzUjl6bkN0anJtUTVl?= =?utf-8?B?MGxrRENLWUdBNjJrU2MvUGYvbk9VeGI3ekpBV3RoUUQvekR0QVF0MmxKVFl3?= =?utf-8?B?TUliSEQ4b01YUHFHV0Z6MG9WVURtT3RyUE1aclZuWENIOHNlNXV1L216K2gy?= =?utf-8?B?QVdrVXU2L041cHhSM2YxTUcxVk1OZUdrb014STNwazViMUZ3cjdNdGNXNHVJ?= =?utf-8?B?RlJXM0k4QzRBaVZIVUhJd05obHdzUjFVZGlBVHNkS2ozQ2ZmM3pvOFhiYXdQ?= =?utf-8?B?TFRNcVVlUEVMRSswNXBlNy9UbkxiT0ZoWjVkUzlIcmdTRkRJb2NnRWRNZGVW?= =?utf-8?B?Tm9hQWM1NTVRPT0=?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(34020700016)(1800799024)(82310400026)(376014)(36200700002);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2024 08:02:04.5901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdcfd4df-3c72-4d91-fd8a-08dccf135cb5 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056BF.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB3124 Message-ID-Hash: QLK2NVEYV67UZISEYLG2GNIPJGY5SEAJ X-Message-ID-Hash: QLK2NVEYV67UZISEYLG2GNIPJGY5SEAJ X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --n6canei6or27altl Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 06.09.2024 13:22, Alyssa Ross wrote: >Dom Rodriguez writes: > >> crosvm was producing warnings when using `--vhost-user-gpu` and >> `--vhost-user-fs`. >> >> In this commit, I have adjusted the `crosvm` invocations to look >> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case, >> `gpu` or `fs`. >> >> I have run unit tests, but would appreciate testing. > >How did you run them? release/checks/wayland is failing: > >vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket` >vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket` > >Does it need to be (from memory) --vhost-user gpu,socket=path or something? I thought I had tested them, but as it turned out, the command I used was only for shellcheck. I've run unit tests again, and all seems to pass. I've queued up the v2 patch for review. Just a side note from my article about Flakes - we could use the `checks` output to run on the `pre-commit` Git hook. This could then check the commit message, run tests, etc. That way we can catch these sort of mistakes before they even make it to the mailing list. But that's a digression - I think it'd be a good idea long-term though. Best wishes, -- Dom Rodriguez GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43 --n6canei6or27altl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6w1F5tDcG6GitfwkctzxIx5UvUMFAmbbhSwACgkQctzxIx5U vUNPIw//TfynGzz/PxdZYtfamE5/zMoUIH7XrnKjcR5B/t8cfb2wJ/baGAcW/LVD PXZLOaBMggupJvBkt/YeyRnCUczcURQVoebUD2Yb8pTwa26OSHHmDIt3uGbJXzkM 0uQqLjDQuaDKRw0SjIJ/Hs/fj2OT32BJR9T48A9TnSGgWi95RFkaUROE1NL1Si7f 8+XYI95hz4ImkhFV9oqdsiHiqjJvdn3Phk5MqjXxrPDS2l3W8JZGwaQ/luQOMIsx ysbl/tulfVYS/gZ/5/bcw0xS5Y+r4ybPNRL6eXZuakWBmsFRhzMOb6Jls9vtXrvJ 8lc1rfKsKbbKFzeITZxGV42lhZn+TgU4b7kgf7B/fFpcliTKmrHyUx6VCPO7JOq2 STn27LASO4TQNX5HgldLBx4keP2xi3f9KGUJBCz6YWLP5anaBGjX6U2CHQjp/JBC pmr/BxDHdunqZ7+MjTTQ/QECU4mnOsGoXlnwBOMY3PBGzKAo1/UG6P1DJR9ONbCE BHUP7UaXI/qBgLNmqZ0ChOLh1h6ZxaPXrN7ZkF6JxUkckifrf5oF0Qespe7vjUNG 2DNR7EXTAow2PASl3sXyfPJEvB21mjXY+KkzOaYWT9uDtAfmk7JViht0kSBvDudV TIOgFfb06SZC9qAQdEUrpczWT/139JymGZHYKGO9zOkv6Utu22E= =nMcF -----END PGP SIGNATURE----- --n6canei6or27altl--