From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 0D8FF1C55A; Mon, 11 Nov 2024 08:30:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 37FB21C50D; Mon, 11 Nov 2024 08:30:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=DATE_IN_PAST_06_12,DMARC_NONE, KHOP_HELO_FCRDNS,SPF_HELO_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from CWXP265CU009.outbound.protection.outlook.com (mail-ukwestazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c206::3]) by atuin.qyliss.net (Postfix) with ESMTPS id EB20D1C505 for ; Mon, 11 Nov 2024 08:30:09 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rkldP8EBQBG6rkDITrec2p2otpWurA+vSQLiEM/fqSs+AxWrALBbSRdG8kixbM7rV3jCuccw+1n3QeRweWBgDdx5a8/K3hr5x8Ytftq8VJJGYfqrTpXqorMpSRW+S41n10lUC7nC3CwL1lIDFwUPugDdk+W+Jh7nsYsnoK8KC7lNbmtiwYcG/MQdo1Q6gPMMHhzZLhYo9boLoCgl0qknJBdN8If1/BbLRdEp1WvaI6uNP6ryp56EIIlH9x4Ts7I7FgqMZ5PfoqPYc6e42LTXLo6tVsXl/yWvAUhvKE5lQP8eSPBchKVMN32CN1tAs3kDWzl2MDTcusVMa8XEk+wErA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ElQRpj/Pt2SxrSLX0rWzLw99YdnQGBoRrTMVP0Y+jjo=; b=osy3uekuPiRisgv9Zn1mHvnjctLyh1AM674kWPDFklzl7Zqkt4YwEqx6JI30Q3iCmENYKxnLJ6S9sgOHvT9t3xa7wcwujfDXTI0v77s5vu92kOcnNHzFXiywJMtv58yOBc9N9W7EJIod/5Yd7H1Yau39qi/ZgdF1CR8AnyfkEKnWr9vA5tAccBjr2lbXTNm9wfyjPqZqJd58JX/wSn8eCMEA0zOwGrFT1puQGYHLWQxrXepgddGkT/fS3CrVFKHr/ZMiKo1dzt7M99/6mKuHfI+Ufp55Vy/j2uvmHJRi+GnuaqO6s/mtqWTN97prtSKVr9b1OrOghACdk2wQ0x76Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElQRpj/Pt2SxrSLX0rWzLw99YdnQGBoRrTMVP0Y+jjo=; b=WXTO1ZaQQZxa5wpdCeYfxHkJ6LPOlJCK8sNONjhsA1cDzwpNBKNwWw87jMQ4qeJrxlXYZk2k9JrZhKFq3QtyfQfQYQQ0eaKQ7lE0Bs7dV4793hsijje5azUX5TH2co+0PGcI2ys2Wn4eEVO/L0M5eOSdeCrwkJLifjsa1Fck+VW3O5oslvZ+/mTR0KeM1+Juj15n7osLINv1HbPrjVPU49TT1I2GjTEyXWG3D3Q5Dp9ZsBfXJ/2zKwtx+kpDItHtfCm6HeyreM1y+yX2V6IQ0HcuPVEocvFbth95qP4rxHHjK+rWTwRH92fBkUhj8Rk063GinVuOJt6V+TxgIOMzVg== Received: from CWLP265CA0326.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:57::26) by CWXP265MB1912.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Mon, 11 Nov 2024 08:30:02 +0000 Received: from CW2PEPF000056BF.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:57:cafe::90) by CWLP265CA0326.outlook.office365.com (2603:10a6:401:57::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28 via Frontend Transport; Mon, 11 Nov 2024 08:30:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056BF.mail.protection.outlook.com (10.167.240.21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 08:30:02 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 501C6ACA0057; Mon, 11 Nov 2024 08:30:02 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 9D71310872C; Mon, 11 Nov 2024 01:35:42 +0000 (GMT) Date: Mon, 11 Nov 2024 01:35:42 +0000 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> <87bk07am4z.fsf@alyssa.is> <5s7bk55k6d6vr6gywsx65pn2k7kqj5j4z722762vuqccey4yol@hx6vzlml76tg> <874j4g5bco.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fmogce6fippzbhmo" Content-Disposition: inline In-Reply-To: <874j4g5bco.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056BF:EE_|CWXP265MB1912:EE_ X-MS-Office365-Filtering-Correlation-Id: be55d864-0887-4cf4-9179-08dd022b09c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z0xQVFZueE1ZTHVBWXJKK3R0NGNZdHU5aWR1R2x3TUFpS2c2K2hTbDA3MTNC?= =?utf-8?B?bVM4dmoxUXFXU1pPdzUwZE03eS9FNkV5UFFoS05XNjV1UUEyZ204RGl0czFh?= =?utf-8?B?djNSYThBSHJHT0JqTjJ5VjRqSUNER0EyRkl0RFpLV3ZYWm0xQjRNZW9VSFZB?= =?utf-8?B?eTFtU0F5Z1kxK1JJOWc4bHk1clJxZUl0N2d3L1BUSWtXZU5KdTF3aGNnK1pR?= =?utf-8?B?MXgxUnV4eURST1RQQlVHR0V0blNFUFgwdmtqcnZyelA0aWRhMGhUajZlSU1S?= =?utf-8?B?YkhtNUVMZ2ozWHNZTUxRYVFYK29zQWw4N09CL3l4Z2tKMXNJdVJKMUlHSFJq?= =?utf-8?B?cjlMemFpc1ZFUllBbHJOTktKa3hMS3FuYUlIK2xiRWZmYlJHK29sS3V2UWh1?= =?utf-8?B?Y0RVa0dLNnBkRG1HeW9Bb0Q4U3JBQnVaZ3JJVGNGMmxxU09pRWx4WnZJbE01?= =?utf-8?B?WGNzSVFMRUc5NUtIVWR0SnZkYWVsa2ZIMG1ZblZ2c1hUeXlNVyt1QStneWY1?= =?utf-8?B?YUM5QWZtMm1Id2Y0WVdkRTFrRVBIZEQrWHdKUG1XZlpsSzhqNmJkdE4xSXpu?= =?utf-8?B?cFpBVjgyczFLQ05VVVBWRFUzZnVITWhISE9welRLelZhNCtReFFFenRNSFFO?= =?utf-8?B?Y1B5dytwdTFIOVBWeS9IMGxzZSt0NDVRRHVyVkJWYlZkQXZGb1gyTnlkZ3lF?= =?utf-8?B?akNkdDMyUnJ3NUxKWk4xOEJoSzVqL002TnpPUVpoZS9hSGVRNU1zR2xsckd5?= =?utf-8?B?UU9qQnJvMTNNam5JakQxL0t5SXYyYVRORkVFNW9DN3VPNzNncGJKd1NZM0Jv?= =?utf-8?B?czJNUDR6Z3p3YldsZmhwSWlDaFRXWDU5WDNPZTgvTExxOGRoNE1iN3BxcjZ0?= =?utf-8?B?RDU3ejlwSFJSOUJ0ak9ROHFZMUVtcG9HNWhIc1ZmSmx5bXRacHdRQVdmQzVp?= =?utf-8?B?cjBiSWxVV0p4N3JZOEV5RHUyRDFtUXNqdDNNdDZpWXRDUlZIZGo3ZHBYYWFq?= =?utf-8?B?blNFK2diZ1k1cjhEeUFrQmhBSkQvSDBpa0ZPRWt1dTd4WGVzMmlpZjFSanp3?= =?utf-8?B?OEVsWXlHZG9vQldPcW1FcFFwMDNNc0g1TGdNei9XemF5RW9ndWpLdVAxYU5s?= =?utf-8?B?MTE5UnhPOEhVM3Y3a3FmWVhpTmlRWi9CLytCQU9oS1FCTUE2R3lDNDZGbmYz?= =?utf-8?B?WFNON1lsbVNRWEpuOUFFZHdWbDlyQkRRWGJDazBYZ0ZSQzFBZUVRN3BUTUZu?= =?utf-8?B?S21QUmVIVTB2bk1WcEJ1MGo5VEQ4U3J3a0p2THZLYWo3a3BQamRBd0p0a1RZ?= =?utf-8?B?ZklpTkZESkxTLzJUdXBJN0xNaWltVExvWWNDQzY1bldkNURPNEcyQXFhYzZI?= =?utf-8?B?SnNnK3BVekVxR3hFdisvN2JWS3Rtc1VkeHY1bTB5NmdhUndRZmpvTS9SVzR2?= =?utf-8?B?Q0UrWHpYV3NPVGlKNS95RzhPWks5L2dsamxkMzhIWjV5dks1OWZQaitFRCtN?= =?utf-8?B?emkrRy90S2Z4R3MyZkNNbzZreTAzZVJFUE1CRVFNQ1JqS0svZDMxNStwdmti?= =?utf-8?B?NDA4akVTbGVMTUg5dzZpdjBncGxZSHNaOU9ZbDBETlRQTHczajJCNHpkd2tq?= =?utf-8?B?Zm1obm0xVEQxZHRiS2dDQ1N0clNZdEg3Wk82bG9KcTBzdGJpZ2pjWXRXdTBQ?= =?utf-8?B?SjdnbXJLNFlUOHdUMzRyUDl6dWo3eUZiem0wNzJVQSt6b0tHSktGRHlmWVdz?= =?utf-8?B?TVF0YnRhZHppNnJHRUJjZHE1K0xqVndDTnFYSGtrZ1d6SzNFZDV0K1RSSUdT?= =?utf-8?B?Q2JRVndDYzhpZXczTm43RG0yR0Zlcmg5ZjlMeitDMVR1M1hxeStVNk1hc2FQ?= =?utf-8?B?Vy9ZWW1acmk3NDVKcjZYSTE3UDBKcTcyVHA2aWY5R0ZHaEE9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 08:30:02.6645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be55d864-0887-4cf4-9179-08dd022b09c5 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056BF.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB1912 Message-ID-Hash: 7N2KUUUW4MFDBZQ62U63RLKAZSIT67A3 X-Message-ID-Hash: 7N2KUUUW4MFDBZQ62U63RLKAZSIT67A3 X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Dom RODRIGUEZ , devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --fmogce6fippzbhmo Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09.11.2024 22:46, Alyssa Ross wrote: >Dom RODRIGUEZ writes: > >> On 28.09.2024 16:27, Alyssa Ross wrote: >>>Dom Rodriguez writes: >>> >>>> On 07.09.2024 18:40, Alyssa Ross wrote: >>>>>Dom Rodriguez writes: >>>>> >>>>>> crosvm was producing warnings when using `--vhost-user-gpu` and >>>>>> `--vhost-user-fs`. >>>>>> >>>>>> In this commit, I have adjusted the `crosvm` invocations to look >>>>>> something like `--vhost-user $DEVICE,socket=3D$PATH`, where `$DEVICE= ` is, in this case, >>>>>> `gpu` or `fs`, and `$PATH` is the path to the Unix socket. >>>>>> >>>>>> Signed-off-by: Dom Rodriguez >>>>>> --- >>>>>> img/app/Makefile | 4 ++-- >>>>>> release/checks/wayland/default.nix | 2 +- >>>>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/img/app/Makefile b/img/app/Makefile >>>>>> index 3adf8c4..11ef6e1 100644 >>>>>> --- a/img/app/Makefile >>>>>> +++ b/img/app/Makefile >>>>>> @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-v= host-user-gpu start-virtiofsd >>>>>> --disk $(RUN_IMG) \ >>>>>> -p "console=3DttyS0 root=3DPARTLABEL=3Droot" \ >>>>>> --net tap-name=3Dtap0 \ >>>>>> - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >>>>>> - --vhost-user-gpu build/vhost-user-gpu.sock \ >>>>>> + --vhost-user fs,socket=3Dbuild/virtiofsd.sock:virtiofs0 \ >>>>>> + --vhost-user gpu,socket=3Dbuild/vhost-user-gpu.sock \ >>>>>> --vsock cid=3D3 \ >>>>>> --serial type=3Dfile,hardware=3Dserial,path=3Dbuild/serial.log= \ >>>>>> --serial type=3Dstdout,hardware=3Dvirtio-console,stdin=3Dtrue \ >>>>> >>>>>This is still not right, I'm afraid. >>>>> >>>>>When I run nix-shell --run 'make clean && make run' VMM=3Dcrosvm in >>>>>img/app, I get this error: >>>>> >>>>>[2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error = 1: failed to connect to vhost-user socket path build/virtiofsd.sock:virtiof= s0 >>>>> >>>>>Probably the tag should also be a comma-separated key=3Dvalue option? >>>>> >>>>>(This doesn't have any automated test, because it's just part of the >>>>>development environment, and setting up a test environment to resemble= a >>>>>development machine isn't trivial. Should be possible though.) >>>> >>>> It's bizarre. I've done some more testing, and it seems that >>>> `--vhost-user` isn't *quite* there yet on feature parity with >>>> `--vhost-user-fs`. Maybe I'm going wrong here, but it doesn't recognise >>>> the tag as a k/v option. >>>> >>>> I have managed to get the tests running with `--vhost-user-fs`, but it >>>> does look mismatched now. >>>> >>>> Would you prefer I revert the changes to `--vhost-user fs` =3D> >>>> `--vhost-user-fs`? >>> >>>You're right! I've just spent the last little while looking around >>>trying to figure out what's up here, and I think I've figured it out. >>> >>>In this commit[1] they made the vhost-user-fs tag optional, because it >>>can now be set with virtiosfd instead of the VMM. This is probably >>>good, because the more generic vhost-user becomes, the more hope >>>Spectrum has of one day not needing Cloud Hypervisor patches. :) So we >>>could try using --vhost-user fs for crosvm, and then passing --tag to >>>virtiofsd, but it'd need to be tested with VMM=3Dqemu and >>>VMM=3Dcloud-hypervisor as well, because I'm not sure whether they support >>>a backend-provided tag. >> >> Finally got round to this. >> >> By the looks of it, currently `cloud-hypervisor` and QEMU do not support= a >> backend-provided tag. >> >> We could introduce an abstraction [function] in the Makefile over >> `vhost-user-fs` arguments for each hypervisor, which we could use whilst >> waiting for QEMU and cloud-hypervisor to support backend-provided tags >> with `vhost-user-fs`, and in the meantime use the abstraction for >> crosvm. >> >> I envision the abstraction as taking a few arguments: hypervisor, >> virtiofsd socket path, and tag. The abstraction would then construct & >> return the correct command-line argument for the hypervisor. We would >> call the abstractive function in the call to the `run` Make target. >> >> That way, we're prepared for the future. >> >> What do you think? > >Given that they don't support the optional protocol feature, I'd expect >cloud-hypervisor and QEMU to just ignore the tag given to virtiofsd =E2=80= =94 >can we not just set the tag on the virtiofsd invocation for crosvm, and >keep setting it in the cloud-hypervisor and QEMU command lines for them? That's a fair conclusion. Are you happy for me to submit a patch just for crosvm for now? Best wishes, -- Dom Rodriguez --fmogce6fippzbhmo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQS8QbGzuJNwWBsvCoTK0brmh9AFqwUCZzFfZwAKCRDK0brmh9AF q4mNAQD5fzE94mDu5R7orq54wSaOPLQ6uUSHAl2FwEw36QfBGAD9FG4Zt7UKsxOw /P3PYl9nSzKN577E24BJx2kO0PwTXQU= =fi/7 -----END PGP SIGNATURE----- --fmogce6fippzbhmo--