From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id A6D231AFD3; Sat, 09 Nov 2024 02:00:32 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B76951AFA0; Sat, 09 Nov 2024 02:00:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=DMARC_NONE,FORGED_SPF_HELO, KHOP_HELO_FCRDNS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO2P265CU024.outbound.protection.outlook.com (mail-uksouthazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::3]) by atuin.qyliss.net (Postfix) with ESMTPS id CAEEF1AF9D for ; Sat, 09 Nov 2024 02:00:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vu9mQL7qakrAWlYs8nY5x2uga5ZrL7+SAykrH+jdc/vrVaXxNGWnq1j76CIGep2Je+gbM2XCBZj/LvD+gRzKTbOK6aELCBj8eHPTuVnQXMbaK+C0E19AkF4PV2DnJLaz19mXN/QgBytW/Z0iq7H9iXs/i+lUM82/OYNlzUVNnEXb7ZhSMNzmnbw9hW/PayL5or0a06G6fR/X0neRJEfZwV7y5Bava/gCKwDKEXLanUcCsZSCEeTVyPwQbFwVUloNOdFJtnoKDg+KNBoZaYTNs4GbkYfI5saEhPa7HWXPMqmkgWBppec4AwWo4ubJkSdsaJ4DcmXalM1QODEXYXoRZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D1tUIyLv96+NoilfNBN1xe1HZWOnrq1kDbRvGSMTS0c=; b=ZtrmZhzazqBKtYkVAwv2YPR2vKq+Qq8eqq064AehqLZGJX/0jrGUZY71UI5IIzasJEIx1Iaq5oPh5t+h7HATvAc8qgTYddYaKx5M0n3Ky32pJ0cVrrVMaFO7JmH5pmF8SkVZFHW3cahmfV2/ObP/ZFdPlR0mj70bChXz9DBt0gfXcs16d2Da4O1SVsYnndZZL7ond0u3Pi7E+4gMR3jLKZutrsuTX9RlXn9418yM/HF6/9NnFArablsJeSYz9F7Fu91hWMsKNWHtoqU96BNyjGxgpS8q1KLvYPwpg7DhLtEwn+VQ0deWzNO1rCFNuB/wILtaPPa4Q0v36WRiz+v00Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D1tUIyLv96+NoilfNBN1xe1HZWOnrq1kDbRvGSMTS0c=; b=OEbpz4PkRNA+/4KUw4NNC4VWAs+yInCHzVwDmwxlysROvps/GthRfGm7Kg9zraCMnlhZSquP8wHvd+Si+Y8/jaX6za5KaL7/MUxDvqGlg/fBbEDWcmasjQ2Jk04vltCkPQJJvjkfsrzKiSrRZkyy7nf+O5quXLwbV2xQzq0r7L4xviozlXlzzLUB1aKxnrup5hZ30weZJ0pleYu6dfHh+/E18gJ/7UK1ehsxRj3l+rwmZDZdThoBOno1k2g6oy83O/KYcl4lvj07CA8mZw07222P+OYrOu250i9hFMVIToJgyIWlfH//RWQBwHIoajV9PIAozOLM5PuZ5LnDDu5z3A== Received: from CWLP265CA0347.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5a::23) by CWLP265MB4970.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.22; Sat, 9 Nov 2024 02:00:01 +0000 Received: from CW2PEPF000056BA.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5a:cafe::5) by CWLP265CA0347.outlook.office365.com (2603:10a6:401:5a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.21 via Frontend Transport; Sat, 9 Nov 2024 02:00:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056BA.mail.protection.outlook.com (10.167.240.5) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8137.17 via Frontend Transport; Sat, 9 Nov 2024 02:00:01 +0000 Received: from MORPHEUS-LINUX.localdomain (unknown [217.155.6.253]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id 11521ACA0053; Sat, 9 Nov 2024 02:00:01 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 5E80C108AB6; Sat, 09 Nov 2024 01:44:19 +0000 (GMT) Date: Sat, 9 Nov 2024 01:44:19 +0000 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v3] crosvm: Rename `--vhost-user-gpu` flag Message-ID: References: <20241107005948.2318591-1-shymega@shymega.org.uk> <875xoyf04f.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dvnxftnae4xbdyhx" Content-Disposition: inline In-Reply-To: <875xoyf04f.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056BA:EE_|CWLP265MB4970:EE_ X-MS-Office365-Filtering-Correlation-Id: a69298f5-f5b9-4897-3f43-08dd006238b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RkRTOHNyMDhzKy9ub0tKelptWDZKZ2tLbm9KTGVWRkk1Wk84L01lbHRRZlNu?= =?utf-8?B?Z0pKWHFEcHUxR1BiNXltQXdUT0FpNWhqV0xzNjVjZUFvRE1zcGwraEJzUm5h?= =?utf-8?B?dGFUWkdwNnhnYktuT3FyY2dCZGE1TzJwVVJ2MjFEbHNaUVRHT253TFY1L0xK?= =?utf-8?B?aURvaDFxbjZZZlNLRnRldUlNVHl5ZkJMY2NhaUx4QXNreWRkK3gyK2tmQk5w?= =?utf-8?B?aUJmSSt2eHFrU2tNZU84NHQ0TFlERzNBZmtuTWw0Y01OZzVVQ1NkSndRbVRr?= =?utf-8?B?Zk4xb2EyekF1aGJwN1JUb1YyQVlNcExPNVdjUUVIWk4wa1pVUTIxUU1aYkln?= =?utf-8?B?M2J2UWZDRFA1K0pZanAwT01aSFFYL2h1cU5zZEVWNUpSclhqVkN4a0I1ZUxw?= =?utf-8?B?WFpJUXZyQXRLcHFrckdaRHdRY1lxa215ajRUcThSVVZ5Mk5mdG9zSTVDay90?= =?utf-8?B?S3MzbjVtelEwVndrNHE3NlgzbTZVVWxpeGtDQjJLUGJKdWtzdDFZN2d6RjFz?= =?utf-8?B?SEphRjczQ2JpUDh6S3Raa0IxWXdtZXU3YVVMRGlOMXdObGp2L3NSMHM0Vm9H?= =?utf-8?B?WlBQMUs0RDByNW1rMy9EVnl2cTlmSkZ1OFdRUGdlYkQzWGQvSjRsVXdDK20v?= =?utf-8?B?eGdZVE85SlZzN1NOODREMkxYa0QvaExkSHY3cW80OEZaTlhHMmp6dFZ0SThV?= =?utf-8?B?S0VGamZNUHQ2RE8vbmUyejhETDNTdGJnaUJyS2l5eDZrQTJBVzR6djZEZmMv?= =?utf-8?B?aXcyeEViK3ROOWdseTJ2bklxNzhrR2dwM01iZklLMEZSSU5IQnNML3lKRHVT?= =?utf-8?B?MVNKdmx2cWlqdmthb0lYNFBieDFIY1czM2I0REQxYTFmRUt1ek5KUFBySndj?= =?utf-8?B?S1prek52OWdqWUxRNG5LTmdvdnJ6dnFmWjNKT3FjQ3dEVnVZNW9PR3lZdUVn?= =?utf-8?B?OVNJQkJweFBGN2RzeGR0UTZKNWo4N200MGNWOVJwcVVXOVpqS0kzVXJIdlJ6?= =?utf-8?B?VlJFNHE5dWFNTlp6NWpEaEZ1UHU3MC9mcnYrc3pCZjJMU253V3l0ZXdVRk83?= =?utf-8?B?Y3NsSmZPcVl5S2p1Wm5ueTQ0SmNYUVdvblR4aEc0WFE3OVpMN2k3R1duTTg3?= =?utf-8?B?SXlsdVJMTXVmL2ZBY0lXMCt0ZjVaK2ZkQXQza3RxL2JFYWtJOGxPbUxmS2l6?= =?utf-8?B?Tm93YWxFWXBXVmdxRDFiVktGTjFUTW5VeWdRM0JvaER6ZlZKbnVrUkVtZEVM?= =?utf-8?B?UFRJcTR2cnVXMXpxQkNYRlQreStxK3lRQ0MvZ3NCYW03QllGY1VFQnF4RW8v?= =?utf-8?B?bjRGeGpMd1VXRHZDQjNBbThKZkRlemovQ1FKc0FaeWhHK01ETFVBMU14VFFn?= =?utf-8?B?YlEwRTZ1NlNDbTQ2ai9TeEs5WjRiYzdIcCtsNitsclVPM2crcmMzT3hITHR1?= =?utf-8?B?dmh2NzQ3eDY3WEV6RmxXaDYzdXIzcFYyZHg0SUpBWkoyY0tsY0Izc3hRZlFr?= =?utf-8?B?ekN6aHRTUDVqRVN6Y0tZcEx1MW5GaFA0d05ldmZvVFZhY2c5aUptZmJNMHBX?= =?utf-8?B?Mld0eUdqTyttNTBiY0tiU0ExdXBlMHF6QVFlZ0JaVC92YmtpN2Q3TkZqNEVm?= =?utf-8?B?RXNUTi9YVm8xSXZLMUU5Z2xraWRHMlc5elpJazdRbGhQR2xxNmlJcFo0L29o?= =?utf-8?B?R2VFR3A0ZEY0N3VZSEtLR1A5Tkg4czNHbndhVFRCQzN0VDBvUWREci9EckNX?= =?utf-8?B?WXBGbUNHVFJPNVgxMjhVZTFwTTY1RlVKM25UREVqaW5VQmFNMC9DM3gzQ1ZX?= =?utf-8?B?UmxwK3dNSVRkWkpYcGl0ZDRjSGNlaS81VE5xKzFHa2EyeGZ3U0xRa0tuclg3?= =?utf-8?B?MXp3WjFvRlVGTjk1QWFCL0o1WGhjT3hWSzl2OVorRUE2WVE9PQ==?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2024 02:00:01.4116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a69298f5-f5b9-4897-3f43-08dd006238b6 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056BA.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB4970 Message-ID-Hash: X2QSXDI5BWNUJONISOE4NXKCMTKVKM6D X-Message-ID-Hash: X2QSXDI5BWNUJONISOE4NXKCMTKVKM6D X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --dvnxftnae4xbdyhx Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08.11.2024 12:14, Alyssa Ross wrote: >Dom Rodriguez writes: > >> crosvm was producing warnings when using `--vhost-user-gpu` and >> `--vhost-user-fs`, of which the former is fixable, but the latter >> requires some more work. The latter will be patched later on. >> >> To mitigate the former, I have adjusted the `crosvm` invocations to look >> something like `--vhost-user $DEVICE,socket=3D$PATH`, where `$DEVICE` is, >> in this case, `gpu`, and `$PATH` is the path to the Unix socket. >> >> Signed-off-by: Dom Rodriguez >> --- >> img/app/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/img/app/Makefile b/img/app/Makefile >> index 7c3e3e8..db9fbea 100644 >> --- a/img/app/Makefile >> +++ b/img/app/Makefile >> @@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost= -user-gpu start-virtiofsd >> -p "console=3DttyS0 root=3DPARTLABEL=3Droot" \ >> --net tap-name=3Dtap0 \ >> --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >> - --vhost-user-gpu build/vhost-user-gpu.sock \ >> + --vhost-user gpu socket=3Dbuild/vhost-user-gpu.sock \ > >[2024-11-08T11:12:36.503808752+00:00 ERROR crosvm] arg parsing failed: Err= or parsing option '--vhost-user' with value 'gpu': missing field `socket` > >Is the space between "gpu" and "socket" supposed to be a comma, like in >your commit message? Good catch! Fixed the patch in v4.=20 I've taken a look at the patch suggestion for vhost-user-fs - email incoming. I will also reply to the Flake email chain soon as well. Best wishes, -- Dom Rodriguez --dvnxftnae4xbdyhx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQS8QbGzuJNwWBsvCoTK0brmh9AFqwUCZy6+cgAKCRDK0brmh9AF q2BUAP9EMk2X6nv0VEfO/iZZ/cWl5+mnrNQ95IUsvQ1JSIci2wEAk+3cMETi8gaP gg7MUQIOkUUB+VUyK7j44FF/amqZBww= =L2EK -----END PGP SIGNATURE----- --dvnxftnae4xbdyhx--