[PATCH v3] crosvm: Rename `--vhost-user-gpu` flag

[PATCH v3] crosvm: Rename `--vhost-user-gpu` flag

[Dom Rodriguez]

crosvm was producing warnings when using `--vhost-user-gpu` and
`--vhost-user-fs`, of which the former is fixable, but the latter
requires some more work. The latter will be patched later on.

To mitigate the former, I have adjusted the `crosvm` invocations to look
something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
in this case, `gpu`, and `$PATH` is the path to the Unix socket.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
---
 img/app/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/img/app/Makefile b/img/app/Makefile
index 7c3e3e8..db9fbea 100644
--- a/img/app/Makefile
+++ b/img/app/Makefile
@@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd
 	    -p "console=ttyS0 root=PARTLABEL=root" \
 	    --net tap-name=tap0 \
 	    --vhost-user-fs build/virtiofsd.sock:virtiofs0 \
-	    --vhost-user-gpu build/vhost-user-gpu.sock \
+	    --vhost-user gpu socket=build/vhost-user-gpu.sock \
 	    --vsock cid=3 \
 	    --serial type=file,hardware=serial,path=build/serial.log \
 	    --serial type=stdout,hardware=virtio-console,stdin=true \
-- 
2.44.1

Re: [PATCH v3] crosvm: Rename `--vhost-user-gpu` flag

[Alyssa Ross]

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

Dom Rodriguez <shymega@shymega.org.uk> writes:

> crosvm was producing warnings when using `--vhost-user-gpu` and
> `--vhost-user-fs`, of which the former is fixable, but the latter
> requires some more work. The latter will be patched later on.
>
> To mitigate the former, I have adjusted the `crosvm` invocations to look
> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
> in this case, `gpu`, and `$PATH` is the path to the Unix socket.
>
> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
> ---
>  img/app/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/img/app/Makefile b/img/app/Makefile
> index 7c3e3e8..db9fbea 100644
> --- a/img/app/Makefile
> +++ b/img/app/Makefile
> @@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd
>  	    -p "console=ttyS0 root=PARTLABEL=root" \
>  	    --net tap-name=tap0 \
>  	    --vhost-user-fs build/virtiofsd.sock:virtiofs0 \
> -	    --vhost-user-gpu build/vhost-user-gpu.sock \
> +	    --vhost-user gpu socket=build/vhost-user-gpu.sock \

[2024-11-08T11:12:36.503808752+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`

Is the space between "gpu" and "socket" supposed to be a comma, like in
your commit message?

>  	    --vsock cid=3 \
>  	    --serial type=file,hardware=serial,path=build/serial.log \
>  	    --serial type=stdout,hardware=virtio-console,stdin=true \
> -- 
> 2.44.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: [PATCH v3] crosvm: Rename `--vhost-user-gpu` flag

[Dom Rodriguez]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

On 08.11.2024 12:14, Alyssa Ross wrote:
>Dom Rodriguez <shymega@shymega.org.uk> writes:
>
>> crosvm was producing warnings when using `--vhost-user-gpu` and
>> `--vhost-user-fs`, of which the former is fixable, but the latter
>> requires some more work. The latter will be patched later on.
>>
>> To mitigate the former, I have adjusted the `crosvm` invocations to look
>> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
>> in this case, `gpu`, and `$PATH` is the path to the Unix socket.
>>
>> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
>> ---
>>  img/app/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/img/app/Makefile b/img/app/Makefile
>> index 7c3e3e8..db9fbea 100644
>> --- a/img/app/Makefile
>> +++ b/img/app/Makefile
>> @@ -167,7 +167,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd
>>  	    -p "console=ttyS0 root=PARTLABEL=root" \
>>  	    --net tap-name=tap0 \
>>  	    --vhost-user-fs build/virtiofsd.sock:virtiofs0 \
>> -	    --vhost-user-gpu build/vhost-user-gpu.sock \
>> +	    --vhost-user gpu socket=build/vhost-user-gpu.sock \
>
>[2024-11-08T11:12:36.503808752+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
>
>Is the space between "gpu" and "socket" supposed to be a comma, like in
>your commit message?

Good catch! Fixed the patch in v4. 

I've taken a look at the patch suggestion for vhost-user-fs - email
incoming.

I will also reply to the Flake email chain soon as well.

Best wishes,
--
Dom Rodriguez

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]