From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id CB99D137DB; Tue, 28 Jan 2025 23:23:22 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 3E88D13839; Tue, 28 Jan 2025 23:23:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::5]) by atuin.qyliss.net (Postfix) with ESMTPS id 08C4C13833 for ; Tue, 28 Jan 2025 23:23:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rw8UGQh16um6pd/n5pLihkEbbKE9p37mg0hruT/ec4Kbv4TN/HJvKfzdoxINqShHMief4JG8PEj4j+KdKwxa0kA3wDBnO1EubHXpRISLtlKonG8bs6zW00egF4LOgR96yParvbSFwo55+uPpkXJFN7IBGXXiwQHdkZ6edb8auPzI1zqqGr3Jpo4Yr+WuVoLzy1VcX5hUYar6nSqjXW+0IV+cKy25dGXzcuYKC47VWqKpEYT/ERejwAIlp8TQA8HUmtxRCAgiW+Ljc5lumig9qWfDaJsblKZyNg3dsO02zvUL5yV4T0k6SDXMoobd6Uj8YJsbzFRQNXMP5gEfm97iSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=riWVdvyQaDK9WvKwlcAAYXMKMyGaybjLdmW3bxCma3s=; b=gGHHEjsjhohw8Sr2ZNyMZsYtolwbgk5vKhy8X5GYO/D2TYVKcL3rnRtrx+QmGQxUyBiVc63ggiCKCv8QbUIH+2PHNk9r41muuhMVdvZ1QhY2/AMSRCY3ORMU+j5voI9ViC/R2HdY5VMjlagc+OiP0tfaWAUo/3AcOv9x7T5svMwJgSk6CfNIfSoSKv3zHG1LXgWlcoz8k6aWKQhbHcgYwPXPl8Oe/Hb0bTjoZPoGEgr3wGVqMw4fybqvdN83XPRBG367rIf8w6T652Svsa7PCpSwEfVJdYwyhserW4tYuXHBVagr3SIpJSGP6xCKHggSUC8sDYuQ4CXIGkDx05cDCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=spectrum-os.org smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riWVdvyQaDK9WvKwlcAAYXMKMyGaybjLdmW3bxCma3s=; b=RRHH0yLkZzrs88TSD9OVPULxIgeo41OTrZpEl2EnMhc8LDdCAQBooop8b7OrUlPswYtspE4pfTj2B5tMAiL44wxpeFS2pduXk4ZEyhCHOSCnzU0tARpAVtLsirQUjnzwyDF3S8Nv9LA75GjIA2PffY9F0MXko/WV77Ci+8nEZLZmrO2D7JYaOfwSsE7lEbDT8s2QBxtsvXAptfkDz5UsE/u0u6qOSYaTJafQBTIx5YjfRCxZsmQ4gPO2YVRBq8dOSt5wbWGtIgMgUM5IOOYVazQFSNiCL71VfMta+XDnMUmYntvSq5fI++etI2eISpbu+gCqPsv/mPViqgEW7Jlt3g== Received: from CWLP123CA0244.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:19e::13) by LO0P265MB6801.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2d6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.23; Tue, 28 Jan 2025 23:23:07 +0000 Received: from CW2PEPF000056C0.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:19e:cafe::b4) by CWLP123CA0244.outlook.office365.com (2603:10a6:400:19e::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.23 via Frontend Transport; Tue, 28 Jan 2025 23:23:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056C0.mail.protection.outlook.com (10.167.240.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.14 via Frontend Transport; Tue, 28 Jan 2025 23:23:07 +0000 Received: from DEUSEX-LINUX.localdomain (unknown [217.155.6.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) (Authenticated sender: dzrodriguez) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id E96ACACA0049 for ; Tue, 28 Jan 2025 23:23:06 +0000 (UTC) Received: from DEUSEX-LINUX (localhost [IPv6:::1]) by DEUSEX-LINUX.localdomain (Postfix) with SMTP id 5A5F714900A for ; Tue, 28 Jan 2025 23:23:02 +0000 (GMT) Date: Tue, 28 Jan 2025 23:23:02 +0000 From: "Dom (shymega) Rodriguez" To: devel@spectrum-os.org Subject: Re: [PATCH] fix(foot-vm): add dejavu_fonts and fontconfig Message-ID: References: <20250128222241.914713-1-samy+spectrum@lahfa.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20250128222241.914713-1-samy+spectrum@lahfa.xyz> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056C0:EE_|LO0P265MB6801:EE_ X-MS-Office365-Filtering-Correlation-Id: c5d3ec45-907e-4229-c00a-08dd3ff2b8ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UjhKOGQvVUhqQVBjZFVjZ2ZpbjRSejEwRTNUMm12MGJPTFh4UFVWQkZqeHMy?= =?utf-8?B?STJVSzlnSy9TbWxpdVd3NktIRExvYVZRRCtqYTZCZW95ZWZ3SDVsV0wvRXg0?= =?utf-8?B?Vi9rYVNUazNLRmtlY1BLZUpFbjdRWmI4ZFhvejZibWVIaUdzRlNwcnB2SkQ0?= =?utf-8?B?OEhGUGYzQUYyeW1WdzVwQmNqak9qSnBiMG5YVDJOZEJFRXdOdmw4cU9wYkVx?= =?utf-8?B?RTA2UzNOTWs5TXdYcUtqaHdEblZ6djRzVWF3U3hPY2UrL0dvTFlKdTYyL3F4?= =?utf-8?B?WmpDTlhoalV1RXViRHRIUFU5ZnJWbjdES1hPMEsvVXVzWms5UFQ2RDdwaXVs?= =?utf-8?B?QkJvRjA2cTN3TU9SL2xqOThrWnV1KzNMSEVxb1k0eGVSTzhyMXdkK3MxNm95?= =?utf-8?B?aWUyQXlpU1VsMW04UzUwcE5OSGVQcHcrek0yRjRrbDhxTVgvWHFZbVY3ZklB?= =?utf-8?B?c0NJU21QQ0tkdW9rUXZQUW9OL2QzSkg2T3BaOHYrOEMxc09uNU82Tmg4c3ha?= =?utf-8?B?OGJHTndZM0JRemoxa2xLN1BGTis2NzBIUUw5bU4rZ2dSU2dvaXduZDViYStC?= =?utf-8?B?K25LMENtU3BjWWsrWjZoSUtXMUJRbWI0N0xBV1NJWkJPdjkvZ0IwM1daaUpL?= =?utf-8?B?ZzR1SFphcmJhS2JFTzhVbElCQnlQQUJEMXpxcHpMYW9NOFlLR1l2ZXBhT2Uy?= =?utf-8?B?UXhPdHo3TTNnZXRLa1RlRVZrcFVyMmdOa1pzYmJwRnNZdjhPVmRuVUtaRmpn?= =?utf-8?B?U1QzMFFRTEdUREorbjU0eGRrM1ZXNjhhNUk4WUpDQnN0eG1RcEl0VGtheFBY?= =?utf-8?B?OEtzNVZSMlI0UTJXSFk0TTAxT0VNUGVyaTA0MEhlSkFYZDhNMnNEME0rZmZz?= =?utf-8?B?U2ZiV1JKU2kyVm5uc0RVRUxNcFptZFd3SGM3Y1FCNk9CN3hhZkpsNVBhTWlm?= =?utf-8?B?NkFWL1FZRmFTL2RrQUZiSEQrTTlyV25yUXlLWjBXWi9iSjB3NXNkMXI4czBB?= =?utf-8?B?ejZzNTljQnUyMVBxLy9YV2grS2xqdFBMTWdxaWtBUHVrTittbUt2SGVOKzRI?= =?utf-8?B?OFhhbHZRVzNDMkxaZWxyZDBuVzE5Z0VFZVAxcTdVVGdVdTBXQ0dRdHE5bW4z?= =?utf-8?B?UVJwREljUGJnbzVWbnhLbFYzcW5oSkpwaDNsa3BGcWxWZDh2LzNRT1Y0eVAz?= =?utf-8?B?bTFyR2ExU1NNTzgwQytMdFRoRGNuY2oyWlhDSUdPbnBOOHVQcWFJT3dBQjBq?= =?utf-8?B?MGozTjR2QXlRbDNIdTlxT1BEbldleStJRzVxSHJabllyMGtWcWsydGlNeHJF?= =?utf-8?B?anN2R3RlU3FGYTJWbzZLOGRqKzUwRGczYkkraHlWbWpCakZWU0pUenlSRnBN?= =?utf-8?B?VVNQNkJRT1ByeEo1c3NkM0ZrUzNKNDlTNFd2UlFYNDNQV3BoTmw3UEdQV3B2?= =?utf-8?B?WUZqS2lydkY2c1pGcHgwZEVJUEVLY0ZoUWo0MnVTL0pCcXE3a1A5dk9TY2d5?= =?utf-8?B?bVZBcFZSOHhibVREeS9pNURNZGZWS3FnT1VNR2pXKy9COUFXaEtLRGdUSk1v?= =?utf-8?B?RmoxaTNQeGVPVXNDa1pmc0VmSlh3R2JvL0ZJa0NpS0d3enZERk9SdHoxY3J6?= =?utf-8?B?YWJqNUZzcmRqRVZIMnNYS0djTmkxVlVMM3ZrREkvZmRTWU9MR1VOdU5kOHlo?= =?utf-8?B?dlV6S1YzdVYreW42bFpTN0lxUjRJeTBUWS9OaTRCQzBXdHUrV1FsanIwT0xu?= =?utf-8?B?QTQwcVlWT3FRRnRyS1JmR01PRjVyQlRocUlNUkVYNG5MWEZvNHFoWTRpYjUw?= =?utf-8?B?U0VnTXhMSUNPUjNwTFg3TEpTUnV3cnRxeUhSSlV5U2ZyaHlKeG5ZSnNCZm9x?= =?utf-8?B?bmFJaEVYYmhOQUFVRUNWMVRrbUwycFF0b295ZnU1NzJCSjhtckd4N1QyQy83?= =?utf-8?B?d0cvTGh3TGlqeXlIOE81NnBsVWtEcFhwVXV5QTF4bGxiZGpIVTJZbmc3Tndy?= =?utf-8?B?TStiRWZOYmh3PT0=?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2025 23:23:07.3143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5d3ec45-907e-4229-c00a-08dd3ff2b8ee X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056C0.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB6801 Message-ID-Hash: PQIZWCKS5FLU43GHWRLZR72WI4BEROWC X-Message-ID-Hash: PQIZWCKS5FLU43GHWRLZR72WI4BEROWC X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28.01.2025 23:22, Samy Lahfa wrote: >Signed-off-by: Samy Lahfa >--- > img/app/Makefile | 3 ++- > img/app/default.nix | 1 + > img/app/etc/fonts/fonts.conf | 21 +++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > create mode 100644 img/app/etc/fonts/fonts.conf > >diff --git a/img/app/Makefile b/img/app/Makefile >index 7887aa8..8bfb7a1 100644 >--- a/img/app/Makefile >+++ b/img/app/Makefile >@@ -51,7 +51,8 @@ VM_FILES = \ > etc/s6-linux-init/scripts/rc.init \ > etc/s6-linux-init/scripts/rc.shutdown \ > etc/s6-linux-init/scripts/rc.shutdown.final \ >- etc/xdg/xdg-desktop-portal/portals.conf >+ etc/xdg/xdg-desktop-portal/portals.conf \ >+ etc/fonts/fonts.conf > VM_DIRS = dev run proc sys tmp \ > etc/s6-linux-init/run-image/service > VM_FIFOS = etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/fifo >diff --git a/img/app/default.nix b/img/app/default.nix >index 6537fb2..fc2af0e 100644 >--- a/img/app/default.nix >+++ b/img/app/default.nix >@@ -37,6 +37,7 @@ let > s6-rc > terminfo > xdg-desktop-portal-spectrum >+ pkgs.dejavu_fonts > > # Some packages can't (currently?) be built statically. > >diff --git a/img/app/etc/fonts/fonts.conf b/img/app/etc/fonts/fonts.conf >new file mode 100644 >index 0000000..0dcde54 >--- /dev/null >+++ b/img/app/etc/fonts/fonts.conf >@@ -0,0 +1,21 @@ >+ >+ >+ >+ >+ >+ >+ monospace >+ >+ DejaVu Sans Mono >+ >+ >+ >+ >+ sans-serif >+ >+ DejaVu Sans >+ >+ >+ >+ /usr/share/fonts >+ >-- >2.47.2 > Could you edit the commit message and resubmit your patch to be a little more descriptive, as well as the justification for the change? I can't see any prior discussion on the list for historical info for this change, and I'm not clear as to the rationale of it. A v2 of the patch would be grand. Thanks. Best wishes, -- Dom Rodriguez