From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 960411059B; Sun, 22 Sep 2024 15:34:18 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 28D4A10589; Sun, 22 Sep 2024 15:34:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: *** X-Spam-Status: No, score=3.1 required=5.0 tests=DATE_IN_PAST_12_24,DMARC_NONE, FORGED_SPF_HELO,KHOP_HELO_FCRDNS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01on20720.outbound.protection.outlook.com [IPv6:2a01:111:f403:261b::720]) by atuin.qyliss.net (Postfix) with ESMTPS id B4D2F10587 for ; Sun, 22 Sep 2024 15:34:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T+K67xpqkaUu7iNpULoZAa1GkG+D/YKG4dUPQjlF3vLROQsSu6Ero4pygkk7UIwjQux2Xj08e49SxJ7BwChxgcLOeaF5eGN3r2M4vsJbGbc1o+Xx3yFeKvTVcNDlonJz2NCov9eaRQNXWuaM0nLYPJU7BBQl+tZ8ZQuy7ND1jAfSQ4MrKExEVcHG2TkoaHfBbVbA8/9QJDxBzP+lrrEXjotRQez2trs9zNQBSBiNPY/Fbo+Zzz3r5yGhvDc3Rb3JfQDvQOA0zZmocYbZwvXBEGNc1XNE/9InUCcEWoVDuInQ+bDP2TFCe7m79w2zBSZNKaBGFcOdjHV66aCpWpbsrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4+EeWcSoAxR86jRVKs8/zsAHETZCIvxVnaYzEDBCzCI=; b=rR7dRsSz+ybcDkb0XfqOabrt/4BGSNUS41v0S3BNVjvza6uY6dz5MphAeOx+SC5YAzUzs1hy6YjVYkccuBbf1/N8/a37hGVVuQ1G7eAZzGYZavf0hLWFrYNjAmUcyjkCZtYrGlMp3l5AZhPXIaFJU12KH0TT1hwY56RyQFphf/4XZyQJ2HKa9XGkF8htARYjojWZ8OHIfXyyNLhJ99pkFAqdgHW1jmun0TGZJ8pdw6J6AuUzzbIEKjuIhqmw1IYJgB8vx9YHVEqriccmji2R4TRz+A38WXovNlUpioGmkUpVsSPqtRtNIlJTlM4DjqtgMXPmwilypRqTkC4nijzsAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=spectrum-os.org smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4+EeWcSoAxR86jRVKs8/zsAHETZCIvxVnaYzEDBCzCI=; b=LDd0Nijpb7QyG8hR+m39nc5z3YWLB2Upfb7efEosWZkU6H1fON2FToXY04lOSPUTLkANkZ6QipO+PKXRcSg4BVNm/UyZ8IDHKU5HVkBfeMC2trw30SoaPcX+KAhGevRqPStHhFFennJCH67/Z7Gfsnwuq4/N76OH0BhmkiVc1kRR9BzUnDmtSCqECfkk3dv3jR3Qee0Z88SjHip53ap19buM8W6voDlawCWwhBl1ZU9pIAo3Qcq1GZ8r5F1KBAkvdcm0Utph1RswNocpwC416nQQRxdYu3wnTubOdjop8965LxDLHIbJmbENHPcKyXAy0ZUx3lv0LGA/mizGyX16fA== Received: from CWLP123CA0049.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:59::13) by LO2P265MB7187.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:329::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Sun, 22 Sep 2024 15:34:04 +0000 Received: from CW2PEPF000056B9.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:59:cafe::6e) by CWLP123CA0049.outlook.office365.com (2603:10a6:401:59::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.23 via Frontend Transport; Sun, 22 Sep 2024 15:34:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by CW2PEPF000056B9.mail.protection.outlook.com (10.167.240.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Sun, 22 Sep 2024 15:34:04 +0000 Received: from MORPHEUS-LINUX.localdomain (lfbn-ann-1-100-60.w86-220.abo.wanadoo.fr [86.220.73.60]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id E0D28ACA004C for ; Sun, 22 Sep 2024 15:34:03 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id D711B1A5A2B for ; Sun, 22 Sep 2024 00:52:38 +0200 (CEST) Date: Sun, 22 Sep 2024 00:52:38 +0200 From: "Dom (shymega) Rodriguez" To: devel@spectrum-os.org Subject: Re: [PATCH] lib/common.mk: move .POSIX out Message-ID: References: <20240908144749.842619-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uxgl4h6he4nokzih" Content-Disposition: inline In-Reply-To: <20240908144749.842619-1-hi@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CW2PEPF000056B9:EE_|LO2P265MB7187:EE_ X-MS-Office365-Filtering-Correlation-Id: 866d3e81-738b-4212-16aa-08dcdb1bfd87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|34020700016|36860700013|376014|82310400026|36200700002; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UHhhYU9lOGZiR3hxbmdIUzhNTWJUMENseDFIeEkxeWVrMGtxeTN0OTB6YUY4?= =?utf-8?B?T1ErUFVUcEJNdENueG8vbzBhRmFBYmhQcy8yRHQ1MGNZYzYwQTk3am41bjlM?= =?utf-8?B?clpMTUovamYraGU0ZWtSZnljb0w2TktxSjVtTzRKa0p0Y3lhK041QWc2cWlZ?= =?utf-8?B?TzlvZ3F6Yi9IZFhYb3pIUTlOMVp3OFUzZFJOYnhqRzkyNDRPeUNaaUNCWUFZ?= =?utf-8?B?UTV0UGZIU1VLT0VlNmRRTDlQK2l0UmZkS29HZkdRK0U2eG5HeWZEdnYvVGJW?= =?utf-8?B?OGNJNHNISGNpWUUxK21VNkRoZ0laNUZVK29LZDdUaGhhYW5STXc5YlpBTEsz?= =?utf-8?B?NWVUZVdoM0JMNGN5N245c2I1b0o5SGF5TmZZa0F5TjRlakpkODJVZGY1MThp?= =?utf-8?B?c2dJTkxIWmJKcHgvMEJsbDZzNnJtcmVDbzZuRWhVMEJlQjhYbWtseWRMVXcv?= =?utf-8?B?OGVlb0xxOGlIQVIrU3dQMGs0L0dXdUFTY0thMG5ONVJqSGdKcUJWMHBHdEJt?= =?utf-8?B?d09UOThaYTJXQjZNU00rdGlPSHo0UWdYeWNFTkp2aG5tSWpYbjF6dVJkaFVy?= =?utf-8?B?cG8wbHRsK29BUzdSeWM3djNOeUdJY2pCRDFlc2NJWlVvOFZXUGh2b2Y2ZEF6?= =?utf-8?B?NkJJTGF4UWFFclV2a1MzU0E3ZTMrVkp2V0pyUENqbzVFdm14R1A1VmRxNlhr?= =?utf-8?B?cjM4b3hDRVJQNmVzbDg5Ymh5ZDVYQXpvdDVMRzU3T2ZYVi94ZldiRU42djgx?= =?utf-8?B?eFRYTEMrZGl3eXphckJQSDJMSnJnazF0d1paVHJNenZaY2J2Q2lrY2hEVyta?= =?utf-8?B?cVdSTmNGS3NwSGVSeSt2dzZ0dmZ2V2FDYmxtQU5BN1pwRHBDcGNWUWpZbDJ1?= =?utf-8?B?VEk0YkRJQU9Pczg2d2xrUkYwZ3lyZFFER2NSaURFMmovVEFZallMbDUwMmxT?= =?utf-8?B?azdtS2t5eUM0bUZ6NDQ2dzlxQ09aSElFTHJjSDcrajcrRFR6UHN4VSszWGtW?= =?utf-8?B?ZTF1MXowelVrclh1WHhQdDRDS3hCTUpCWnVWa3RXNjNoUmxOWlhTS25MWVNi?= =?utf-8?B?N2VGTElnVTlwdXNCSzduam9xWFFITEMzczB0c3llclpFQmVOU1NQcnhwOVNs?= =?utf-8?B?a0xrTzdxUWVCcW1pUEg1MnBuaThSNU9rb2VENEsxTkdtV0htRnBiU3pkckc3?= =?utf-8?B?TjVrbi9IL3pjeHJLaC9jWGt0eXBJaXdVVU1vNEM0VXdmMjk5VStwOFpDRTV1?= =?utf-8?B?YmZaZm9pQ2Q0K2hPQ3N5a3N0blBVdWNCQnJRRTFZTnh3NHU2amZFT0pvR2pX?= =?utf-8?B?aUozQlZaYndNTU9uTlNXczczall0L0dJMWtnY0xvbjFpUi9NMThtWmcxbTIz?= =?utf-8?B?QWIxZ2ZXU2Rram4yR1E4RDZwYmpPeVYvT25pQ2FxSmhpN21aMU9kSlZPRFFZ?= =?utf-8?B?RE9lakwvVFFWaFZIdXJOaHNqL1cxcSt6YXZkNytycFY5bUZaUFdjWWExb3gx?= =?utf-8?B?bzhDbWhBREh2TjhMZm1BMVl0TmxDQUZyQ0MzT09FSVlQWWQxTVhZcUFURXBz?= =?utf-8?B?RGptNDRrYStieHVOcWw1Z2pJaGhvMkRpTkYwKzIybVlQcC9Ub284UFFRam1m?= =?utf-8?B?ZldyZi9KOTZHVlJRcFpGdFpUWWhqWk1mL1E3Smt2UUJ5UHd0N0t1TENXdkZC?= =?utf-8?B?VERrbGJpL2pKRFJ5d2hNUlVWN2J4aDJ0aUZHVlQ5KzZKM1NqUEI1UWJDVXZt?= =?utf-8?B?UjhtTnRTWWVQUllJYVU0bjJKcDFPY0gzZFNQVytKMTZNY01jMFF2R2RUaFpu?= =?utf-8?B?S2ErMFN3UlNKS2VWZWFuODlGb3RLNGR4RDdTNm1HTE1MK3dOZEpjcjlVNHkv?= =?utf-8?B?U0VFNnBzK2dVQWRnWGg3K0ZDUVBUNHVHUnhteWIxbENZWTE0UDZYUUtKRUFG?= =?utf-8?Q?LaIdsZbVFdk=3D?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(1800799024)(34020700016)(36860700013)(376014)(82310400026)(36200700002);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 15:34:04.3075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 866d3e81-738b-4212-16aa-08dcdb1bfd87 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: CW2PEPF000056B9.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB7187 Message-ID-Hash: 32QRT7XM2FQMAL6UZGVDAWWAHMAVMQSN X-Message-ID-Hash: 32QRT7XM2FQMAL6UZGVDAWWAHMAVMQSN X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --uxgl4h6he4nokzih Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable LGTM. Reviewed-by: Dom Rodriguez On 08.09.2024 16:47, Alyssa Ross wrote: >The standard says the following, so I don't think it's specified that >it's allowed to be in an include file: > >> If it appears as the first non-comment line in the makefile, make >> shall process the makefile as specified by this section; otherwise, >> the behavior of make is unspecified. > >Link: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/make.html= #tag_20_76_13_04 >Fixes: c3fbeca ("lib/common.mk: init") >Signed-off-by: Alyssa Ross >--- > host/initramfs/Makefile | 2 ++ > host/rootfs/Makefile | 2 ++ > img/app/Makefile | 2 ++ > lib/common.mk | 2 -- > release/live/Makefile | 2 ++ > vm/sys/net/Makefile | 2 ++ > 6 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile >index 06f69b3..8382296 100644 >--- a/host/initramfs/Makefile >+++ b/host/initramfs/Makefile >@@ -1,6 +1,8 @@ > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross > >+.POSIX: >+ > include ../../lib/common.mk > > dest =3D build/initramfs >diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile >index f4fb7a4..2f4445d 100644 >--- a/host/rootfs/Makefile >+++ b/host/rootfs/Makefile >@@ -1,6 +1,8 @@ > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross > >+.POSIX: >+ > include ../../lib/common.mk > > dest =3D build/rootfs.erofs >diff --git a/img/app/Makefile b/img/app/Makefile >index 3adf8c4..79dd22e 100644 >--- a/img/app/Makefile >+++ b/img/app/Makefile >@@ -2,6 +2,8 @@ > # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross > # SPDX-FileCopyrightText: 2022 Unikie > >+.POSIX: >+ > include ../../lib/common.mk > > prefix =3D build/host >diff --git a/lib/common.mk b/lib/common.mk >index 8f11ecc..7733878 100644 >--- a/lib/common.mk >+++ b/lib/common.mk >@@ -1,8 +1,6 @@ > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2021, 2023 Alyssa Ross > >-.POSIX: >- > # qemu-kvm is non-standard, but is present in at least Fedora and > # Nixpkgs. If you don't have qemu-kvm, you'll need to set e.g. > # QEMU_KVM =3D qemu-system-x86_64 -enable-kvm. >diff --git a/release/live/Makefile b/release/live/Makefile >index f45870d..a8c81c3 100644 >--- a/release/live/Makefile >+++ b/release/live/Makefile >@@ -1,6 +1,8 @@ > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross > >+.POSIX: >+ > include ../../lib/common.mk > > dest =3D build/live.img >diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile >index 00757db..2c2f084 100644 >--- a/vm/sys/net/Makefile >+++ b/vm/sys/net/Makefile >@@ -1,6 +1,8 @@ > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross > >+.POSIX: >+ > include ../../../lib/common.mk > > prefix =3D build/svc > >base-commit: 0f5cfe23285d31c3f7ea1d0fbca967fa8bae8d59 >--=20 >2.45.2 > Best wishes, -- Dom Rodriguez GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43 --uxgl4h6he4nokzih Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6w1F5tDcG6GitfwkctzxIx5UvUMFAmbvTjYACgkQctzxIx5U vUP+pA/8DaByeuKaf1Oy0ZW3X2ts+NbCJOhoeo3dgxe865N8PvHYYt6jDBsUUEoT ivTcKiP1UlXbhB/7yC+SRCUDgno9JztFSb20qlS1NUgi2Iak1gz9+3IBtYxR5jEK qSnCsO0+mUdp2y+T0xFPmeOCRuCI/ELwOjQ5jyGovkBS8SNJ3WRNzem3VydYvqqL QYbnmHr2qn/ciKTC7S29Lii92cCS+L+KYDIyaoHUhosBYN3EDf1vLherSD8XYkys cNI4CJOvMaw2EKvT4Sl2LKpZnD0Nd+wEucOs9Wu9bEmQvR1ELSh9KmibLyw5wg+M fEU6aBSvsoZhbNnyBVxjYfBkR9tArrkTWGDrUS4lsYwRDVluo9CPCl1cUdGFbYuJ 8dIIMEKNrsZAxLzaxpB+TwwH7oJhUz4F9vETDSnLFhEM3PvmEe7GccfPm7GFmW6y k4AvaFG8Vw4ya+4TI/qpOkCU2t1Oi4LkT0fNe/s39ta1vF2UKC0JbB+51YKMmYJg KhMcwJPGzgEyYkvSLYH5LUOY4iOfbTOT0laFat4Wv70L3DtH8uogTXwavuVCQfOx 50eOe9WLAe98TzuHsIFAI2SInX9p1Vfu3FJmD5XxquNveOWEQ+aCLncRH6sHY1Fa vzZ8aCtJS0NW77l1f7HQA9MlK0i2Ou61TP5RFWQZOUuzXq1tmNY= =N2H7 -----END PGP SIGNATURE----- --uxgl4h6he4nokzih--