From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B6D99105A3; Sun, 22 Sep 2024 15:34:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 42643104D1; Sun, 22 Sep 2024 15:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: *** X-Spam-Status: No, score=3.1 required=5.0 tests=DATE_IN_PAST_12_24,DMARC_NONE, FORGED_SPF_HELO,KHOP_HELO_FCRDNS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 Received: from LO2P265CU024.outbound.protection.outlook.com (mail-uksouthazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c205::3]) by atuin.qyliss.net (Postfix) with ESMTPS id 77B141058A for ; Sun, 22 Sep 2024 15:34:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=POuleYexzg/qTVjDt6/OQqgZ4cRpsQG9Q2gZAR+kD36ymYZlDXiGbv8VMvFZdljbJkyoA5ZA0Y9C9OGkNvmYrY5Ku4WjxB2389aTLbac69v+ayKecobbiNSmc3dZNNlNci4JqWrveVn5Xx7xJmqGsOGDtGlJWB7DjToNCYt/Z8O84Z+5TclCbZB9pUab9b+/4lgRPplpki4Ig/ts0YgsxtoenwdwSfz+UiQ2pbBoZWBNqo0DhIZQIEiPqfOS8KMjHpxyDHqkCYVdGiFs12eoD3JZXkLFjVXbRjPELi4KMmUluQ6RV65ckaCAdKyXvGgHBxk29fxh2KoTNcaIB0h8jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oiuarKG+1wldMCGwNy66YHvXwyAY4ockX/wzEE8fiLU=; b=Dk5MblD/ajw1JZKlYnKIo9tLYWkdd11MisUSuG1/GPw98hSoPAz4ja+kx1CyXS6evL2pvJ2Sr6TkZA4xJbYBE/kAlTkKKkb2Zf29zMklH9qpJp8TndEe6F3h80qy8Vv0BR82jPsMWYo7rLjdEZfafqdW4s6EuOlthe5V9yfPQqMm6LS9DvrOz/vYVZI9ULIQxiidWx+16KE1kFDf8WTq/CDOzJip5F4cA6rr41hDibvPuPsGL6eY2zZ+zONj2N4sLjEKybYl6CPfy3P4A63Za7mWABZ4AcQKxBfSbtzl58aKhggFSopiW0EOb1/lqmlwCSodSWwIXFau/+6aITAEag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 62.210.214.198) smtp.rcpttodomain=alyssa.is smtp.mailfrom=shymega.org.uk; dmarc=pass (p=none sp=none pct=100) action=none header.from=shymega.org.uk; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shymega.org.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oiuarKG+1wldMCGwNy66YHvXwyAY4ockX/wzEE8fiLU=; b=n/WIfrUi4Ej325EQhxN2+H89rYn3KQ4X8G4PDhY02jx/LnIS9MHwLxHYcZ8/DWyvxxOaZCRCGkEM57DkkHqE+xGWMAc9bIwRwn3ig/r1719TONjoz2iMhHRrZLuSplVViYt9vdapjHY4qhOzDaMbVaBJOQErnejymWY4Jw+eD7G9OuY5aEhHpvOVHpfNJCJ0jgh+uEEVwcCQ9iLsVb6n7laDsSdw6LvNRAe3XKJ3RG7ZswE7KPbSooC/HfnbipRjefBrTru/hWFO+NNZhWWFM47RbbBj/SxtGoY5h7yWW09FWKQLo2/Ib2JMUxdl+sGzT/AWUuLKrOofj2xJToLM/w== Received: from LO4P265CA0195.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::12) by CWLP265MB1843.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Sun, 22 Sep 2024 15:34:09 +0000 Received: from LO1PEPF000028CC.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318:cafe::db) by LO4P265CA0195.outlook.office365.com (2603:10a6:600:318::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.24 via Frontend Transport; Sun, 22 Sep 2024 15:34:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 62.210.214.198) smtp.mailfrom=shymega.org.uk; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=shymega.org.uk; Received-SPF: Pass (protection.outlook.com: domain of shymega.org.uk designates 62.210.214.198 as permitted sender) receiver=protection.outlook.com; client-ip=62.210.214.198; helo=oracle.rodriguez.org.uk; pr=C Received: from oracle.rodriguez.org.uk (62.210.214.198) by LO1PEPF000028CC.mail.protection.outlook.com (10.167.240.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Sun, 22 Sep 2024 15:34:04 +0000 Received: from MORPHEUS-LINUX.localdomain (lfbn-ann-1-100-60.w86-220.abo.wanadoo.fr [86.220.73.60]) by oracle.rodriguez.org.uk (Postfix) with ESMTPSA id AD89AACA004B; Sun, 22 Sep 2024 15:34:03 +0000 (UTC) Received: from MORPHEUS-LINUX (localhost [IPv6:::1]) by MORPHEUS-LINUX.localdomain (Postfix) with SMTP id 4AF151A5A2A; Sun, 22 Sep 2024 00:52:21 +0200 (CEST) Date: Sun, 22 Sep 2024 00:52:21 +0200 From: Dom Rodriguez To: Alyssa Ross Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args Message-ID: References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jzod3bmmuoad4sx2" Content-Disposition: inline In-Reply-To: <877cbnfmdf.fsf@alyssa.is> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO1PEPF000028CC:EE_|CWLP265MB1843:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b59b34a-7934-45cf-fe4d-08dcdb1bfd57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Tmg4bldjWlhUZDBpd1dMdzh3L2Y0Y0lIRU40SnJIOW9acGtZWnRpbCtzQ2hz?= =?utf-8?B?eVZjOHpHSzhRSjRYWWEvYjNQNWtVQ1Zod1l1R0ZkdTFTdWFwTC9LTzZ6d0ln?= =?utf-8?B?MDZHTE1XcWJQRXdkS0xBaTU3VGc1Wm5YZ3hOV0NLKzROVkIxQncrSUFnbS80?= =?utf-8?B?Wm9jUXZsTXZIaENLRHZ4aXBzYStxZXErT3NMQUtIYzlHZXJyMkVwWk1WY1Fs?= =?utf-8?B?SVFpeEtaT1BmQ1JWLytnNWptZWxBNXdJbnlwZEt1eDFaVmt1Mzk5eTlJU3Fx?= =?utf-8?B?d3FsZ3VvdHlMbHJWWjduZG1aSituY2FjUjFvamJ6L2F1VkdiOTdlckhWYWlK?= =?utf-8?B?UW1DVHNTZlI0a0pVTHpoekdOZmk1d01wczcrNlhXTmg2a3duY21KYXp2cTZS?= =?utf-8?B?cis2Rkd5S1FTVG1IL1hNZ1Y2WmRwQ2FiRVhtM2dDcWNhVlRLSTRKUVFtSVFw?= =?utf-8?B?cUlrYXY2aUdtSDF4QXlLNkVEVU1lUEsrN3BVNHA1VWc2UWNHYzN3cHF0dnU1?= =?utf-8?B?b0FldnlWUS9BbVZaL1hteHNHRThCTVRlcTNob3R3aExLbEJXdW1xN01MWnM5?= =?utf-8?B?VUloL0VjRTB1bWFqWlE0cDRNbmpjeldMbkpLaVJjNEZtWGFqODRmalIvd0ZW?= =?utf-8?B?aFIrR0psVmVudWFVRHRheElzRGpZcE50eXJzUXIrcVQrQnVTam83eWxSZWxK?= =?utf-8?B?TjJUcFNGaGROWnU3dXI3eXVQWmxsbVEvWlpVamE1b2MxU3UxalIzalVTNWtv?= =?utf-8?B?Q0xxWU1GcEVIL2tIUGpkVk8rVmlVVWtyRy91UUxFUzZNVEVFTmNvQ1VmN0tv?= =?utf-8?B?UERhRDA3T3JmWGFCczhTRGhCVEpUQjFyMlM0RHhraE5mYUFreDhWRzhqM2ds?= =?utf-8?B?dlcwVTRiM3RvMHFsSlVocmFlRjJVUUNMajlOSk9wK1lOWklZRitIdDFMNEJx?= =?utf-8?B?T2dyVG5lQWU0R0lPbHRPaGlVeHpNZnBPSjEybXJxUWo2bjlmdWpUdS9vNDlo?= =?utf-8?B?czROZzA5V0kvd3Fqdk1KSEUybEdUcjYvWnVJdmozaUlrYkVDTk1KUktNZVdw?= =?utf-8?B?ZWVDZFJFSFhRREs2NzkzSXkzaUJ2bm1zb0d3QnNjVXFVdWcyY28yV0ZpTURK?= =?utf-8?B?bWtNUjJDRzVTQ1JMajMrcHJYNGRnMHRpYVAzTXd1Rjd0dUpLUjh0U29rRjR1?= =?utf-8?B?V29UeCtMRjMwZ2ZMUmE5NDZTVXRBbC9XcGRqb2FKazVPdWk2RUpJQmJUcGpl?= =?utf-8?B?Q29MbGFtR2tOK1FkaUNrSGRyUG9oYkU1eWw3bFdsOHo0VEk1SlFiL2MyK0xJ?= =?utf-8?B?ZUovc3dSQmFhRVIxV1V6RjNpclNyT3BxYUhQTU9NOWlqaTY1SmlpbVZjQTZK?= =?utf-8?B?QmlmQnFGZFJMdTZIMkEwM0pvdHJNZEZaRXhxNnAvRkw4RHZldEtlYVBlWmZj?= =?utf-8?B?M1NkK0RhV3d2ZFMva0JibFNMamZ6NWVUM3JHdjk4eEErUVhCNm5rZkVrZThC?= =?utf-8?B?VWk2N0hJcHUxVDE2czc2aWtITXp1S3ZjYlQrazA1NjFFQUlMNE9yL1MwQnA2?= =?utf-8?B?WFVWTFVZV0ExMDY5SVJLaFgzaE9KMERWMnJkalkxMTg4L0x1dlovSjZaU2pF?= =?utf-8?B?TTRUdG56WnlWcVVhNkFUVlMxUGhrc1ZoNWJ4d1RDc1FjQmp2bWs5MUdvenFD?= =?utf-8?B?KzlxSkJOMUM3WCtwdTNjd0diQml5YXZVY0wvb1IyYS9tUUc2VWkwZkVQY1RH?= =?utf-8?B?RnFMaGo4TkxOVFZsUnhmZEkvMmV3WVVRcFE0akJJRERtOW9maExOMDBLOG9h?= =?utf-8?B?a2UzcEk3aGNOTk9YbnhVQmpRditncnRjZWlCQ1JKTVdqM0NUWlZ4aG9JMUZn?= =?utf-8?Q?E1OFSClGWJvDz?= X-Forefront-Antispam-Report: CIP:62.210.214.198;CTRY:FR;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oracle.rodriguez.org.uk;PTR:oracle.rodriguez.org.uk;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: shymega.org.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 15:34:04.0457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b59b34a-7934-45cf-fe4d-08dcdb1bfd57 X-MS-Exchange-CrossTenant-Id: 7e15dc52-0465-4028-b82a-3c894bbc5ba6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=7e15dc52-0465-4028-b82a-3c894bbc5ba6;Ip=[62.210.214.198];Helo=[oracle.rodriguez.org.uk] X-MS-Exchange-CrossTenant-AuthSource: LO1PEPF000028CC.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB1843 Message-ID-Hash: B3G6ZMSYJXFJYV5CEYPIRL72XRYQBBHU X-Message-ID-Hash: B3G6ZMSYJXFJYV5CEYPIRL72XRYQBBHU X-MailFrom: shymega@shymega.org.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --jzod3bmmuoad4sx2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 07.09.2024 18:40, Alyssa Ross wrote: >Dom Rodriguez writes: > >> crosvm was producing warnings when using `--vhost-user-gpu` and >> `--vhost-user-fs`. >> >> In this commit, I have adjusted the `crosvm` invocations to look >> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, >> `gpu` or `fs`, and `$PATH` is the path to the Unix socket. >> >> Signed-off-by: Dom Rodriguez >> --- >> img/app/Makefile | 4 ++-- >> release/checks/wayland/default.nix | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/img/app/Makefile b/img/app/Makefile >> index 3adf8c4..11ef6e1 100644 >> --- a/img/app/Makefile >> +++ b/img/app/Makefile >> @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd >> --disk $(RUN_IMG) \ >> -p "console=ttyS0 root=PARTLABEL=root" \ >> --net tap-name=tap0 \ >> - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >> - --vhost-user-gpu build/vhost-user-gpu.sock \ >> + --vhost-user fs,socket=build/virtiofsd.sock:virtiofs0 \ >> + --vhost-user gpu,socket=build/vhost-user-gpu.sock \ >> --vsock cid=3 \ >> --serial type=file,hardware=serial,path=build/serial.log \ >> --serial type=stdout,hardware=virtio-console,stdin=true \ > >This is still not right, I'm afraid. > >When I run nix-shell --run 'make clean && make run' VMM=crosvm in >img/app, I get this error: > >[2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error 1: failed to connect to vhost-user socket path build/virtiofsd.sock:virtiofs0 > >Probably the tag should also be a comma-separated key=value option? > >(This doesn't have any automated test, because it's just part of the >development environment, and setting up a test environment to resemble a >development machine isn't trivial. Should be possible though.) It's bizarre. I've done some more testing, and it seems that `--vhost-user` isn't *quite* there yet on feature parity with `--vhost-user-fs`. Maybe I'm going wrong here, but it doesn't recognise the tag as a k/v option. I have managed to get the tests running with `--vhost-user-fs`, but it does look mismatched now. Would you prefer I revert the changes to `--vhost-user fs` => `--vhost-user-fs`? >> diff --git a/release/checks/wayland/default.nix b/release/checks/wayland/default.nix >> index d05aa88..a36dbab 100644 >> --- a/release/checks/wayland/default.nix >> +++ b/release/checks/wayland/default.nix >> @@ -29,7 +29,7 @@ nixosTest ({ lib, pkgs, ... }: { >> systemd.services.crosvm = { >> after = [ "crosvm-gpu.service" "weston.service" ]; >> requires = [ "crosvm-gpu.service" "weston.service" ]; >> - serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user-gpu /run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux"; >> + serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user gpu,socket=/run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux"; >> serviceConfig.ExecStop = "${lib.getExe pkgs.crosvm} stop /run/crosvm"; >> }; > >This part works now though, thanks! Awesome. I'll leave that as-is for the next patch revision. Best wishes, -- Dom Rodriguez GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43 --jzod3bmmuoad4sx2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6w1F5tDcG6GitfwkctzxIx5UvUMFAmbvTiUACgkQctzxIx5U vUPO9w//Y96VMEcg3J/tDY+Kutk4ygXD4ggo/BGCK+rb0pH2jx1gzjua7oEfKQ+x +Xz0ZTLSdYCQiOtpMGRH5FrZGga5RMJGqPo9mURUTAt0qLscwF/5Y0cKnTFWSIxZ zHaRhUAEnAPcyzUVby97nGlmTpSdskVAqAwdG60zrr5KDXzncW1lk605KlGIkBqh D8ci0V0m085yfk2mdDB0bYAdUX/MePNoyzd0KDFoUjLUsdHLIYrhUbecCvnqCXaf YKazKeLJY3YQCWo+fjRuk+jikwB76Fn0qrVl92+oVh9NxF0qOqlGAGdp0gC4troD fsMnvJQcR0O6jyMfwueWKkWEwi+BjGzY34aDScMCLletC0MtaChARfuzG5rwL9gC MD1X9D4E+xnDK9zSD5FFfXjkxPbFdoFLDyh6XRppaNI73ZSfF/Nl4wTb9yuezPyY z/XWI8o5THHWdj56E58a1tgApP7QPDVzVtWIFoaEc8NMSUoXjYgQb+Lt8cA0r3BV 7MBZ2NpcVdFY3n7y0MmaEheqhmuTQjwWUXdvloTHAy8e6GJWC5MetNXPRiY4qYzf 7cerjq4NfEfKKD5YldVz+MgVopOw3cp0Jr4RJ9Kyq90gHZ10QcusV7/opLtzjaDs kznn2CFdTB7fXxoMm+Mqh2uYH+Mxtm0w2ts1d0P3ViRfGbyw6B8= =K/Dv -----END PGP SIGNATURE----- --jzod3bmmuoad4sx2--