Re: make run fails: make-gpt.sh: 9: set: Illegal option -o pipefail

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 2085 bytes --]

Dan Connolly <dckc@madmode.com> writes:

> On Mon, Mar 30, 2026 at 7:44 PM Dan Connolly <dckc@madmode.com> wrote:
>
>> ../../scripts/make-gpt.sh build/live.img.tmp \
>>     build/rootfs.verity.superblock:verity:$(../../scripts/format-uuid.sh
>> "$(dd if=build/rootfs.verity.roothash bs=32 skip=1 count=1
>> status=none)"):Spectrum_'0.0.0.verity' \
>>     build/rootfs:root:$(../../scripts/format-uuid.sh "$(head -c 32
>> build/rootfs.verity.roothash)"):Spectrum_'0.0.0'
>> ../../scripts/make-gpt.sh: 9: set: Illegal option -o pipefail
>>
>
> A small fix (attached) worked for me.

Hi Dan, thanks for the patch and sorry for the late response.

This is actually not a bashism — POSIX adopted it in POSIX.1-2024, and
Ubuntu's version of dash supports it since Ubuntu 25.04 from what I can
tell, which means the most recent Ubuntu LTS, 26.04, should have it too.

I appreciate that 26.04 only came out a few days ago (weeks after you
wrote your message), but now that it has, my instinct is that it's
probably not worth supporting older LTSes.  Every variance like this
needs to be cleaned up at some point in the future, and the older a
distro is the more likely it is that it's not going to work anyway due
to old kernel bugs or dropped support from VMMs.  I might be a bit too
aggressive in my stance here though — what do you think?

> Then I got a permission error, so I had to do:
>
> sudo usermod -aG kvm $USER
> newgrp kvm

Interesting!  Not much we can do about that in Spectrum, but I wonder
why Ubuntu chooses to vary from the systemd default, which lets any user
use KVM.

> From 082882cc981566891ec17ccedd291b930502c91e Mon Sep 17 00:00:00 2001
> From: Dan Connolly <dckc@madmode.com>
> Date: Mon, 30 Mar 2026 22:11:39 -0500
> Subject: [PATCH] fix: don't rely on bash-isms in /bin/sh scripts
>
> ---
>  scripts/genfiles.sh | 3 ++-
>  scripts/make-gpt.sh | 3 ++-

FWIW there are also some pipefail uses in Makefiles that would need to
be taken care of.  I can do this separately if you prefer if I end up
applying this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]