Re: [PATCH] release/checks/whitespace: skip binary files

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Valentin Gagarin <valentin@gagarin.work> writes:

> Trailing whitespace is meaningful only for text.
>
> Signed-off-by: Valentin Gagarin <valentin@gagarin.work>
> ---
>  release/checks/whitespace.nix | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/release/checks/whitespace.nix b/release/checks/whitespace.nix
> index 56710b6..3929c8f 100644
> --- a/release/checks/whitespace.nix
> +++ b/release/checks/whitespace.nix
> @@ -9,6 +9,6 @@ runCommand "spectrum-whitespace" {
>      fileset = srcWithNix;
>    };
>  } ''
> -  grep --color=always --exclude='*.patch' -r "[[:space:]]$" $src || touch $out
> +  grep --color=always --binary-files=without-match --exclude='*.patch' -r "[[:space:]]$" $src || touch $out
>  ''
>  ) (_: {})

Thanks — definitely an improvement.  I'm going to tweak to use the
shorter -I to keep the line length manageable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]