From: Alyssa Ross <hi@alyssa.is>
To: Valentin Gagarin <valentin@gagarin.work>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH v2 3/3] Documentation: uniform navigation across all pages
Date: Fri, 12 Jun 2026 10:44:42 +0200 [thread overview]
Message-ID: <87bjdg9mh1.fsf@alyssa.is> (raw)
In-Reply-To: <20260611063724.487914-3-valentin@gagarin.work>
[-- Attachment #1: Type: text/plain, Size: 2966 bytes --]
Valentin Gagarin <valentin@gagarin.work> writes:
> diff --git a/Documentation/_includes/footer_custom.html b/Documentation/_includes/footer_custom.html
> index 2477920..db29f82 100644
> --- a/Documentation/_includes/footer_custom.html
> +++ b/Documentation/_includes/footer_custom.html
> @@ -2,9 +2,6 @@
> SPDX-FileCopyrightText: 2020 Alyssa Ross <hi@alyssa.is>
> SPDX-License-Identifier: CC-BY-SA-4.0 OR GFDL-1.3-no-invariants-or-later
> {% endcomment %}
> -<p>
> -<a href="https://spectrum-os.org/git/spectrum/tree/Documentation/{{ page.path }}">Source code for this page</a>
> -
> <p>
> <small>Permission is granted to copy, distribute and/or modify this
> document under either the terms of the
> @@ -15,6 +12,9 @@ Documentation License, Version 1.3</a> or any later version published
> by the Free Software Foundation; with no Invariant Sections, no
> Front-Cover Texts, and no Back-Cover Texts.</small>
>
> -<p>
> -<a href="/sitemap.html"><small>Sitemap</small></a>
> -<a href="/impressum.html" lang="de"><small>Impressum</small></a>
> +<p><small>
> +<a href="/sitemap.html">Sitemap</a>
> +·
> +<a href="https://spectrum-os.org/git/spectrum/tree/Documentation/{{ page.path }}">Source code for this page</a>
> +·
> +<a href="/impressum.html" lang="de">Impressum</a>
Needs a </small> here — it's not optional like </p> is per the spec.
I can fix when applying if no other changes are needed.
https://html.spec.whatwg.org/multipage/syntax.html#optional-tags
(When I was writing the website content originally I liked that omitting
the </p> tags helped keep the source clean, but it's an obscure HTML
feature other contributors are unlikely to be familiar with, so I
wouldn't object to changing to avoiding tag omissions even where
permitted by spec.)
> diff --git a/Documentation/_layouts/page.html b/Documentation/_layouts/page.html
> index 230b601..f2cf0f6 100644
> --- a/Documentation/_layouts/page.html
> +++ b/Documentation/_layouts/page.html
> @@ -3,7 +3,7 @@ SPDX-License-Identifier: GPL-3.0-or-later
> SPDX-FileCopyrightText: 2026 Valentin Gagarin <valentin@gagarin.work>
> {% endcomment %}
> <!doctype html>
> -<html lang="en">
> +<html lang="{{ page.lang | default: "en" }}">
>
> <head>
>
> @@ -17,13 +17,10 @@ SPDX-FileCopyrightText: 2026 Valentin Gagarin <valentin@gagarin.work>
>
> <body>
>
> -<nav aria-label="Breadcrumb">
> - <ol>
> - <li><a href="/">Spectrum</a></li>
> - <li><a href="/doc/">Documentation</a></li>
> - <li aria-current="page">{{ page.title }}</li>
> - </ol>
> -</nav>
> +{% include breadcrumb.html %}
> +
> +{% assign ext = page.path | split: "." | last %}
> +{% if ext == "html" and page.no_heading != true %}<h1>{{ page.title }}</h1>{% endif %}
Ah, I've figured out the answer to my own question from last time.
AsciiDoctor renders page titles as h1, so without the extension check it
would be duplicated here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2026-06-12 8:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 16:49 [PATCH 0/3] Documentation: render all pages in one style Valentin Gagarin
2026-06-08 16:49 ` [PATCH 1/3] Documentation: align Jekyll page style to rest of website Valentin Gagarin
2026-06-08 16:49 ` [PATCH 2/3] Documentation: drop Just the Docs Valentin Gagarin
2026-06-08 16:49 ` [PATCH 3/3] Documentation: uniform navigation across all pages Valentin Gagarin
2026-06-08 16:49 ` [PATCH 1/3] Documentation: align Jekyll page style to rest of website Valentin Gagarin
2026-06-09 11:45 ` Alyssa Ross
2026-06-10 12:12 ` Valentin Gagarin
2026-06-10 12:23 ` Alyssa Ross
2026-06-08 16:49 ` [PATCH 2/3] Documentation: drop Just the Docs Valentin Gagarin
2026-06-09 11:43 ` Alyssa Ross
2026-06-08 16:49 ` [PATCH 3/3] Documentation: uniform navigation across all pages Valentin Gagarin
2026-06-09 11:54 ` Alyssa Ross
2026-06-11 6:37 ` [PATCH v2 1/3] Documentation: align Jekyll page style to rest of website Valentin Gagarin
2026-06-11 6:37 ` [PATCH v2 2/3] Documentation: drop Just the Docs Valentin Gagarin
2026-06-11 6:37 ` [PATCH v2 3/3] Documentation: uniform navigation across all pages Valentin Gagarin
2026-06-12 8:44 ` Alyssa Ross [this message]
2026-06-12 8:27 ` [PATCH v2 1/3] Documentation: align Jekyll page style to rest of website Alyssa Ross
2026-06-16 9:35 ` [PATCH v3 0/3] Documentation: render all pages in one style Valentin Gagarin
2026-06-16 9:35 ` [PATCH v3 1/3] Documentation: align Jekyll page style to rest of website Valentin Gagarin
2026-06-16 11:49 ` Alyssa Ross
2026-06-16 12:02 ` Valentin Gagarin
2026-06-17 10:48 ` Alyssa Ross
2026-06-16 9:35 ` [PATCH v3 2/3] Documentation: drop Just the Docs Valentin Gagarin
2026-06-17 10:48 ` Alyssa Ross
2026-06-16 9:35 ` [PATCH v3 3/3] Documentation: uniform navigation across all pages Valentin Gagarin
2026-06-16 12:01 ` Alyssa Ross
2026-06-17 10:48 ` Alyssa Ross
2026-06-16 12:01 ` [PATCH v3 0/3] Documentation: render all pages in one style Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjdg9mh1.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=valentin@gagarin.work \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).