Re: [PATCH 1/3] Documentation: align Jekyll page style to rest of website

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

Valentin Gagarin <valentin@gagarin.work> writes:

>>> +<nav aria-label="Breadcrumb">
>>> +  <ol>
>>> +    <li><a href="/">Spectrum</a></li>
>>> +    <li><a href="/doc/">Documentation</a></li>
>>> +    <li aria-current="page">{{ page.title }}</li>
>> 
>> This probably ought to be ommitted if the current page is /doc.
>> Otherwise I see "Spectrum / Documentation / Spectrum Documentation".
>> 
>> (Not a huge deal though — I see that it's fixed in patch #3.)
>
> This is a means to keep each change limited in scope.  The first patch 
> effectively only adds a sitemap for the `doc` subdirectory.  You can of 
> course squash everything, then it won't matter, but it then will be one 
> huge diff.

I just meant that it could have been avoided with something like the
following in this commit (untested), and then implemented properly in
the later patch, to avoid an intermediate state where it does the wrong
thing.

{- unless page.url == "/doc" -}
<li aria-current="page">{{ page.title }}</li>
{- endunless -}

As I said though, it's not a big deal.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]