Re: Duplicated VM start and shutdown code

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> I noticed that vm-import, run-appimage, and run-flatpak all have the
> same code to start a VM, and run-flatpak and run-appimage both have
> the same code to shut down a VM.  Is this intentional, or should it
> be replaced with common code?

Yes, it probably should.  But it is sort of intentional — sometimes I'm
not sure exactly which parts should be shared, so I leave code
duplicated for a while with the idea that it'll become more clear what
the common core should be over time.  (It usually works out.)  Without a
good understanding, it's easy to deduplicate too much, and end up with
something that isn't flexible enough down the line, and then it has to
be un-deduplicated again.  Happy for you to try deduplicating it if you
think you have a good idea of where to draw that line, but otherwise
it's also fine for it to stay duplicated for now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]