From: Valentin Gagarin <valentin@gagarin.work>
To: Alyssa Ross <hi@alyssa.is>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH v5] Documentation: add logo to site header
Date: Wed, 27 May 2026 14:40:16 +0200 [thread overview]
Message-ID: <31f75148-1b63-4d46-9821-2edb1bfa1c12@gagarin.work> (raw)
In-Reply-To: <8733zdgitd.fsf@alyssa.is>
> We should pick (and document) a preferred order!
Agreed and noted for later.
>> .main-content {
>> // Just the Docs puts titles next to definitions, rather than on
>> @@ -20,3 +21,23 @@
>> margin-left: 2ch;
>> }
>> }
>> +
>> +// Make the logo and title fit the site header.
>> +.site-header {
>> + .site-logo {
>> + width: 3rem;
>> + }
>> +
>> + // Just the Docs displays a sidebar at the "medium size" `md` breakpoint and above.
>> + // Use the upstream `mq` media query mixin to target that breakpoint.
>> + // https://just-the-docs.com/docs/utilities/responsive-modifiers/
>> + // https://github.com/just-the-docs/just-the-docs/blob/v0.10.1/_sass/support/mixins/_layout.scss#L3-L8
>> + @include mq(md) {
>> + .site-logo {
>> + width: 5.5rem;
>> + }
>
> Is there a reason for this number, rather than just setting it back to
> 100%?
Yes, because 100% means different things for different screen sizes.
The media queries seem to be used inconsistently upstream; different
elements shift at different breakpoints... That may or may not be fixed
by bumping the dependency, but that currently is precluded by build
failures. Keeping the font size and logo size fixed doesn't produce
surprises.
I recommend not to put too much energy into this in any case. Aligning
the output style across the current website and "the docs" will likely
make this obsolete one way or another eventually.
next prev parent reply other threads:[~2026-05-27 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 19:21 [PATCH] Documentation: add logo to site header Valentin Gagarin
2026-05-15 17:56 ` [PATCH v2] " Valentin Gagarin
2026-05-18 6:40 ` Alyssa Ross
2026-05-18 21:04 ` [PATCH v3] " Valentin Gagarin
2026-05-20 8:57 ` [PATCH v4] " Valentin Gagarin
2026-05-23 8:57 ` Alyssa Ross
2026-05-23 13:52 ` Alyssa Ross
2026-05-27 11:24 ` [PATCH v5] " Valentin Gagarin
2026-05-27 12:04 ` Alyssa Ross
2026-05-27 12:40 ` Valentin Gagarin [this message]
2026-05-27 14:03 ` Alyssa Ross
2026-05-27 16:44 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f75148-1b63-4d46-9821-2edb1bfa1c12@gagarin.work \
--to=valentin@gagarin.work \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).