Re: [PATCH v5] Documentation: add logo to site header

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]

Valentin Gagarin <valentin@gagarin.work> writes:

> diff --git a/Documentation/_sass/custom/custom.scss b/Documentation/_sass/custom/custom.scss
> index fd5a676..48b1d41 100644
> --- a/Documentation/_sass/custom/custom.scss
> +++ b/Documentation/_sass/custom/custom.scss
> @@ -1,5 +1,6 @@
> -// SPDX-FileCopyrightText: 2022 Alyssa Ross <hi@alyssa.is>
>  // SPDX-License-Identifier: MIT
> +// SPDX-FileCopyrightText: 2022 Alyssa Ross <hi@alyssa.is>
> +// SPDX-FileCopyrightText: 2026 Valentin Gagarin <valentin@gagarin.work>

We should pick (and document) a preferred order!  I don't think we're
consistent at the moment.  On one hand, lexicographic ordering is nice,
but on the other, license is probably more important to see first than
copyright holders are.

>  
>  .main-content {
>  	// Just the Docs puts titles next to definitions, rather than on
> @@ -20,3 +21,23 @@
>  		margin-left: 2ch;
>  	}
>  }
> +
> +// Make the logo and title fit the site header.
> +.site-header {
> +  .site-logo {
> +    width: 3rem;
> +  }
> +
> +  // Just the Docs displays a sidebar at the "medium size" `md` breakpoint and above.
> +  // Use the upstream `mq` media query mixin to target that breakpoint.
> +  // https://just-the-docs.com/docs/utilities/responsive-modifiers/
> +  // https://github.com/just-the-docs/just-the-docs/blob/v0.10.1/_sass/support/mixins/_layout.scss#L3-L8
> +  @include mq(md) {
> +    .site-logo {
> +      width: 5.5rem;
> +    }

Is there a reason for this number, rather than just setting it back to
100%?  Looks the same to me (since it gets flexed down to size anyway),
and I'd prefer fewer magic numbers if possible!

> +    .site-title {
> +      font-size: 1.25rem !important;
> +    }
> +  }
> +}

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]