Re: [PATCH v5] Documentation: add logo to site header

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

Valentin Gagarin <valentin@gagarin.work> writes:

>> We should pick (and document) a preferred order! 
>
> Agreed and noted for later.
>
>>>   .main-content {
>>>   	// Just the Docs puts titles next to definitions, rather than on
>>> @@ -20,3 +21,23 @@
>>>   		margin-left: 2ch;
>>>   	}
>>>   }
>>> +
>>> +// Make the logo and title fit the site header.
>>> +.site-header {
>>> +  .site-logo {
>>> +    width: 3rem;
>>> +  }
>>> +
>>> +  // Just the Docs displays a sidebar at the "medium size" `md` breakpoint and above.
>>> +  // Use the upstream `mq` media query mixin to target that breakpoint.
>>> +  // https://just-the-docs.com/docs/utilities/responsive-modifiers/
>>> +  // https://github.com/just-the-docs/just-the-docs/blob/v0.10.1/_sass/support/mixins/_layout.scss#L3-L8
>>> +  @include mq(md) {
>>> +    .site-logo {
>>> +      width: 5.5rem;
>>> +    }
>> 
>> Is there a reason for this number, rather than just setting it back to
>> 100%?
> Yes, because 100% means different things for different screen sizes. 
> The media queries seem to be used inconsistently upstream; different 
> elements shift at different breakpoints...  That may or may not be fixed 
> by bumping the dependency, but that currently is precluded by build 
> failures.  Keeping the font size and logo size fixed doesn't produce 
> surprises.
>
> I recommend not to put too much energy into this in any case.  Aligning 
> the output style across the current website and "the docs" will likely 
> make this obsolete one way or another eventually.

Alright, patch queued.  Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]